8341666: FileInputStream doesn't support readAllBytes() or readNBytes(int) on pseudo devices

[bplb]

Modify FileInputStream (FIS) to fall back to the superclass implementations of readAllBytes(), readNBytes(int), skip(), and transferTo when the input source would otherwise fail with "Illegal Seek" in the FIS implementation, such as for the standard input or a named pipe.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8341666: FileInputStream doesn't support readAllBytes() or readNBytes(int) on pseudo devices (Bug - P4)

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21673/head:pull/21673
$ git checkout pull/21673

Update a local copy of the PR:
$ git checkout pull/21673
$ git pull https://git.openjdk.org/jdk.git pull/21673/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21673

View PR using the GUI difftool:
$ git pr show -t 21673

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21673.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8341666: FileInputStream doesn't support readAllBytes() or readNBytes(int) on pseudo devices

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 34 new commits pushed to the master branch:

• 1476f6c: 8343030: RISC-V: Small assembler cleanups
• f1a9a8d: 8342902: Deduplication of acquire calls in BindingSpecializer causes escape-analyisis failure
• f1cc890: 8343086: [BACKOUT] JDK-8295269 G1: Improve slow startup due to predictor initialization
• 36d7173: 8339289: Enhance Attach API to support arbitrary length arguments - Windows
• ff165f9: 8342934: TYPE_USE annotations printed with error causing "," in toString output
• 0853aee: 8338426: Test java/nio/channels/Selector/WakeupNow.java failed
• c202a2f: 8295269: G1: Improve slow startup due to predictor initialization
• 5cbd578: 8342930: New tests from JDK-8335912 are failing
• 1e35da8: 8343063: RISC-V: remove redundant reg copy in generate_resolve_blob
• 4f8f395: 8343060: RISC-V: enable TestFloat16VectorConvChain for riscv
• ... and 24 more: https://git.openjdk.org/jdk/compare/de92fe375771315452fc5318abfd228fdd31c454...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@bplb The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 04: Full - Incremental (98f918a9)
• 03: Full - Incremental (e091f157)
• 02: Full - Incremental (0bb34b4d)
• 01: Full - Incremental (d6b679d3)
• 00: Full (69260350)

[bplb]

/integrate

[openjdk]

Going to push as commit 1341b81.
Since your change was applied there have been 47 commits pushed to the master branch:

• 52382e2: 8338021: Support new unsigned and saturating vector operators in VectorAPI
• e659d9d: 8342975: C2: Micro-optimize PhaseIdealLoop::Dominators()
• 9f6211b: 8341371: CDS cannot load archived heap objects with -XX:+UseSerialGC -XX:-UseCompressedOops
• 120a935: 8342561: Metaspace for generated reflection classes is no longer needed
• d5fb6b4: 8339939: [JVMCI] Don't compress abstract and interface Klasses
• a5ad974: 8343056: C2: Micro-optimize Node lists grow
• ec06187: 8034066: Incorrect alignment in the "Code" section for "-c -XDdetails" options
• eb3669a: 8340796: Use a consistent order when loading cxq and EntryList
• 0e3fc93: 8342083: Make a few fields in FileSystemPreferences final
• 762a573: 8335880: More troubleshooting tips around windows space in path
• ... and 37 more: https://git.openjdk.org/jdk/compare/de92fe375771315452fc5318abfd228fdd31c454...master

Your commit was automatically rebased without conflicts.

[openjdk]

@bplb Pushed as commit 1341b81.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.