8338426: Test java/nio/channels/Selector/WakeupNow.java failed

[bplb]

System.currentTimeMillis() is replaced with System.nanoTime() and the elapsed time is added to the failure exception message.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8338426: Test java/nio/channels/Selector/WakeupNow.java failed (Bug - P4)

Reviewers

• Jaikiran Pai (@jaikiran - Reviewer)
• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21674/head:pull/21674
$ git checkout pull/21674

Update a local copy of the PR:
$ git checkout pull/21674
$ git pull https://git.openjdk.org/jdk.git pull/21674/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21674

View PR using the GUI difftool:
$ git pr show -t 21674

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21674.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[bplb]

The validity of using a temporal threshold on elapsed time as a failure criterion, as well as the value of that threshold, are not considered at this time.

[openjdk]

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8338426: Test java/nio/channels/Selector/WakeupNow.java failed

Reviewed-by: jpai, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

• fd5ff05: 8342827: Fix order of @param tags in other modules
• 415d815: 8342938: Problem list java/io/IO/IO.java test on Linux ppc64le
• c548986: 8342918: Building ParallelGC without G1 and Shenandoah fails because SpaceMangler not declared
• ca1700b: 8336665: CCE in X509CRLImpl$TBSCertList.getCertIssuer
• d1540e2: 8342090: Infer::IncorporationBinaryOp::equals can produce side-effects
• 7af46a6: 8340554: Improve MessageFormat readObject checks
• 7d5eefa: 8342862: Gtest added by 8339507 appears to be causing 8GB build machines to hang
• d8c3b0f: 8342768: GTest AssemblerX86.validate_vm failed: assert(VM_Version::supports_bmi1()) failed: tzcnt instruction not supported
• 3c14c2b: 8341566: Add Reader.of(CharSequence)
• b0ac633: 8342075: HttpClient: improve HTTP/2 flow control checks
• ... and 10 more: https://git.openjdk.org/jdk/compare/de92fe375771315452fc5318abfd228fdd31c454...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@bplb The following label will be automatically applied to this pull request:

• nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (a8cc7e9e)

[jaikiran]

This change to move away from using System.currentTimeMillis() in favour of System.nanoTime() looks OK to me.

[AlanBateman]

Changing it to use nanoTime is good but I wonder about the reliability of the select(2000) taking >= 1s. This test has a history of being on and off the exclude list several times over the years.

[bplb]

Changing it to use nanoTime is good but I wonder about the reliability of the select(2000) taking >= 1s.

I am not sure about it either, but I thought that with the addition of the time delta to the exception message it might allow some information gathering about failures should they occur.

[AlanBateman]

Changing it to use nanoTime is good but I wonder about the reliability of the select(2000) taking >= 1s.

I am not sure about it either, but I thought that with the addition of the time delta to the exception message it might allow some information gathering about failures should they occur.

I don't know which clock source is used by GetQueuedCompletionStatus but I agree, using nanoTimes would be better here and if it fails because it takes <1s then it at least tells us something.

[bplb]

/integrate

[openjdk]

Going to push as commit 0853aee.
Since your change was applied there have been 28 commits pushed to the master branch:

• c202a2f: 8295269: G1: Improve slow startup due to predictor initialization
• 5cbd578: 8342930: New tests from JDK-8335912 are failing
• 1e35da8: 8343063: RISC-V: remove redundant reg copy in generate_resolve_blob
• 4f8f395: 8343060: RISC-V: enable TestFloat16VectorConvChain for riscv
• a9eb50a: 8342953: RISC-V: Fix definition of RISCV_HWPROBE_EXT_ZVFHMIN
• 94317db: 8342884: RISC-V: verify float <--> float16 conversion
• 3c5db12: 8342857: SA: Heap iterator makes incorrect assumptions about TLAB layout
• 4635351: 8342939: Building ZGC without compiler2 fails
• fd5ff05: 8342827: Fix order of @param tags in other modules
• 415d815: 8342938: Problem list java/io/IO/IO.java test on Linux ppc64le
• ... and 18 more: https://git.openjdk.org/jdk/compare/de92fe375771315452fc5318abfd228fdd31c454...master

Your commit was automatically rebased without conflicts.

[openjdk]

@bplb Pushed as commit 0853aee.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.