JDK-8183372 : Refactor java/lang/Class shell tests to java #2170

mahendrachhipa · 2021-01-20T17:27:43Z

https://bugs.openjdk.java.net/browse/JDK-8183372

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8183372: Refactor java/lang/Class shell tests to java

Reviewers

Brent Christian (@bchristi-git - Reviewer)
Mandy Chung (@mlchung - Reviewer) ⚠️ Review applies to 9ff23ef

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2170/head:pull/2170
$ git checkout pull/2170

https://bugs.openjdk.java.net/browse/JDK-8183372

bridgekeeper · 2021-01-20T17:28:19Z

👋 Welcome back mahendrachhipa! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2021-01-20T17:29:37Z

@mahendrachhipa The following label will be automatically applied to this pull request:

core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2021-01-20T17:33:15Z

Webrevs

bchristi-git · 2021-01-21T05:19:00Z

Can this be done all in EnclosingClassTest.java, without a new RunEnclosingClassTest.java?

Adding the @BeforeClass and @AfterClass methods to what's there, you may just need to
change the test() calls to use reflection - something along the lines of:

test(Class.forName("EnclosingClass").getDeclaredConstructor().newInstance());

Used newInstance() method to create the different EnclosingClasses at runtime

mahendrachhipa · 2021-01-22T16:57:41Z

Review comments implemented.

mlchung · 2021-01-22T17:53:25Z

test/jdk/java/lang/Class/forName/NonJavaNameTest.java

+ * @build NonJavaNames
+ * @run testng/othervm NonJavaNameTest
+ * @summary Verify names that aren't legal Java names are accepted by forName.
+ * @author Joseph D. Darcy


we can drop this @author in particular this is a new file.

Now this file is deleted.

mlchung · 2021-01-22T17:59:33Z

test/jdk/java/lang/Class/forName/NonJavaNameTest.java

+public class NonJavaNameTest {
+    private static final String SRC_DIR = System.getProperty("test.src");
+    private static final String NONJAVA_NAMES_SRC = SRC_DIR + "/classes/";
+    private static final String NONJAVA_NAMES_CLASSES = System.getProperty("test.classes", ".");


I was at first confused with NON_NAMES_CLASSES of what it means. For simplicity and clarity, better to rename these variables:
s/NONJAVA_NAMES_SRC/TEST_SRC/
s/NONJAVA_NAMES_CLASSES/TEST_CLASSES/

Implemented in next patch

mlchung · 2021-01-22T18:00:59Z

test/jdk/java/lang/Class/forName/NonJavaNameTest.java

+    }
+
+    @AfterClass
+    public void deleteInvalidNameClasses() throws IOException {


jtreg will do the clean up and this is not necessary.

Removed in next patch.

mlchung · 2021-01-22T18:06:10Z

test/jdk/java/lang/Class/getEnclosingClass/EnclosingClassTest.java

+            Files.deleteIfExists(pkg2File);
+            Files.deleteIfExists(pkg2Dir);
+            Files.deleteIfExists(pkg1File);
+            Files.deleteIfExists(pkg1Dir);


You can consider using jdk.test.lib.util.FileUtils test library to remove the entire directory.

Thanks. Using FileUtils in next patch

mlchung · 2021-01-22T18:07:17Z

test/jdk/java/lang/Class/getEnclosingClass/EnclosingClassTest.java

+            Files.deleteIfExists(pkg1File);
+            Files.deleteIfExists(pkg1Dir);
+            Files.createDirectories(pkg2Dir);
+        } catch (IOException ex) {


The test should fail when running into any error. Using the test library will do the retry

Thanks, Corrected in next patch.

mlchung · 2021-01-22T18:16:54Z

test/jdk/java/lang/Class/getEnclosingClass/EnclosingClassTest.java

+        createAndWriteEnclosingClasses(enclosingPath, pkg1File, "pkg1");
+        createAndWriteEnclosingClasses(enclosingPath, pkg2File, "pkg1.pkg2");
+
+        String javacPath = JDKToolFinder.getJDKTool("javac");


You can use jdk.test.lib.compiler.CompilerUtils test library to compile the file in process.

I tried to use the CopmilerUtils to compile the file, But this utility is not able to the dependencies of the class. Example it is not able to find the common.TestMe class while try to compile the EnclosingClass.java.

You need to add --source-path where it can find the dependent source files.

mlchung · 2021-01-22T18:17:33Z

test/jdk/java/lang/Class/getEnclosingClass/EnclosingClassTest.java

+
+/*
+* @test
+* @bug 4992173 4992170


this needs @modules jdk.compiler

Thanks. Added in next patch

mlchung · 2021-01-22T18:19:19Z

test/jdk/java/lang/Class/getEnclosingClass/EnclosingClassTest.java

+        }
+    }
+
+    private void createAndWriteEnclosingClasses(final Path source, final Path target, final String packagePath) {


s/packagePath/packageName/

no need to declare parameters as final

Renamed the packagePath to packageName in next patch. To avoid the Checkstyle warning added the final key word with parameters.

mlchung · 2021-01-22T18:21:05Z

test/jdk/java/lang/Class/getEnclosingClass/EnclosingClassTest.java

+            String line;
+            while ((line = br.readLine()) != null) {
+                if (line.contains("canonical=\"EnclosingClass")) {
+                    line = line.replaceAll("canonical=\"EnclosingClass", "canonical=\"" + packagePath + ".EnclosingClass");


suggestion: declare var className = packageName + ".EnclosingClass"; and replace those occurrance.

Thanks. Implemented the comment in next patch.

mlchung · 2021-01-22T18:24:25Z

test/jdk/java/lang/Class/getEnclosingClass/EnclosingClassTest.java

+                }
+                bw.println(line);
+            }
+        } catch (IOException ex) {


Should not swallow the error and instead, let it propagate and the test should fail.

Thanks. Corrected this in next patch.

bchristi-git · 2021-01-22T20:25:03Z

Can the new code be added to the existing NonJavaNames.java instead of adding a new NonJavaNameTest.java file?

mlchung · 2021-01-26T22:13:45Z

test/jdk/java/lang/Class/forName/NonJavaNames.java

+ * @test
+ * @bug 4952558
+ * @library /test/lib
+ * @build NonJavaNames


This @build can be dropped as this is done implicitly.

mlchung · 2021-01-26T22:15:59Z

test/jdk/java/lang/Class/forName/NonJavaNames.java

+    private static final String SRC_DIR = System.getProperty("test.src");
+    private static final String TEST_SRC = SRC_DIR + "/classes/";
+    private static final String TEST_CLASSES = System.getProperty("test.classes", ".");
+    Path dhyphenPath, dcommaPath, dperiodPath, dleftsquarePath, drightsquarePath, dplusPath, dsemicolonPath, dzeroPath, dthreePath, dzadePath;


These variables should belong to the createInvalidNameClasses method. You can simply add Path type declaration in line 78-87.

mlchung · 2021-01-26T22:18:04Z

test/jdk/java/lang/Class/getEnclosingClass/EnclosingClassTest.java

+    public void createEnclosingClasses() throws Throwable {
+        Path enclosingPath = Paths.get(ENCLOSING_CLASS_SRC);
+        Path pkg1Dir = Paths.get(SRC_DIR + "/pkg1");
+        Path pkg2Dir = Paths.get(SRC_DIR+"/pkg1/pkg2");


nit: space before and after + is missing

mlchung · 2021-01-26T22:19:05Z

test/jdk/java/lang/Class/getEnclosingClass/EnclosingClassTest.java

+        createAndWriteEnclosingClasses(enclosingPath, pkg1File, "pkg1");
+        createAndWriteEnclosingClasses(enclosingPath, pkg2File, "pkg1.pkg2");
+
+        String javacPath = JDKToolFinder.getJDKTool("javac");


You need to add --source-path where it can find the dependent source files.

mlchung · 2021-01-26T22:25:19Z

test/jdk/java/lang/Class/getEnclosingClass/EnclosingClassTest.java

+    @BeforeClass
+    public void createEnclosingClasses() throws Throwable {
+        Path enclosingPath = Paths.get(ENCLOSING_CLASS_SRC);
+        Path pkg1Dir = Paths.get(SRC_DIR + "/pkg1");


Alternatively:

Path pkg1Dir = Paths.get(SRC_DIR, pkg1); Path pkg2Dir = Paths.get(SRC_DIR, pkg1, pkg2); Path pkg1File = pkg1Dir.resolve("EnclosingClass.java"); Path pkg2File = pkg2Dir.resolve("EnclosingClass.java");

mlchung · 2021-01-26T22:28:53Z

test/jdk/java/lang/Class/getEnclosingClass/EnclosingClassTest.java

+
+        String javacPath = JDKToolFinder.getJDKTool("javac");
+        OutputAnalyzer outputAnalyzer = ProcessTools.executeCommand(javacPath, "-d", System.getProperty("test.classes", "."),
+                SRC_DIR + "/EnclosingClass.java", SRC_DIR + "/pkg1/EnclosingClass.java", SRC_DIR + "/pkg1/pkg2/EnclosingClass.java");


File.separator is different on Unix and Windows. Either replace / with File.separator. Or you can use java.nio.file.Path and call Path::toString to get the string representation.

See above suggestion of declaring static final Path ENCLOSING_CLASS_SRC. So the above should use ENCLOSING_CLASS_SRC and pkg2File instead (calling toString)

mlchung · 2021-01-26T22:30:03Z

test/jdk/java/lang/Class/getEnclosingClass/EnclosingClassTest.java

-                      String encName, String encNameExpected,
-                      String simpleName, String simpleNameExpected,
-                      String canonicalName, String canonicalNameExpected) {
+    private void check(final Class<?> c, final Class<?> enc,


Is it from your IDE configurations? You can turn off Checkstyle warnings. This just adds noise.

mlchung · 2021-01-26T22:31:48Z

test/jdk/java/lang/Class/getEnclosingClass/EnclosingClassTest.java

+    }
+
+    @Test
+    public void testEnclosingClasses() throws Throwable {


better to throw specific exceptions for example ReflectiveOperationException. Same for the @Test below.

mlchung · 2021-01-26T22:35:42Z

test/jdk/java/lang/Class/getEnclosingClass/EnclosingClassTest.java

-                      String encName, String encNameExpected,
-                      String simpleName, String simpleNameExpected,
-                      String canonicalName, String canonicalNameExpected) {
+    private void check(final Class<?> c, final Class<?> enc,


I also assume some of the formatting changes are changed by your IDE suggestion. Can you please revert the formatting changes (there are quite a few of them). This will help the reviewers.

mlchung · 2021-01-26T22:44:10Z

test/jdk/java/lang/Class/getEnclosingClass/EnclosingClassTest.java

+
+    @AfterClass
+    public void deleteEnclosingClasses() throws IOException {
+        Path pkg1Dir = Paths.get(SRC_DIR + "/pkg1");


Suggested change

Path pkg1Dir = Paths.get(SRC_DIR + "/pkg1");

Path pkg1Dir = Paths.get(SRC_DIR, "pkg1");

bchristi-git

I like keeping the changes within the existing .java files, thanks. I have a few more suggestions.

bchristi-git · 2021-01-26T22:52:15Z

test/jdk/java/lang/Class/getEnclosingClass/EnclosingClassTest.java

+* @library /test/lib
+* @modules jdk.compiler
+* @build jdk.test.lib.process.* EnclosingClassTest
+* @run testng/othervm EnclosingClassTest


The test should still be run with -esa -ea

Yes, while running from command line providing the -esa and -a option to run the tests.

bchristi-git · 2021-01-26T22:54:15Z

test/jdk/java/lang/Class/getEnclosingClass/EnclosingClassTest.java

+
+    @BeforeClass
+    public void createEnclosingClasses() throws Throwable {
+        Path enclosingPath = Paths.get(ENCLOSING_CLASS_SRC);


The 'enclosingPath' Path could be the constant. Then ENCLOSING_CLASS_SRC is not needed.

bchristi-git · 2021-01-26T22:55:32Z

test/jdk/java/lang/Class/getEnclosingClass/EnclosingClassTest.java

+    @AfterClass
+    public void deleteEnclosingClasses() throws IOException {
+        Path pkg1Dir = Paths.get(SRC_DIR + "/pkg1");
+        FileUtils.deleteFileTreeWithRetry(pkg1Dir);
+    }


I'm not convinced the @AfterClass method is necessary. Pre-cleanup is already done on LL94-95. And occasionally, test-generated artifacts are helpful in post-mortem analysis.

To keep the source code repo clean from temporary generated files, these files are removed after test. Test logs have the information about the generated files for the Postmortem analysis.

Test files shouldn't be written into the repository (repos are sometimes tested on read-only filesystems). Files should be written under JTwork/scratch/.

bchristi-git · 2021-01-26T22:56:25Z

test/jdk/java/lang/Class/getEnclosingClass/EnclosingClassTest.java

-                           expected + "'");
+    private void match(final String actual, final String expected) {
+        System.out.println("actual:" + actual + "expected:" + expected);
+        assert ((actual == null && expected == null) || actual.trim().equals(expected.trim()));


Out of curiousity, why is the trim() now needed ?

expected string having one space as prefixed in some class names incase of pkg1 and pkg2 packages. So trimmig before comparing with actual name:

Current package no space

nested class within top level class:
class EnclosingClass$Nested
is enclosed by: class EnclosingClass
has simple name: Nested' has canonical name: EnclosingClass.Nested'
actual:class EnclosingClassexpected:class EnclosingClass

pkg1.pkg2 package have expected class name with one space prefixed

nested class within top level class:
class pkg1.pkg2.EnclosingClass$Nested
is enclosed by: class pkg1.pkg2.EnclosingClass
has simple name: Nested' has canonical name: pkg1.pkg2.EnclosingClass.Nested'
actual:class pkg1.pkg2.EnclosingClassexpected: class pkg1.pkg2.EnclosingClass

pkg1 package have expected class name with one space prefixed

nested class within top level class:
class pkg1.EnclosingClass$Nested
is enclosed by: class pkg1.EnclosingClass
has simple name: Nested' has canonical name: pkg1.EnclosingClass.Nested'
actual:class pkg1.EnclosingClassexpected: class pkg1.EnclosingClass

bchristi-git · 2021-01-26T22:57:03Z

test/jdk/java/lang/Class/getEnclosingClass/EnclosingClassTest.java

+        check(c, encClass, "" + encClass, annotation.encl(), c.getSimpleName(), annotation.simple(),
+                c.getCanonicalName(), annotation.hasCanonical() ? annotation.canonical() : null);


This looks like an unneeded formatting change

bchristi-git · 2021-01-26T22:57:21Z

test/jdk/java/lang/Class/getEnclosingClass/EnclosingClassTest.java

+        check(array, array.getEnclosingClass(), "", "", array.getSimpleName(),
+                annotation.simple() + "[]", array.getCanonicalName(), annotation.hasCanonical()
+                        ? annotation.canonical() + "[]" : null);


This looks like an unneeded formatting change

bchristi-git · 2021-01-26T22:57:40Z

test/jdk/java/lang/Class/getEnclosingClass/EnclosingClassTest.java

-                    System.err.println("Error in " +
-                                       tests.getClass().getName() +
-                                       "." + f.getName());
+                    System.err.println("Error in " + tests.getClass().getName() + "." + f.getName());


This looks like an unneeded formatting change

efge · 2021-01-26T23:25:03Z

test/jdk/java/lang/Class/forName/NonJavaNames.java

+
+    @BeforeClass
+    public void createInvalidNameClasses() throws IOException {
+        Path hyphenPath = Paths.get(TEST_SRC + "hyphen.class");


Building a Path with string concatenation is an anti-pattern.
Also Path.of is probably preferred instead of Paths.get.

Now not doing the concatenation of the strings to create Path.

mlchung

Thanks for the update. This is much cleaner.

mlchung · 2021-02-01T20:39:44Z

test/jdk/java/lang/Class/forName/NonJavaNames.java

-        }
+    @DataProvider(name = "badNonJavaClassNames")
+    Object[][] getBadNonJavaClassNames() {
+        return new Object[][] {{";"}, {"["}, {"."}};


Nit: one line per test (i.e. make it multiple lines)

mlchung · 2021-02-01T20:40:39Z

test/jdk/java/lang/Class/getEnclosingClass/EnclosingClassTest.java

+import org.testng.annotations.AfterClass;
+import org.testng.annotations.BeforeClass;
+import org.testng.annotations.Test;
+
 /*
 * @test


Nit: suggest to move this comment block to the top before all imports.

openjdk · 2021-02-01T21:42:28Z

@mahendrachhipa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8183372: Refactor java/lang/Class shell tests to java

Reviewed-by: bchristi, mchung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 692 new commits pushed to the master branch:

105d3e8: 8260861: TrustStoreDescriptor log the same value
69189f8: 8256421: Add 2 HARICA roots to cacerts truststore
f546fd0: 8260902: CDS mapping errors should not lead to unconditional output
d7b1fc5: 8260707: java/lang/instrument/PremainClass/InheritAgent0100.java times out
0093183: 8260368: [PPC64] GC interface needs enhancement to support GCs with load barriers
defcb04: 8260867: ProblemList java/awt/FullScreen/TranslucentWindow/TranslucentWindow.java on linux
a421bfa: 8259839: SystemDictionary exports too much implementation
189b65b: 8260264: Move common os_ inline methods to a common posix source file
288a4fe: 8260643: Remove parallel version handling in CardTableRS::younger_refs_in_space_iterate()
ddd2951: 8260571: Add PrintMetaspaceStatistics to print metaspace statistics upon VM exit
... and 682 more: https://git.openjdk.java.net/jdk/compare/0201a33dd681dc731637fa3f9bf1d197610a9da4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@bchristi-git, @mlchung) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

mlchung · 2021-02-01T21:53:57Z

test/jdk/java/lang/Class/forName/NonJavaNames.java

-            "]"
-        };
+    @Test(dataProvider = "goodNonJavaClassNames")
+    public void testGoodNonJavaClassNames(String name) throws Throwable {


s/Throwable/ClassFileNotFoundException/

mlchung · 2021-02-01T21:54:37Z

test/jdk/java/lang/Class/forName/NonJavaNames.java

+        System.out.println("Testing bad class name ``" + name + "''");
+        try {
+            Class.forName(name);
+        } catch (Exception e) {


s/Exception/ClassNotFoundException/

mahendrachhipa · 2021-02-01T23:01:50Z

/integrate

openjdk · 2021-02-01T23:02:40Z

@mahendrachhipa
Your change (at version 320b305) is now ready to be sponsored by a Committer.

mlchung · 2021-02-01T23:29:13Z

I think Brent wants to review it. I will let Brent to sponsor you.

bchristi-git · 2021-01-27T23:43:04Z

test/jdk/java/lang/Class/getEnclosingClass/EnclosingClassTest.java

-                           actual + "' matches expected `" +
-                           expected + "'");
+    private void match(final String actual, final String expected) {
+        System.out.println("actual:" + actual + "expected:" + expected);


It would be good to insert a space before expected:

bchristi-git · 2021-01-28T00:34:08Z

test/jdk/java/lang/Class/getEnclosingClass/EnclosingClassTest.java

-                           expected + "'");
+    private void match(final String actual, final String expected) {
+        System.out.println("actual:" + actual + "expected:" + expected);
+        assert ((actual == null && expected == null) || actual.equals(expected.trim()));


I think we need to figure out where the extra space is coming from, if the test worked before, but now fails without adding the trim().

Also, I think it would be better to throw an exception instead of using assert, so the test works with or without assertions being enabled.

Good catch. I missed your comment about this change.

bchristi-git · 2021-02-01T23:42:24Z

test/jdk/java/lang/Class/getEnclosingClass/EnclosingClassTest.java

-        assert((actual == null && expected == null) || actual.equals(expected));
+    private void match(String actual, String expected) {
+        System.out.println("actual:" + actual + "expected:" + expected);
+        assert((actual == null && expected == null) || actual.equals(expected.trim()));


I don't think this check is done, because assertions aren't enabled. This should be changed to explicitly throw an exception.

bchristi-git · 2021-02-01T23:46:27Z

(I think my comments may no have been visible because I didn't "submit" my review. Hopefully they are now.)

mahendrachhipa · 2021-02-02T16:19:50Z

/integrate

openjdk · 2021-02-02T16:20:15Z

@mahendrachhipa
Your change (at version 224a104) is now ready to be sponsored by a Committer.

bchristi-git

Looks good. Thanks for the changes.

bchristi-git · 2021-02-02T21:08:12Z

/sponsor

openjdk · 2021-02-02T21:08:30Z

@bchristi-git The PR has been updated since the change author (@mahendrachhipa) issued the integrate command - the author must perform this command again.

mahendrachhipa · 2021-02-02T21:10:12Z

/integrate

openjdk · 2021-02-02T21:10:49Z

@mahendrachhipa
Your change (at version 3c235ab) is now ready to be sponsored by a Committer.

bchristi-git · 2021-02-02T21:11:08Z

/sponsor

openjdk · 2021-02-02T21:11:55Z

@bchristi-git @mahendrachhipa Since your change was applied there have been 692 commits pushed to the master branch:

105d3e8: 8260861: TrustStoreDescriptor log the same value
69189f8: 8256421: Add 2 HARICA roots to cacerts truststore
f546fd0: 8260902: CDS mapping errors should not lead to unconditional output
d7b1fc5: 8260707: java/lang/instrument/PremainClass/InheritAgent0100.java times out
0093183: 8260368: [PPC64] GC interface needs enhancement to support GCs with load barriers
defcb04: 8260867: ProblemList java/awt/FullScreen/TranslucentWindow/TranslucentWindow.java on linux
a421bfa: 8259839: SystemDictionary exports too much implementation
189b65b: 8260264: Move common os_ inline methods to a common posix source file
288a4fe: 8260643: Remove parallel version handling in CardTableRS::younger_refs_in_space_iterate()
ddd2951: 8260571: Add PrintMetaspaceStatistics to print metaspace statistics upon VM exit
... and 682 more: https://git.openjdk.java.net/jdk/compare/0201a33dd681dc731637fa3f9bf1d197610a9da4...master

Your commit was automatically rebased without conflicts.

Pushed as commit 6dc3c6d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

JDK-8183372 : Refactor java/lang/Class shell tests to java

a02e66a

https://bugs.openjdk.java.net/browse/JDK-8183372

openjdk bot added the rfr Pull request is ready for review label Jan 20, 2021

openjdk bot added the core-libs core-libs-dev@openjdk.org label Jan 20, 2021

NonJavaName Tests updated

e664bd7

Used newInstance() method to create the different EnclosingClasses at runtime

mlchung reviewed Jan 22, 2021

View reviewed changes

Implemented the review comments.

9517404

mlchung reviewed Jan 26, 2021

View reviewed changes

bchristi-git suggested changes Jan 26, 2021

View reviewed changes

efge reviewed Jan 26, 2021

View reviewed changes

mahendrachhipa added 5 commits January 27, 2021 22:39

Implemented the review comments.

cd57d8f

Implemented review comment.

d8ce7ca

Reset the formatting.

40ba2b3

Implemented the review comments.

0cbee71

Implemented the review comments.

9a28025

openjdk bot removed the rfr Pull request is ready for review label Feb 1, 2021

mlchung approved these changes Feb 1, 2021

View reviewed changes

Implemented the review comments.

9ff23ef

openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 1, 2021

mlchung approved these changes Feb 1, 2021

View reviewed changes

throwing the specific exceptions.

320b305

openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 1, 2021

bchristi-git suggested changes Feb 1, 2021

View reviewed changes

Using testNg Assert instead of assert.

224a104

openjdk bot removed the sponsor Pull request is ready to be sponsored label Feb 2, 2021

openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 2, 2021

Generate the source files in JTWork directory.

3c235ab

openjdk bot removed the sponsor Pull request is ready to be sponsored label Feb 2, 2021

bchristi-git approved these changes Feb 2, 2021

View reviewed changes

openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 2, 2021

openjdk bot closed this Feb 2, 2021

openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 2, 2021

	Path pkg1Dir = Paths.get(SRC_DIR + "/pkg1");
	Path pkg1Dir = Paths.get(SRC_DIR, "pkg1");

		check(c, encClass, "" + encClass, annotation.encl(), c.getSimpleName(), annotation.simple(),
		c.getCanonicalName(), annotation.hasCanonical() ? annotation.canonical() : null);

JDK-8183372 : Refactor java/lang/Class shell tests to java #2170

JDK-8183372 : Refactor java/lang/Class shell tests to java #2170

Uh oh!

Conversation

mahendrachhipa commented Jan 20, 2021 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Download

Uh oh!

bridgekeeper bot commented Jan 20, 2021

Uh oh!

openjdk bot commented Jan 20, 2021

Uh oh!

mlbridge bot commented Jan 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

bchristi-git commented Jan 21, 2021

Uh oh!

mahendrachhipa commented Jan 22, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mahendrachhipa Jan 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bchristi-git commented Jan 22, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

mahendrachhipa commented Jan 20, 2021 •

edited by openjdk bot

Loading

mlbridge bot commented Jan 20, 2021 •

edited

Loading

mahendrachhipa Jan 25, 2021 •

edited

Loading

mahendrachhipa Jan 27, 2021 •

edited

Loading