Skip to content

8343086: [BACKOUT] JDK-8295269 G1: Improve slow startup due to predictor initialization #21718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

tschatzl
Copy link
Contributor

@tschatzl tschatzl commented Oct 25, 2024

Hi all,

please review this revert of JDK-8295269 because it makes the runtime/cds/DeterministicCDSDump.java test fail due to differences in startup behavior.

This is a clean revert.

Testing: gha

Thanks,
Thomas


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8343086: [BACKOUT] JDK-8295269 G1: Improve slow startup due to predictor initialization (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21718/head:pull/21718
$ git checkout pull/21718

Update a local copy of the PR:
$ git checkout pull/21718
$ git pull https://git.openjdk.org/jdk.git pull/21718/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21718

View PR using the GUI difftool:
$ git pr show -t 21718

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21718.diff

Webrev

Link to Webrev Comment

Hi all,

  please review this revert of JDK-8295269 because it makes the runtime/cds/DeterministicCDSDump.java test fail due to differences in startup behavior.

This is a clean revert.

Testing: gha

Thanks,
  Thomas
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 25, 2024

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 25, 2024

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8343086: [BACKOUT] JDK-8295269 G1: Improve slow startup due to predictor initialization

Reviewed-by: sangheki

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 36d7173: 8339289: Enhance Attach API to support arbitrary length arguments - Windows

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8343086 8343086: [BACKOUT] JDK-8295269 G1: Improve slow startup due to predictor initialization Oct 25, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 25, 2024
@openjdk
Copy link

openjdk bot commented Oct 25, 2024

@tschatzl The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Oct 25, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 25, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 25, 2024
@tschatzl
Copy link
Contributor Author

Since this adds lots of noise to the CI, I will go ahead and integrate now.

Thanks @sangheon for your review.

/integrate

@openjdk
Copy link

openjdk bot commented Oct 25, 2024

Going to push as commit f1cc890.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 36d7173: 8339289: Enhance Attach API to support arbitrary length arguments - Windows

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 25, 2024
@openjdk openjdk bot closed this Oct 25, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 25, 2024
@openjdk
Copy link

openjdk bot commented Oct 25, 2024

@tschatzl Pushed as commit f1cc890.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@tschatzl tschatzl deleted the submit/8343086-backout-fast-startup branch November 18, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants