Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8260191: Do not include access.hpp in oop.hpp #2172

Closed

Conversation

iklam
Copy link
Member

@iklam iklam commented Jan 20, 2021

Please review this trivial change.

oop.h is included by 860 out of 1000 HotSpot .o files. It includes access.h for this member function declaration only:

template <DecoratorSet decorator> oop obj_field_access(int offset) const;

Instead of access.h, oop.h should include accessDecorators.hpp. This avoids including lots of header files from the Access API.

HotSpot build time is reduced by about 0.5% for this single-line change.

Tested with mach5: tier1, builds-tier2, builds-tier3, builds-tier4 and builds-tier5. Also locally: aarch64, arm, ppc64, s390, x86, and zero.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2172/head:pull/2172
$ git checkout pull/2172

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 20, 2021

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 20, 2021

@iklam The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Jan 20, 2021
@iklam iklam marked this pull request as ready for review January 20, 2021 22:54
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 20, 2021
@mlbridge
Copy link

mlbridge bot commented Jan 20, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 21, 2021

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260191: Do not include access.hpp in oop.hpp

Reviewed-by: kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

  • 35c9da7: 8259498: Reduce overhead of MD5 and SHA digests
  • 27cc62a: 8259911: byteArrayViewVarHandle should throw ArrayIndexOutOfBoundsException
  • 1f47de5: 8260010: UTF8ZipCoder not thread-safe since JDK-8243469
  • 8b95d95: 8256895: Add support for RFC 8954: Online Certificate Status Protocol (OCSP) Nonce Extension
  • 4f11ff3: 8259488: Shenandoah: Missing timing tracking for STW CLD root processing
  • 0785147: 8259949: x86 32-bit build fails when -fcf-protection is passed in the compiler flags
  • 5891509: 8259947: (fs) Optimize UnixPath.encode implementation
  • 69f90b5: 8259843: initialize dli_fname array before calling dll_address_to_library_name
  • 52ed2aa: 8259786: initialize last parameter of getpwuid_r
  • 70b5b31: 8257664: HTMLEditorKit: Wrong CSS relative font sizes
  • ... and 4 more: https://git.openjdk.java.net/jdk/compare/cf25383d19e5b42768cdd07385a89dcbafbe02bb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 21, 2021
Copy link

@kimbarrett kimbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to say earlier, I agree this is trivial.

@iklam
Copy link
Member Author

iklam commented Jan 21, 2021

Thanks @kimbarrett for the review!
/integrate

@openjdk openjdk bot closed this Jan 21, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 21, 2021
@openjdk
Copy link

openjdk bot commented Jan 21, 2021

@iklam Since your change was applied there have been 15 commits pushed to the master branch:

  • 77a4302: 8223056: Remove Type-Stable-Memory support for Parkers
  • 35c9da7: 8259498: Reduce overhead of MD5 and SHA digests
  • 27cc62a: 8259911: byteArrayViewVarHandle should throw ArrayIndexOutOfBoundsException
  • 1f47de5: 8260010: UTF8ZipCoder not thread-safe since JDK-8243469
  • 8b95d95: 8256895: Add support for RFC 8954: Online Certificate Status Protocol (OCSP) Nonce Extension
  • 4f11ff3: 8259488: Shenandoah: Missing timing tracking for STW CLD root processing
  • 0785147: 8259949: x86 32-bit build fails when -fcf-protection is passed in the compiler flags
  • 5891509: 8259947: (fs) Optimize UnixPath.encode implementation
  • 69f90b5: 8259843: initialize dli_fname array before calling dll_address_to_library_name
  • 52ed2aa: 8259786: initialize last parameter of getpwuid_r
  • ... and 5 more: https://git.openjdk.java.net/jdk/compare/cf25383d19e5b42768cdd07385a89dcbafbe02bb...master

Your commit was automatically rebased without conflicts.

Pushed as commit 044bae0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
2 participants