Skip to content

Conversation

@alexeysemenyukoracle
Copy link
Member

@alexeysemenyukoracle alexeysemenyukoracle commented Oct 25, 2024

Remove --compress from jlink command lines in jpackage tests


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8343102: Remove --compress from jlink command lines from jpackage tests (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21723/head:pull/21723
$ git checkout pull/21723

Update a local copy of the PR:
$ git checkout pull/21723
$ git pull https://git.openjdk.org/jdk.git pull/21723/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21723

View PR using the GUI difftool:
$ git pr show -t 21723

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21723.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 25, 2024

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 25, 2024

@alexeysemenyukoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8343102: Remove `--compress` from jlink command lines from jpackage tests

Reviewed-by: almatvee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

  • f1a9a8d: 8342902: Deduplication of acquire calls in BindingSpecializer causes escape-analyisis failure
  • f1cc890: 8343086: [BACKOUT] JDK-8295269 G1: Improve slow startup due to predictor initialization
  • 36d7173: 8339289: Enhance Attach API to support arbitrary length arguments - Windows
  • ff165f9: 8342934: TYPE_USE annotations printed with error causing "," in toString output
  • 0853aee: 8338426: Test java/nio/channels/Selector/WakeupNow.java failed
  • c202a2f: 8295269: G1: Improve slow startup due to predictor initialization
  • 5cbd578: 8342930: New tests from JDK-8335912 are failing
  • 1e35da8: 8343063: RISC-V: remove redundant reg copy in generate_resolve_blob
  • 4f8f395: 8343060: RISC-V: enable TestFloat16VectorConvChain for riscv
  • a9eb50a: 8342953: RISC-V: Fix definition of RISCV_HWPROBE_EXT_ZVFHMIN
  • ... and 6 more: https://git.openjdk.org/jdk/compare/ca1700b8bf3b7b34616c469837748ac4c3607dfc...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 25, 2024
@openjdk
Copy link

openjdk bot commented Oct 25, 2024

@alexeysemenyukoracle The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Oct 25, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 25, 2024

Webrevs

Copy link
Member

@sashamatveev sashamatveev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 25, 2024
@alexeysemenyukoracle
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 26, 2024

Going to push as commit 9e451aa.
Since your change was applied there have been 18 commits pushed to the master branch:

  • 873f8a6: 8305406: Add @SPEC tags in java.base/java.* (part 2)
  • 1476f6c: 8343030: RISC-V: Small assembler cleanups
  • f1a9a8d: 8342902: Deduplication of acquire calls in BindingSpecializer causes escape-analyisis failure
  • f1cc890: 8343086: [BACKOUT] JDK-8295269 G1: Improve slow startup due to predictor initialization
  • 36d7173: 8339289: Enhance Attach API to support arbitrary length arguments - Windows
  • ff165f9: 8342934: TYPE_USE annotations printed with error causing "," in toString output
  • 0853aee: 8338426: Test java/nio/channels/Selector/WakeupNow.java failed
  • c202a2f: 8295269: G1: Improve slow startup due to predictor initialization
  • 5cbd578: 8342930: New tests from JDK-8335912 are failing
  • 1e35da8: 8343063: RISC-V: remove redundant reg copy in generate_resolve_blob
  • ... and 8 more: https://git.openjdk.org/jdk/compare/ca1700b8bf3b7b34616c469837748ac4c3607dfc...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 26, 2024
@openjdk openjdk bot closed this Oct 26, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 26, 2024
@openjdk
Copy link

openjdk bot commented Oct 26, 2024

@alexeysemenyukoracle Pushed as commit 9e451aa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@alexeysemenyukoracle alexeysemenyukoracle deleted the JDK-8343102 branch November 9, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants