8343122: RISC-V: C2: Small improvement for real runtime callouts

[RealFYang]

Hi, please review this small improvement.

Currently, we do 11 instructions for real C2 runtime callouts (See riscv_enc_java_to_runtime).
Seems we can materialize the pointer faster with movptr2, which will help reduce 2 instructions.
But we will need to reorder the original calling sequence a bit to make t0 available for movptr2.

Testing on linux-riscv64 platform:

• tier1-tier3 (release)
• hotspot:tier1 (fastdebug)

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8343122: RISC-V: C2: Small improvement for real runtime callouts (Enhancement - P4)

Reviewers

• Robbin Ehn (@robehn - Reviewer)
• Feilong Jiang (@feilongjiang - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21733/head:pull/21733
$ git checkout pull/21733

Update a local copy of the PR:
$ git checkout pull/21733
$ git pull https://git.openjdk.org/jdk.git pull/21733/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21733

View PR using the GUI difftool:
$ git pr show -t 21733

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21733.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back fyang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@RealFYang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8343122: RISC-V: C2: Small improvement for real runtime callouts

Reviewed-by: rehn, fjiang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 54 new commits pushed to the master branch:

• e5bbad0: 8334999: RISC-V: implement AES single block encryption/decryption intrinsics
• c40bb76: 8343296: IGV: Show pre/main/post at CountedLoopNodes
• dee0982: 8343132: Remove temporary transitions from Virtual thread implementation
• 2f1ba5e: 8343307: Throw ZipException instead of IAE in ZipFile.Source::initCEN
• 388d44f: 8342156: C2: Compilation failure with fewer arguments after JDK-8329032
• 688e92e: 8342642: Class loading failure due to archived map issue in ModuleLoaderMap.Mapper
• f340ab2: 8342181: Update tests to use stronger Key and Salt size
• cc2fb4d: 8337276: jcmd man page update for PID in output filenames
• 02ea4b5: 8342635: javax/swing/JFileChooser/FileSystemView/WindowsDefaultIconSizeTest.java creates tmp file in src dir
• 7461dfe: 8341788: Fix ExceptionOccurred in hotspot
• ... and 44 more: https://git.openjdk.org/jdk/compare/0e3fc93dfb14378a848571a6b83282c0c73e690f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@RealFYang The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (47643cd5)

[robehn]

Nice!

But I don't see the code change for this comment change:

-  //   sd(t1, Address(sp, wordSize))  ->  sd
+  //   sd(t0, Address(sp, wordSize))  ->  sd

What am I missing ?

EDIT: Sorry ignore above, early morning...

[feilongjiang]

LGTM

[RealFYang]

Thanks all for the review!
/integrate

[openjdk]

Going to push as commit cbda758.
Since your change was applied there have been 68 commits pushed to the master branch:

• 803612e: 8343121: RISC-V: More accurate max size for C2SafepointPollStub and C2EntryBarrierStub
• b627a41: 8343345: Use -jvmArgsPrepend when running microbenchmarks in RunTests.gmk
• 2932144: 8343305: Remove Indify-dependent microbenchmarks
• 34655c6: 8342544: [macos] jpackage test helper should check for both "--app-image" and "--mac-sign" for signing predefined app image case
• 5a5d9c5: 8343085: [macos] jpackage verbose output on macOS contains numerous "Running /usr/bin/codesign" entries
• d4eb2d9: 8319343: Improve CDS module graph support for --add-modules option
• 568b07a: 8325089: jpackage utility creates an "infinite", undeleteable directory tree
• 7c36fa7: 8343019: Primitive caches must use boxed instances from the archive
• ae82cc1: 8342188: Update tests to use stronger key parameters and certificates
• 7ad3ef7: 8343057: JFR: Sorting in 'jfr view' can violate contract
• ... and 58 more: https://git.openjdk.org/jdk/compare/0e3fc93dfb14378a848571a6b83282c0c73e690f...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RealFYang Pushed as commit cbda758.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.