Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6606673: Path2D.Double, Path2D.Float and GeneralPath ctors throw exception when initialCapacity is negative #2174

Closed
wants to merge 1 commit into from

Conversation

@mrserb
Copy link
Member

@mrserb mrserb commented Jan 21, 2021

The specification for Path2D.Double, Path2D.Float and GeneralPath constructors is updated. NegativeArraySizeException, IllegalArgumentException and NullPointerException are added.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-6606673: Path2D.Double, Path2D.Float and GeneralPath ctors throw exception when initialCapacity is negative

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2174/head:pull/2174
$ git checkout pull/2174

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 21, 2021

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jan 21, 2021

@mrserb The following labels will be automatically applied to this pull request:

  • 2d
  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

Loading

@mrserb
Copy link
Member Author

@mrserb mrserb commented Jan 21, 2021

/label remove awt

Loading

@openjdk openjdk bot removed the awt label Jan 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 21, 2021

@mrserb
The awt label was successfully removed.

Loading

@mrserb
Copy link
Member Author

@mrserb mrserb commented Jan 21, 2021

/csr

Loading

@openjdk openjdk bot added the csr label Jan 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 21, 2021

@mrserb this pull request will not be integrated until the CSR request JDK-8260192 for issue JDK-6606673 has been approved.

Loading

@mrserb mrserb marked this pull request as ready for review Jan 21, 2021
@openjdk openjdk bot added the rfr label Jan 21, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 21, 2021

Webrevs

Loading

@mrserb
Copy link
Member Author

@mrserb mrserb commented Jan 26, 2021

Can somebody take a look at the CSR? https://bugs.openjdk.java.net/browse/JDK-8260192

Loading

@openjdk openjdk bot removed the csr label Jan 27, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 27, 2021

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

6606673: Path2D.Double, Path2D.Float and GeneralPath ctors throw exception when initialCapacity is negative

Reviewed-by: psadhukhan, kizune

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 99 new commits pushed to the master branch:

  • 19b6f61: 8260334: Remove deprecated sv_for_node_id() from Compile
  • 1bebd41: 8260421: Shenandoah: Fix conc_mark_roots timing name and indentations
  • 42cef27: 8260343: Delete obsolete classes in the Windows L&F
  • 9f0a043: 8260286: Manual Test "ws/open/test/jdk/sun/security/tools/jarsigner/compatibility/Compatibility.java" fails
  • fd00ed7: 8256298: Shenandoah: Enable concurrent stack processing
  • b07797c: 8260391: Remove StringCoding::err
  • af8a08f: 8260378: [TESTBUG] DcmdMBeanTestCheckJni.java reports false positive
  • 8d2f77f: 8260406: Do not copy pure java source code to gensrc
  • 5e8e0ad: 8242456: PreviewFeature.Feature enum removal of TEXT_BLOCKS
  • e080ce9: 8252545: runtime/ErrorHandling/TestHeapDumpOnOutOfMemoryError.java timed out
  • ... and 89 more: https://git.openjdk.java.net/jdk/compare/9f21bb6ac1b8ad08cbae0eee5209a1982a5ed00a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Jan 27, 2021
@mrserb
Copy link
Member Author

@mrserb mrserb commented Jan 27, 2021

/integrate

Loading

@openjdk openjdk bot closed this Jan 27, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 27, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 27, 2021

@mrserb Since your change was applied there have been 100 commits pushed to the master branch:

  • 6f2be9c: 8246112: Remove build-time and run-time checks for clock_gettime and CLOCK_MONOTONIC
  • 19b6f61: 8260334: Remove deprecated sv_for_node_id() from Compile
  • 1bebd41: 8260421: Shenandoah: Fix conc_mark_roots timing name and indentations
  • 42cef27: 8260343: Delete obsolete classes in the Windows L&F
  • 9f0a043: 8260286: Manual Test "ws/open/test/jdk/sun/security/tools/jarsigner/compatibility/Compatibility.java" fails
  • fd00ed7: 8256298: Shenandoah: Enable concurrent stack processing
  • b07797c: 8260391: Remove StringCoding::err
  • af8a08f: 8260378: [TESTBUG] DcmdMBeanTestCheckJni.java reports false positive
  • 8d2f77f: 8260406: Do not copy pure java source code to gensrc
  • 5e8e0ad: 8242456: PreviewFeature.Feature enum removal of TEXT_BLOCKS
  • ... and 90 more: https://git.openjdk.java.net/jdk/compare/9f21bb6ac1b8ad08cbae0eee5209a1982a5ed00a...master

Your commit was automatically rebased without conflicts.

Pushed as commit e1411fd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@mrserb mrserb deleted the JDK-6606673 branch Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants