8342576: [macos] AppContentTest still fails after JDK-8341443 for same reason on older macOS versions

[alexeysemenyukoracle]

Change suffixes produced by TKit.createUniqueFileName() function from .<NUM> to -<NUM> (e.g.: from .0 to -0).
Apple's codesign tool can't sign directories with periods in their names as it interprets them as bundles. Directories produced by TKit.createUniqueFileName() may end up in an app image and become a subject for signing if used with --app-content jpackage parameter

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8342576: [macos] AppContentTest still fails after JDK-8341443 for same reason on older macOS versions (Bug - P3)

Reviewers

• Alexander Matveev (@sashamatveev - Reviewer)

Contributors

• Alexander Matveev <almatvee@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21741/head:pull/21741
$ git checkout pull/21741

Update a local copy of the PR:
$ git checkout pull/21741
$ git pull https://git.openjdk.org/jdk.git pull/21741/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21741

View PR using the GUI difftool:
$ git pr show -t 21741

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21741.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@alexeysemenyukoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8342576: [macos] AppContentTest still fails after JDK-8341443 for same reason on older macOS versions

Co-authored-by: Alexander Matveev <almatvee@openjdk.org>
Reviewed-by: almatvee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 53 new commits pushed to the master branch:

• 60364ef: 8341273: JVMTI is not properly hiding some continuation related methods
• 520ddac: 8331861: [PPC64] Implement load / store assembler functions which take an Address object
• 9cfb0f7: 8341527: AVX-512 intrinsic for SHA3
• 4ce19ca: 8343190: GHA: Try building JTReg several times
• 7c800e6: 8343026: JFR: Index into fields in the topFrame
• d8b3685: 8342607: Enhance register printing on x86_64 platforms
• d8430ef: 8339573: Update CodeCacheSegmentSize and CodeEntryAlignment for ARM
• 6332e25: 8343183: [s390x]: Problemlist runtime/Monitor/SyncOnValueBasedClassTest.java Failure
• 79a07ad: 8343149: Cleanup os::print_tos_pc on AIX
• beff8bf: 8342823: Ubsan: ciEnv.cpp:1614:65: runtime error: member call on null pointer of type 'struct CompileTask'
• ... and 43 more: https://git.openjdk.org/jdk/compare/ca1700b8bf3b7b34616c469837748ac4c3607dfc...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@alexeysemenyukoracle The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (9351654f)
• 00: Full (a7bda48b)

[openjdk]

@alexeysemenyukoracle Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

• /contributor add @openjdk-bot
• /contributor add duke
• /contributor add J. Duke <duke@openjdk.org>

User names can only be used for users in the census associated with this repository. For other contributors you need to supply the full name and email address.

[alexeysemenyukoracle]

/contributor add @sashamatveev

[openjdk]

@alexeysemenyukoracle
Contributor Alexander Matveev <almatvee@openjdk.org> successfully added.

[sashamatveev]

Looks good.

[alexeysemenyukoracle]

/integrate

[openjdk]

Going to push as commit ceaa71e.
Since your change was applied there have been 54 commits pushed to the master branch:

• 40f3d50: 8343211: Compile error: redefinition of 'Assembler::evmovdquw(XMMRegister,KRegister,XMMRegister,bool,int)'
• 60364ef: 8341273: JVMTI is not properly hiding some continuation related methods
• 520ddac: 8331861: [PPC64] Implement load / store assembler functions which take an Address object
• 9cfb0f7: 8341527: AVX-512 intrinsic for SHA3
• 4ce19ca: 8343190: GHA: Try building JTReg several times
• 7c800e6: 8343026: JFR: Index into fields in the topFrame
• d8b3685: 8342607: Enhance register printing on x86_64 platforms
• d8430ef: 8339573: Update CodeCacheSegmentSize and CodeEntryAlignment for ARM
• 6332e25: 8343183: [s390x]: Problemlist runtime/Monitor/SyncOnValueBasedClassTest.java Failure
• 79a07ad: 8343149: Cleanup os::print_tos_pc on AIX
• ... and 44 more: https://git.openjdk.org/jdk/compare/ca1700b8bf3b7b34616c469837748ac4c3607dfc...master

Your commit was automatically rebased without conflicts.

[openjdk]

@alexeysemenyukoracle Pushed as commit ceaa71e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.