Skip to content

8338007: [JVMCI] ResolvedJavaMethod.reprofile can crash ciMethodData #21746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
+43 −6
Closed

8338007: [JVMCI] ResolvedJavaMethod.reprofile can crash ciMethodData #21746

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
94915e5
8338007: [JVMCI] ResolvedJavaMethod.reprofile can crash ciMethodData
tkrodriguez Oct 28, 2024
86c1625
Review comments
tkrodriguez Oct 29, 2024
3543c20
Merge branch 'master' into tkr-mdo-reinitialize
tkrodriguez Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/hotspot/share/oops/methodData.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,9 @@ void DataLayout::initialize(u1 tag, u2 bci, int cell_count) {
temp._header._bits = (intptr_t)0;
temp._header._struct._tag = tag;
temp._header._struct._bci = bci;
_header = temp._header; // Write the cell atomtically
// Write the header using a single intptr_t write. This ensures that if the layout is
// reinitialized readers will never see the transient state where the header is 0.
_header = temp._header;

for (int i = 0; i < cell_count; i++) {
set_cell_at(i, (intptr_t)0);
Expand Down Expand Up @@ -1227,8 +1229,8 @@ MethodData::MethodData(const methodHandle& method)
initialize();
}

// Reinitialize the storage of an existing MDO at a safepoint. Doing it this will ensure it's not
// being accessed while the contents are being rewritten.
// Reinitialize the storage of an existing MDO at a safepoint. Doing it this way will ensure it's
// not being accessed while the contents are being rewritten.
class VM_ReinitializeMDO: public VM_Operation {
private:
MethodData* _mdo;
Expand Down