Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8260029: aarch64: fix typo in verify_oop_array #2175

Closed
wants to merge 1 commit into from

Conversation

@RealFYang
Copy link
Member

@RealFYang RealFYang commented Jan 21, 2021

In aarch64 verify_oop_array, we scan over array at 'a' for 'count' oops, verifying each one. The step for the loop should be one for each oop instead of 'size'. We may miss verifying some oops in the array if we set the step to 'size'. Also, we should use 'temp' instead of r16 for the compressed oop case. Register r16 defined but not used in this function.

Tier1-3 tested with linux-aarch64 fastdebug build.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Contributors

  • Zhuxuan Ni <nizhuxuan@huawei.com>

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2175/head:pull/2175
$ git checkout pull/2175

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 21, 2021

👋 Welcome back fyang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@RealFYang
Copy link
Member Author

@RealFYang RealFYang commented Jan 21, 2021

/contributor add Zhuxuan Ni nizhuxuan@huawei.com

@openjdk openjdk bot added the rfr label Jan 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 21, 2021

@RealFYang
Contributor Zhuxuan Ni <nizhuxuan@huawei.com> successfully added.

@openjdk
Copy link

@openjdk openjdk bot commented Jan 21, 2021

@RealFYang The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@RealFYang
Copy link
Member Author

@RealFYang RealFYang commented Jan 21, 2021

/cc hotspot-runtime

@openjdk
Copy link

@openjdk openjdk bot commented Jan 21, 2021

@RealFYang
The hotspot-runtime label was successfully added.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 21, 2021

Webrevs

Copy link
Contributor

@shipilev shipilev left a comment

This makes sense to me.

However, for testing, you probably need to run with -XX:+VerifyOops specifically, because there is only one test in the whole suite that enables it. Something like tier1 would do: make run-test TEST=tier1 TEST_VM_OPTS=-XX:+VerifyOops.

@openjdk
Copy link

@openjdk openjdk bot commented Jan 21, 2021

@RealFYang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260029: aarch64: fix typo in verify_oop_array

Co-authored-by: Zhuxuan Ni <nizhuxuan@huawei.com>
Reviewed-by: shade, aph

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 21, 2021
@RealFYang
Copy link
Member Author

@RealFYang RealFYang commented Jan 21, 2021

This makes sense to me.

However, for testing, you probably need to run with -XX:+VerifyOops specifically, because there is only one test in the whole suite that enables it. Something like tier1 would do: make run-test TEST=tier1 TEST_VM_OPTS=-XX:+VerifyOops.

Good suggestion. I performed another round of tier1-3 test with -XX:+VerifyOops. No regression witnessed. Merging.

@RealFYang
Copy link
Member Author

@RealFYang RealFYang commented Jan 21, 2021

/integrate

@openjdk openjdk bot closed this Jan 21, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 21, 2021

@RealFYang Since your change was applied there have been 17 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit 4bcffeb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealFYang RealFYang deleted the RealFYang:JDK-8260029 branch Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants