8343186: hsdis build libopcodes and libbfd are not found

[MBaesken]

On SUSE with precompiled binutils this error occurs :

configure: error: "/mydir/binutils-2.39-s15/lib64 must contain libbfd.a, libopcodes.a and libiberty.a"

But the libs are present; the error message and detection is wrong.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Warning

 ⚠️ Found leading lowercase letter in issue title for 8343186: hsdis build libopcodes and libbfd are not found

Issue

• JDK-8343186: hsdis build libopcodes and libbfd are not found (Bug - P4)

Reviewers

• Erik Joelsson (@erikj79 - Reviewer)
• Magnus Ihse Bursie (@magicus - Reviewer)
• Aleksey Shipilev (@shipilev - Reviewer)
• Julian Waters (@TheShermanTanker - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21755/head:pull/21755
$ git checkout pull/21755

Update a local copy of the PR:
$ git checkout pull/21755
$ git pull https://git.openjdk.org/jdk.git pull/21755/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21755

View PR using the GUI difftool:
$ git pr show -t 21755

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21755.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8343186: hsdis build libopcodes and libbfd are not found

Reviewed-by: erikj, ihse, shade, jwaters

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

• 60364ef: 8341273: JVMTI is not properly hiding some continuation related methods
• 520ddac: 8331861: [PPC64] Implement load / store assembler functions which take an Address object
• 9cfb0f7: 8341527: AVX-512 intrinsic for SHA3
• 4ce19ca: 8343190: GHA: Try building JTReg several times
• 7c800e6: 8343026: JFR: Index into fields in the topFrame
• d8b3685: 8342607: Enhance register printing on x86_64 platforms
• d8430ef: 8339573: Update CodeCacheSegmentSize and CodeEntryAlignment for ARM
• 6332e25: 8343183: [s390x]: Problemlist runtime/Monitor/SyncOnValueBasedClassTest.java Failure

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@MBaesken The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (6a551416)
• 00: Full (4f356e07)

[erikj79]

Looks good, just a minor style nit.

[erikj79]

Could you break these lines to match the rest of the if condition?

[magicus]

Looks good. Sorry for meddling with the capital letter of the bug title; I did not realize that you already had a PR posted.

[MBaesken]

Thanks for the reviews !

/integrate

[openjdk]

Going to push as commit f7f5198.
Since your change was applied there have been 14 commits pushed to the master branch:

• 63c19d3: 8341977: Replace predicate walking and cloning code for Loop Peeling with a predicate visitor
• 158ae51: 8250659: Clarify in ParameterizedType.getRawType() doc that only Class is returned
• b6f745d: 8342489: compiler/c2/irTests/TestVectorizationMismatchedAccess.java fails on big-endian platforms
• bd79594: 8343037: Missing @SInCE tag on JColorChooser.showDialog overload
• ceaa71e: 8342576: [macos] AppContentTest still fails after JDK-8341443 for same reason on older macOS versions
• 40f3d50: 8343211: Compile error: redefinition of 'Assembler::evmovdquw(XMMRegister,KRegister,XMMRegister,bool,int)'
• 60364ef: 8341273: JVMTI is not properly hiding some continuation related methods
• 520ddac: 8331861: [PPC64] Implement load / store assembler functions which take an Address object
• 9cfb0f7: 8341527: AVX-512 intrinsic for SHA3
• 4ce19ca: 8343190: GHA: Try building JTReg several times
• ... and 4 more: https://git.openjdk.org/jdk/compare/79a07ad726f4e4b0502a22a55832960aa1561911...master

Your commit was automatically rebased without conflicts.

[openjdk]

@MBaesken Pushed as commit f7f5198.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.