8343234: (bf) Move java/nio/Buffer/LimitDirectMemory.java from ProblemList.txt to ProblemList-Virtual.txt

[bplb]

Move LimitDirectMemory to the problem list which best matches the observed failure mode.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8343234: (bf) Move java/nio/Buffer/LimitDirectMemory.java from ProblemList.txt to ProblemList-Virtual.txt (Sub-task - P4)

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)
• Jaikiran Pai (@jaikiran - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21773/head:pull/21773
$ git checkout pull/21773

Update a local copy of the PR:
$ git checkout pull/21773
$ git pull https://git.openjdk.org/jdk.git pull/21773/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21773

View PR using the GUI difftool:
$ git pr show -t 21773

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21773.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8343234: (bf) Move java/nio/Buffer/LimitDirectMemory.java from ProblemList.txt to ProblemList-Virtual.txt

Reviewed-by: alanb, jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 54 new commits pushed to the master branch:

• 069bb79: 8342082: Remove unused BasicProgressBarUI.Animator.interval
• 00ec105: 8343412: Missing escapes for single quote marks in javac.properties
• 8c1cf8f: 8339128: Cannot resolve user specified tool properly after JDK-8338304
• 3c7082a: 8343419: Assertion failure in long vector unsigned min/max with -XX:+UseKNLSetting
• c82ad84: 8342183: Update tests to use stronger algorithms and keys
• 1eccdfc: 8343439: [JVMCI] Fix javadoc of Services.getSavedProperties
• ea110c3: 8343236: Use @APinote and @implSpec in j.util.Currency
• 5995786: 8343177: JFR: Remove critical section for thread id assignment
• 751a914: 8340733: Add scope for relaxing constraint on JavaCalls from CompilerThread
• 7e87c07: 8340116: test/jdk/sun/security/tools/jarsigner/PreserveRawManifestEntryAndDigest.java can fail due to regex
• ... and 44 more: https://git.openjdk.org/jdk/compare/60364ef0010bde2933c22bf581ff8b3700c4afd6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@bplb To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels

• build
• client
• compiler
• core-libs
• graal
• hotspot
• hotspot-compiler
• hotspot-gc
• hotspot-jfr
• hotspot-runtime
• i18n
• ide-support
• javadoc
• jdk
• jmx
• kulla
• net
• nio
• security
• serviceability
• shenandoah

[bplb]

/label nio

[openjdk]

@bplb
The nio label was successfully added.

[mlbridge]

Webrevs

• 01: Full - Incremental (6e08f82e)
• 00: Full (b45d5864)

[bplb]

Commit 6e08f82 incidentally adds aarch64 to the targeted architectures. Many repeats on these platforms have shown no failures.

[jaikiran]

The change looks reasonable to me. I've added an inline comment about the @requires in the test. I don't have a strong preference about it and it's OK if you want to continue using it in the proposed form.

[bplb]

/integrate

[openjdk]

Going to push as commit 0668e18.
Since your change was applied there have been 79 commits pushed to the master branch:

• 774de27: 8343497: Missing DEF_STATIC_JNI_OnLoad in libjimage and libsaproc native libraries
• 1cc3586: 8343551: Missing copyright header update in Charset-X-Coder.java.template
• 1c44834: 8333582: Update CLDR to Version 46.0
• 23fa1a3: 8343484: Remove unnecessary @SuppressWarnings annotations (nio)
• 7f8450c: 8343473: Update copyright year of AddmodsOption.java
• b74652b: 8343167: Unnecessary define checks in InterpreterRuntime after JDK-8199809
• 646d64e: 8340307: Add explanation around MemorySegment:reinterpret regarding arenas
• 8d6cfba: 8336267: Method and Constructor signature parsing can be shared on the root object
• 1f7d524: 8343437: ClassDesc.of incorrectly permitting empty names
• 895a7b6: 8342967: Lambda deduplication fails with non-metafactory BSMs and mismatched local variables names
• ... and 69 more: https://git.openjdk.org/jdk/compare/60364ef0010bde2933c22bf581ff8b3700c4afd6...master

Your commit was automatically rebased without conflicts.

[openjdk]

@bplb Pushed as commit 0668e18.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.