8343124: Tests fails with java.lang.IllegalAccessException: class com.sun.javatest.regtest.agent.MainWrapper$MainTask cannot access #21780

prsadhuk · 2024-10-30T02:50:08Z

Couple of printing tests dont have "public" modifier so CI testing fails to run this test citing IllegalAccessException.
Fix is made to made the test class public.

Additionally, modified PrintDlgPageable.java to use PFJ and made StreamPrintingOrientation.java automated.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8343124: Tests fails with java.lang.IllegalAccessException: class com.sun.javatest.regtest.agent.MainWrapper$MainTask cannot access (Bug - P4)

Reviewers

Abhishek Kumar (@kumarabhi006 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21780/head:pull/21780
$ git checkout pull/21780

Update a local copy of the PR:
$ git checkout pull/21780
$ git pull https://git.openjdk.org/jdk.git pull/21780/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21780

View PR using the GUI difftool:
$ git pr show -t 21780

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21780.diff

Using Webrev

Link to Webrev Comment

….sun.javatest.regtest.agent.MainWrapper cannot access

bridgekeeper · 2024-10-30T02:50:49Z

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-10-30T02:50:57Z

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8343124: Tests fails with java.lang.IllegalAccessException: class com.sun.javatest.regtest.agent.MainWrapper$MainTask cannot access

Reviewed-by: abhiscxk

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 283 new commits pushed to the master branch:

df08a9e: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF
e7f0bf1: 8343153: compiler/codecache/CheckLargePages.java fails on linux with huge pages configured but its number set to 0
f9e1c62: 8343436: Regression in StackMapGenerator after JDK-8339205
2432c4f: 8343206: Final graph reshaping should not compress abstract or interface class pointers
c125178: 8341068: [s390x] intrinsics for divideUnsigned and remainderUnsigned methods in java.lang.Integer and java.lang.Long
37a3398: 8343242: RISC-V: Refactor materialization of literal address
d26412e: 8343433: Update net.properties and java.net.http module-info.java after 8326949
29882bf: 8340311: JPackage app-image exe launches multiple exe's in JDK 22+
069bb79: 8342082: Remove unused BasicProgressBarUI.Animator.interval
00ec105: 8343412: Missing escapes for single quote marks in javac.properties
... and 273 more: https://git.openjdk.org/jdk/compare/f56a154132f7e66b1b65adfa2aa937119999b14a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2024-10-30T02:51:37Z

@prsadhuk The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2024-10-30T03:15:37Z

Webrevs

TejeshR13 · 2024-10-30T11:00:35Z

test/jdk/javax/print/StreamPrintingOrientation.java

+import javax.print.attribute.HashPrintRequestAttributeSet;
+
+public class StreamPrintingOrientation implements Printable {
+    public StreamPrintingOrientation() {


Can remove this constructor.

test/jdk/javax/print/StreamPrintingOrientation.java

TejeshR13 · 2024-10-30T11:03:18Z

test/jdk/java/awt/print/Dialog/PrintDlgPageable.java

-                return;
-            }
-            arg = Integer.parseInt(args[0]);
-                PrintDlgPageable pd = new PrintDlgPageable();


pd unused.

TejeshR13 · 2024-10-30T11:04:04Z

test/jdk/java/awt/print/Dialog/PrintDlgPageable.java

+    }
+
+    //printable interface
+    public int print(Graphics g, PageFormat pf, int pi) throws PrinterException {


throws PrinterException not required.

it is required...See java.awt.print.Printable spec

test/jdk/javax/print/StreamPrintingOrientation.java

kumarabhi006

Minor formatting changes.

kumarabhi006 · 2024-11-04T07:12:41Z

test/jdk/java/awt/print/Dialog/PrintDlgPageable.java

@@ -26,104 +26,120 @@
 * @bug 4869502 4869539
 * @key printer
 * @summary Confirm that ToPage is populated for argument =2. Range is disabled for argument = 0.


Suggested change

* @summary Confirm that ToPage is populated for argument =2. Range is disabled for argument = 0.

* @summary Confirm that ToPage is populated for argument = 2. Range is disabled for argument = 0.

kumarabhi006 · 2024-11-04T07:13:28Z

test/jdk/java/awt/print/Dialog/PrintDlgPageable.java

+
+

Extra blank line can be removed.

kumarabhi006 · 2024-11-04T07:15:08Z

test/jdk/java/awt/print/Dialog/PrintDlgPageable.java

+            .columns(35)
+            .build();
+
+        System.out.println("open PrintDialog..");


print statements can be logged in PFJ's logarea.

kumarabhi006 · 2024-11-04T07:15:40Z

test/jdk/java/awt/print/Dialog/PrintDlgPageable.java

+    public int print(Graphics g, PageFormat pf, int pi) throws PrinterException {
+
+        // Simply draw two rectangles
+        Graphics2D g2 = (Graphics2D)g;


Suggested change

Graphics2D g2 = (Graphics2D)g;

Graphics2D g2 = (Graphics2D) g;

kumarabhi006 · 2024-11-04T07:16:37Z

test/jdk/java/awt/print/Dialog/PrintDlgPageable.java

+        g2.drawRect(1,1,200,300);
+        g2.drawRect(1,1,25,25);
+        System.out.println("print method called "+pi + " Orientation "+pf.getOrientation());


Suggested change

g2.drawRect(1,1,200,300);

g2.drawRect(1,1,25,25);

System.out.println("print method called "+pi + " Orientation "+pf.getOrientation());

g2.drawRect(1, 1, 200, 300);

g2.drawRect(1, 1, 25, 25);

System.out.println("print method called " + pi + " Orientation " + pf.getOrientation());

kumarabhi006 · 2024-11-04T07:25:07Z

test/jdk/javax/print/StreamPrintingOrientation.java

+        System.out.println("\nValues in attr set passed to print method");
+        Attribute attr[] = prSet.toArray();
+        for (int x = 0; x < attr.length; x ++) {
+            System.out.println("Name "+attr[x].getName()+"  "+attr[x]);


Suggested change

System.out.println("Name "+attr[x].getName()+" "+attr[x]);

System.out.println("Name "+ attr[x].getName() + " " + attr[x]);

kumarabhi006 · 2024-11-04T07:25:28Z

test/jdk/javax/print/StreamPrintingOrientation.java

+            service = factories[0].getPrintService(fos);
+
+        if (service != null) {
+            System.out.println("Stream Print Service "+service);


Suggested change

System.out.println("Stream Print Service "+service);

System.out.println("Stream Print Service " + service);

kumarabhi006 · 2024-11-04T07:26:34Z

test/jdk/javax/print/StreamPrintingOrientation.java

+        if (factories.length > 0)
+            service = factories[0].getPrintService(fos);


Suggested change

if (factories.length > 0)

service = factories[0].getPrintService(fos);

if (factories.length > 0) {

service = factories[0].getPrintService(fos);

}

kumarabhi006 · 2024-11-04T07:27:12Z

test/jdk/javax/print/StreamPrintingOrientation.java


+        if (Files.mismatch(fl.toPath(), fp.toPath()) == -1) {
+            throw new RuntimeException("Printing stream orientation is same for both PORTRAIT and LANDSCAPE");


Please limit it to 80 cols.

kumarabhi006 · 2024-11-04T07:27:55Z

test/jdk/javax/print/StreamPrintingOrientation.java

+        System.out.println("StreamPrinting Test Width "+pf.getWidth()+" Height "+pf.getHeight());
+        g2.drawRect(1,1,200,300);
+        g2.drawRect(1,1,25,25);


Suggested change

System.out.println("StreamPrinting Test Width "+pf.getWidth()+" Height "+pf.getHeight());

g2.drawRect(1,1,200,300);

g2.drawRect(1,1,25,25);

System.out.println("StreamPrinting Test Width " + pf.getWidth() + " Height " + pf.getHeight());

g2.drawRect(1, 1, 200, 300);

g2.drawRect(1, 1, 25, 25);

prsadhuk · 2024-11-04T08:38:50Z

Minor formatting changes.

fixed..

kumarabhi006 · 2024-11-04T09:21:16Z

test/jdk/java/awt/print/Dialog/PrintDlgPageable.java

@@ -119,14 +116,14 @@ public Printable getPrintable(int pageIndex) {
    }

    public PageFormat getPageFormat(int pageIndex) {
-        System.out.println("getPageFormat called "+pageIndex);
+        System.out.println("getPageFormat called " + pageIndex);


Can be logged by PFJ's logArea.

kumarabhi006 · 2024-11-04T09:24:03Z

test/jdk/java/awt/print/Dialog/PrintDlgPageable.java


+        if (arg == 0) {
+            INSTRUCTIONS += "\n Confirm that page range is disabled.";
+


Blank line not required.

kumarabhi006 · 2024-11-04T09:24:57Z

test/jdk/java/awt/print/Dialog/PrintDlgPageable.java

+            }
+            catch (PrinterException pe) {
+                pe.printStackTrace();


Suggested change

}

catch (PrinterException pe) {

pe.printStackTrace();

} catch (PrinterException pe) {

pe.printStackTrace();

kumarabhi006 · 2024-11-04T09:26:44Z

test/jdk/java/awt/print/Dialog/PrintDlgPageable.java

+            PassFailJFrame.log("Orientation returned from Pageable " + findOrientation(pf.getOrientation()));
+            return pf;


duplicate code...can be moved outside of if..else block.

Removed the whole method as logging for printing is not needed for this PageRange check test

kumarabhi006 · 2024-11-04T09:29:00Z

test/jdk/java/awt/print/Dialog/PrintDlgPageable.java

+        } else if (orient == PageFormat.REVERSE_LANDSCAPE) {
+            return "REVERSE LANDSCAPE";


Is it required to check for REVERSE_LANDSCAPE as page formatting is set only either LANDSCAPE or PORTRAIT ?

kumarabhi006 · 2024-11-04T09:32:46Z

test/jdk/javax/print/StreamPrintingOrientation.java

+        PrintService service = null;
+
+        FileOutputStream fos = null;
+        File fl = null, fp = null;


Please declare it on separate lines as per java style coding.

kumarabhi006 · 2024-11-04T09:36:40Z

test/jdk/javax/print/StreamPrintingOrientation.java

+        FileOutputStream fos = null;
+        File fl = null, fp = null;
+        String mType = "application/postscript";

-class StreamPrintingOrientation implements Printable {
-        /**
-         * Constructor
-         */
-         public StreamPrintingOrientation() {
-                super();
+        fl = new File("stream_landscape.ps");
+        fl.deleteOnExit();
+        fos = new FileOutputStream(fl);


Can be rearranged something like..

String mType = "application/postscript"; File fp = null; File fl = new File("stream_landscape.ps"); fl.deleteOnExit(); FileOutputStream fos = new FileOutputStream(fl);

kumarabhi006 · 2024-11-04T09:38:18Z

test/jdk/javax/print/StreamPrintingOrientation.java

        }
+        // Simply draw two rectangles
+        Graphics2D g2 = (Graphics2D)g;


Suggested change

Graphics2D g2 = (Graphics2D)g;

Graphics2D g2 = (Graphics2D) g;

kumarabhi006

LGTM except minor change suggested.

kumarabhi006 · 2024-11-04T09:53:42Z

test/jdk/javax/print/StreamPrintingOrientation.java

@@ -57,10 +57,9 @@ public static void main(String[] args) throws Exception {
        PrintService service = null;

        FileOutputStream fos = null;


Can be moved to L64.

prsadhuk · 2024-11-05T06:27:09Z

/integrate

openjdk · 2024-11-05T06:27:45Z

Going to push as commit dafa2e5.
Since your change was applied there have been 308 commits pushed to the master branch:

0f7dd98: 8251926: PPC: Remove an unused variable in assembler_ppc.cpp
cd91a44: 8343549: SeededSecureRandomTest needn't be in a package
20f3aaf: 8343471: RISC-V: compiler/cpuflags/TestAESIntrinsicsOnUnsupportedConfig.java fails after JDK-8334999
67907d5: 8343500: Optimize ArrayClassDescImpl computeDescriptor
714472d: 8341798: Fix ExceptionOccurred in jdk.jdwp.agent
825ceb1: 8341796: Fix ExceptionOccurred in jdk.hotspot.agent
8b47497: 8331682: Slow networks/Impatient clients can potentially send unencrypted TLSv1.3 alerts that won't parse on the server
0668e18: 8343234: (bf) Move java/nio/Buffer/LimitDirectMemory.java from ProblemList.txt to ProblemList-Virtual.txt
774de27: 8343497: Missing DEF_STATIC_JNI_OnLoad in libjimage and libsaproc native libraries
1cc3586: 8343551: Missing copyright header update in Charset-X-Coder.java.template
... and 298 more: https://git.openjdk.org/jdk/compare/f56a154132f7e66b1b65adfa2aa937119999b14a...master

Your commit was automatically rebased without conflicts.

openjdk · 2024-11-05T06:27:55Z

@prsadhuk Pushed as commit dafa2e5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

prsadhuk added 2 commits October 30, 2024 03:44

8343124: Tests fails with java.lang.IllegalAccessException: class com…

96cb056

….sun.javatest.regtest.agent.MainWrapper cannot access

8343124: Tests fails with java.lang.IllegalAccessException: class com…

cb06e9d

….sun.javatest.regtest.agent.MainWrapper cannot access

openjdk bot added the client client-libs-dev@openjdk.org label Oct 30, 2024

jcheck

574e951

openjdk bot added the rfr Pull request is ready for review label Oct 30, 2024

TejeshR13 reviewed Oct 30, 2024

View reviewed changes

remove some redundant code

e92d441

prsadhuk changed the title ~~8343124: Tests fails with java.lang.IllegalAccessException: class com.sun.javatest.regtest.agent.MainWrapper cannot access~~ 8343124: Tests fails with java.lang.IllegalAccessException: class com.sun.javatest.regtest.agent.MainWrapper$MainTask cannot access Oct 30, 2024

remove some redundant code

2610850

kumarabhi006 reviewed Nov 4, 2024

View reviewed changes

minor formatting

09a59e6

kumarabhi006 reviewed Nov 4, 2024

View reviewed changes

minor formatting

9ff06c4

kumarabhi006 approved these changes Nov 4, 2024

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Nov 4, 2024

openjdk bot added the integrated Pull request has been integrated label Nov 5, 2024

openjdk bot closed this Nov 5, 2024

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 5, 2024

prsadhuk deleted the JDK-8343124 branch November 5, 2024 09:51

	* @summary Confirm that ToPage is populated for argument =2. Range is disabled for argument = 0.
	* @summary Confirm that ToPage is populated for argument = 2. Range is disabled for argument = 0.

	Graphics2D g2 = (Graphics2D)g;
	Graphics2D g2 = (Graphics2D) g;

	System.out.println("Name "+attr[x].getName()+" "+attr[x]);
	System.out.println("Name "+ attr[x].getName() + " " + attr[x]);

	System.out.println("Stream Print Service "+service);
	System.out.println("Stream Print Service " + service);

		if (factories.length > 0)
		service = factories[0].getPrintService(fos);


		if (Files.mismatch(fl.toPath(), fp.toPath()) == -1) {
		throw new RuntimeException("Printing stream orientation is same for both PORTRAIT and LANDSCAPE");


		if (arg == 0) {
		INSTRUCTIONS += "\n Confirm that page range is disabled.";

		PassFailJFrame.log("Orientation returned from Pageable " + findOrientation(pf.getOrientation()));
		return pf;

		} else if (orient == PageFormat.REVERSE_LANDSCAPE) {
		return "REVERSE LANDSCAPE";

		@@ -57,10 +57,9 @@ public static void main(String[] args) throws Exception {
		PrintService service = null;

		FileOutputStream fos = null;

8343124: Tests fails with java.lang.IllegalAccessException: class com.sun.javatest.regtest.agent.MainWrapper$MainTask cannot access #21780

8343124: Tests fails with java.lang.IllegalAccessException: class com.sun.javatest.regtest.agent.MainWrapper$MainTask cannot access #21780

Conversation

prsadhuk commented Oct 30, 2024 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Oct 30, 2024

openjdk bot commented Oct 30, 2024 • edited Loading

openjdk bot commented Oct 30, 2024

mlbridge bot commented Oct 30, 2024 • edited Loading

Webrevs

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kumarabhi006 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

prsadhuk commented Nov 4, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kumarabhi006 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

prsadhuk commented Nov 5, 2024

openjdk bot commented Nov 5, 2024

openjdk bot commented Nov 5, 2024

prsadhuk commented Oct 30, 2024 •

edited by openjdk bot

Loading

openjdk bot commented Oct 30, 2024 •

edited

Loading

mlbridge bot commented Oct 30, 2024 •

edited

Loading