Skip to content

8343314: Move common properties from jpackage jtreg test declarations to TEST.properties file #21792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

alexeysemenyukoracle
Copy link
Member

@alexeysemenyukoracle alexeysemenyukoracle commented Oct 30, 2024

Clean up of jpackage jtreg test declarations:

  • remove "@modules java.base/jdk.internal.util";
  • remove --add-opens from @run;
  • replace "@library ../../../../helpers" and "@library ../helpers" with "@library /test/jdk/tools/jpackage/helpers";
  • remove @library referring to unused libraries;
  • remove duplicated @build;
  • add modules=jdk.jpackage/jdk.jpackage.internal:+open java.base/jdk.internal.util to jpackage's TEST.properties file.

Most changes were automated with ad-hoc scripts.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8343314: Move common properties from jpackage jtreg test declarations to TEST.properties file (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21792/head:pull/21792
$ git checkout pull/21792

Update a local copy of the PR:
$ git checkout pull/21792
$ git pull https://git.openjdk.org/jdk.git pull/21792/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21792

View PR using the GUI difftool:
$ git pr show -t 21792

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21792.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 30, 2024

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 30, 2024

@alexeysemenyukoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8343314: Move common properties from jpackage jtreg test declarations to TEST.properties file

Reviewed-by: almatvee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

  • 825ceb1: 8341796: Fix ExceptionOccurred in jdk.hotspot.agent
  • 8b47497: 8331682: Slow networks/Impatient clients can potentially send unencrypted TLSv1.3 alerts that won't parse on the server
  • 0668e18: 8343234: (bf) Move java/nio/Buffer/LimitDirectMemory.java from ProblemList.txt to ProblemList-Virtual.txt
  • 774de27: 8343497: Missing DEF_STATIC_JNI_OnLoad in libjimage and libsaproc native libraries
  • 1cc3586: 8343551: Missing copyright header update in Charset-X-Coder.java.template
  • 1c44834: 8333582: Update CLDR to Version 46.0
  • 23fa1a3: 8343484: Remove unnecessary @SuppressWarnings annotations (nio)
  • 7f8450c: 8343473: Update copyright year of AddmodsOption.java
  • b74652b: 8343167: Unnecessary define checks in InterpreterRuntime after JDK-8199809
  • 646d64e: 8340307: Add explanation around MemorySegment:reinterpret regarding arenas
  • ... and 17 more: https://git.openjdk.org/jdk/compare/29882bfe7b7e76446a96862cd0a5e81c7e054415...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Oct 30, 2024

@alexeysemenyukoracle The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Oct 30, 2024
@alexeysemenyukoracle alexeysemenyukoracle marked this pull request as ready for review November 2, 2024 14:23
@alexeysemenyukoracle
Copy link
Member Author

@sashamatveev ptal

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 2, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 2, 2024

Webrevs

Copy link
Member

@sashamatveev sashamatveev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 4, 2024
@alexeysemenyukoracle
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 5, 2024

Going to push as commit c33a8f5.
Since your change was applied there have been 38 commits pushed to the master branch:

  • 16feeb7: 8343547: Restore accidentally removed annotations in LambdaForm from ClassFile API port
  • f62fc48: 8342498: Add test for Allocation elimination after use as alignment reference by SuperWord
  • f3671be: 8335392: C2 MergeStores: enhanced pointer parsing
  • 4fc6d41: 8341194: [REDO] Implement C2 VectorizedHashCode on AArch64
  • abf2dc7: 8343298: Improve stability of runtime/cds/DeterministicDump.java test
  • dafa2e5: 8343124: Tests fails with java.lang.IllegalAccessException: class com.sun.javatest.regtest.agent.MainWrapper$MainTask cannot access
  • 0f7dd98: 8251926: PPC: Remove an unused variable in assembler_ppc.cpp
  • cd91a44: 8343549: SeededSecureRandomTest needn't be in a package
  • 20f3aaf: 8343471: RISC-V: compiler/cpuflags/TestAESIntrinsicsOnUnsupportedConfig.java fails after JDK-8334999
  • 67907d5: 8343500: Optimize ArrayClassDescImpl computeDescriptor
  • ... and 28 more: https://git.openjdk.org/jdk/compare/29882bfe7b7e76446a96862cd0a5e81c7e054415...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 5, 2024
@openjdk openjdk bot closed this Nov 5, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 5, 2024
@openjdk
Copy link

openjdk bot commented Nov 5, 2024

@alexeysemenyukoracle Pushed as commit c33a8f5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@alexeysemenyukoracle alexeysemenyukoracle deleted the JDK-8343314 branch November 9, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants