Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8251548 Remove unnecessary explicit initialization of volatile variables in security-libs code #218

Closed
wants to merge 1 commit into from

Conversation

stsypanov
Copy link
Contributor

@stsypanov stsypanov commented Sep 17, 2020

Hello,

is it possible to have a code review for the changes proposed in JDK-8251548 (originally contributed via https://mail.openjdk.java.net/pipermail/security-dev/2020-June/022137.html)?

Sean Mullan has created an issue and web-review and can sponsor the patch as soos as it gets properly reviewed.

The issue itself is a continuation of changes merged into java.base before as:

As Doug Lea claims in http://cs.oswego.edu/pipermail/concurrency-interest/2015-December/014770.html

there is never any reason to explicitly initialize fields to 0/0.0/false/null

so I believe this patch is harmless as well as previous ones.

Issue: https://bugs.openjdk.java.net/browse/JDK-8251548
Webrev: https://cr.openjdk.java.net/~mullan/webrevs/8251548/

Thanks,
Sergey Tsypanov


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8251548: Remove unnecessary explicit initialization of volatile variables in security-libs code

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/218/head:pull/218
$ git checkout pull/218

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Sep 17, 2020
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 17, 2020

Hi @stsypanov, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user stsypanov" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Sep 17, 2020

@stsypanov The following labels will be automatically applied to this pull request: core-libs security.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added security security-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels Sep 17, 2020
@stsypanov
Copy link
Contributor Author

stsypanov commented Sep 17, 2020

/signed

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Sep 17, 2020
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 17, 2020

Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@bridgekeeper bridgekeeper bot removed oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status labels Sep 17, 2020
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 17, 2020
@mlbridge
Copy link

mlbridge bot commented Sep 17, 2020

Webrevs

@openjdk
Copy link

openjdk bot commented Sep 18, 2020

@stsypanov This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8251548: Remove unnecessary explicit initialization of volatile variables in security-libs code

Reviewed-by: mullan
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 28 commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate d35b117956cff96bd918f2dd10cdf71829e5c525.

As you do not have Committer status in this projectan existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@seanjmullan) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 18, 2020
@stsypanov
Copy link
Contributor Author

stsypanov commented Sep 18, 2020

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 18, 2020
@openjdk
Copy link

openjdk bot commented Sep 18, 2020

@stsypanov
Your change (at version 1b47cad) is now ready to be sponsored by a Committer.

@wangweij
Copy link
Contributor

wangweij commented Sep 18, 2020

/sponsor

@openjdk openjdk bot closed this Sep 18, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated labels Sep 18, 2020
@openjdk
Copy link

openjdk bot commented Sep 18, 2020

@wangweij @stsypanov Since your change was applied there have been 28 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit f55dd9d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr Pull request is ready for review label Sep 18, 2020
@stsypanov stsypanov deleted the simplify-volatile branch Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated security security-dev@openjdk.org
3 participants