Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8260222: remove unused _thread member SymbolTableLookup #2180

Closed
wants to merge 1 commit into from

Conversation

@MBaesken
Copy link
Member

@MBaesken MBaesken commented Jan 21, 2021

The class SymbolTableLookup has an unused member _thread. This could be removed.
See also the related sonar finding (claiming an uninitialized field) :

https://sonarcloud.io/project/issues?id=jdk&open=AXaE0c2j8L9hkQskF8y_&resolved=false&types=BUG

Thanks, Matthias


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8260222: remove unused _thread member SymbolTableLookup

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2180/head:pull/2180
$ git checkout pull/2180

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 21, 2021

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Jan 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 21, 2021

@MBaesken The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 21, 2021

Webrevs

Loading

Copy link
Contributor

@coleenp coleenp left a comment

Looks good + trivial.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jan 21, 2021

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260222: remove unused _thread member SymbolTableLookup

Reviewed-by: coleenp, dholmes, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

  • a97f3c1: 8258853: Support separate function declaration and definition with ENABLE_IF-based SFINAE
  • 154e1d6: 8259009: G1 heap summary should be shown in "Heap Parameters" window on HSDB
  • acbcde8: 8256111: Create implementation for NSAccessibilityStaticText protocol
  • f928265: 8260009: InstanceKlass::has_as_permitted_subclass() fails if subclass was redefined
  • 7ed8ba1: 8256814: WeakProcessorPhases may be redundant
  • bfac3fb: 8260212: Shenandoah: resolve-only UpdateRefsMode is not used
  • 58ceb25: 8259842: Remove Result cache from StringCoding
  • d066f2b: 8260030: Improve stringStream buffer handling
  • 1452280: 8164484: Unity, JTable cell editor, javax/swing/JComboBox/6559152/bug6559152.java
  • a70acf2: 8259928: compiler/jvmci tests fail with -Xint
  • ... and 11 more: https://git.openjdk.java.net/jdk/compare/7f7166dbc8822afaa39382cf9cb42be8458b0e4b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Jan 21, 2021
@shipilev
Copy link
Contributor

@shipilev shipilev commented Jan 21, 2021

Gaaa! I should have checked before opening #2188 -- that one also removes another leftover.

Loading

Copy link
Member

@dholmes-ora dholmes-ora left a comment

LGTM and trivial.

Thanks,
David

Loading

Copy link
Contributor

@shipilev shipilev left a comment

Looks fine.

Loading

@MBaesken
Copy link
Member Author

@MBaesken MBaesken commented Jan 26, 2021

/integrate

Loading

@openjdk openjdk bot closed this Jan 26, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 26, 2021

@MBaesken Since your change was applied there have been 63 commits pushed to the master branch:

  • c538cd8: 8165276: Spec states to invoke the premain method in an agent class if it's public but implementation differs
  • 9ea9323: 8254246: SymbolHashMapEntry wastes space
  • 982e42b: 8259726: Use of HashSet leads to undefined order in test output
  • d6fb9d7: 8255464: Cannot access ModuleTree in a CompilationUnitTree
  • 12ccd21: 8260289: Unable to customize module lists after change JDK-8258411
  • 73c78c8: 8260329: Update references to TAOCP to latest edition
  • 5b0b24b: 8260381: ProblemList com/sun/management/DiagnosticCommandMBean/DcmdMBeanTestCheckJni.java on Win with ZGC
  • 47c7dc7: 8258833: Cancel multi-part cipher operations in SunPKCS11 after failures
  • ef247ab: 8260308: Update LogCompilation junit to 4.13.1
  • d076977: 8260169: LogCompilation: Unexpected method mismatch
  • ... and 53 more: https://git.openjdk.java.net/jdk/compare/7f7166dbc8822afaa39382cf9cb42be8458b0e4b...master

Your commit was automatically rebased without conflicts.

Pushed as commit abd9310.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@MBaesken MBaesken deleted the JDK-8260222 branch Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants