8343305: Remove Indify-dependent microbenchmarks

[cl4es]

Benchmarks using Indify was added to the JMH microbenchmarks corpus in the JDK 8 timeframe. This adds overhead to the microbenchmarks build and has been blocking/slowing progress on some indy-based prototyping as the indify tool itself may not be 100% forward compatible.

I suggest we remove the Indify pass from the OpenJDK JMH test module and remove the microbenchmarks which depend on the tool.

These microbenchmarks will still available to build and run out of the standalone https://github.com/openjdk/jmh-jdk-microbenchmarks project:

https://github.com/openjdk/jmh-jdk-microbenchmarks/blob/master/micros-jdk8/src/main/java/org/openjdk/bench/java/lang/invoke/CallSiteSetTarget.java
https://github.com/openjdk/jmh-jdk-microbenchmarks/blob/master/micros-jdk8/src/main/java/org/openjdk/bench/java/lang/invoke/CallSiteSetTargetSelf.java
https://github.com/openjdk/jmh-jdk-microbenchmarks/blob/master/micros-jdk8/src/main/java/org/openjdk/bench/java/lang/invoke/CallSiteStable.java

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8343305: Remove Indify-dependent microbenchmarks (Enhancement - P4)

Reviewers

• Chen Liang (@liach - Reviewer)
• Magnus Ihse Bursie (@magicus - Reviewer)
• Erik Joelsson (@erikj79 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21807/head:pull/21807
$ git checkout pull/21807

Update a local copy of the PR:
$ git checkout pull/21807
$ git pull https://git.openjdk.org/jdk.git pull/21807/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21807

View PR using the GUI difftool:
$ git pr show -t 21807

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21807.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back redestad! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@cl4es This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8343305: Remove Indify-dependent microbenchmarks

Reviewed-by: liach, ihse, erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

• 568b07a: 8325089: jpackage utility creates an "infinite", undeleteable directory tree
• 7c36fa7: 8343019: Primitive caches must use boxed instances from the archive
• ae82cc1: 8342188: Update tests to use stronger key parameters and certificates
• 7ad3ef7: 8343057: JFR: Sorting in 'jfr view' can violate contract
• 7d8bd21: 8335977: Deoptimization fails with assert "object should be reallocated already"
• b269493: 8338981: Access to private classes should be permitted inside the permits clause of the enclosing top-level class
• 3ccd2f7: 8342458: More consistent constant instruction handling
• 29ae265: 8341861: GHA: Use only retention mechanism to remove bundles
• e5bbad0: 8334999: RISC-V: implement AES single block encryption/decryption intrinsics
• c40bb76: 8343296: IGV: Show pre/main/post at CountedLoopNodes
• ... and 1 more: https://git.openjdk.org/jdk/compare/2f1ba5ef09441ed9e505fe2e17c57ccb1771f777...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@cl4es The following labels will be automatically applied to this pull request:

• build
• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (4f02540b)

[liach]

Looks reasonable.

[cl4es]

Thanks @liach

I'll wait for someone from build-dev to have a look before integration.

[magicus]

Build changes look fine.

[cl4es]

Thanks everyone!

/integrate

[openjdk]

Going to push as commit 2932144.
Since your change was applied there have been 14 commits pushed to the master branch:

• 34655c6: 8342544: [macos] jpackage test helper should check for both "--app-image" and "--mac-sign" for signing predefined app image case
• 5a5d9c5: 8343085: [macos] jpackage verbose output on macOS contains numerous "Running /usr/bin/codesign" entries
• d4eb2d9: 8319343: Improve CDS module graph support for --add-modules option
• 568b07a: 8325089: jpackage utility creates an "infinite", undeleteable directory tree
• 7c36fa7: 8343019: Primitive caches must use boxed instances from the archive
• ae82cc1: 8342188: Update tests to use stronger key parameters and certificates
• 7ad3ef7: 8343057: JFR: Sorting in 'jfr view' can violate contract
• 7d8bd21: 8335977: Deoptimization fails with assert "object should be reallocated already"
• b269493: 8338981: Access to private classes should be permitted inside the permits clause of the enclosing top-level class
• 3ccd2f7: 8342458: More consistent constant instruction handling
• ... and 4 more: https://git.openjdk.org/jdk/compare/2f1ba5ef09441ed9e505fe2e17c57ccb1771f777...master

Your commit was automatically rebased without conflicts.

[openjdk]

@cl4es Pushed as commit 2932144.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.