Skip to content

8343412: Missing escapes for single quote marks in javac.properties #21816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

archiecobbs
Copy link
Contributor

@archiecobbs archiecobbs commented Oct 31, 2024

Please review these simple syntax fixes for javac.properties.

The source file javac.properties contains the English message bundle for the javac tool. Since the strings in this file are MessageFormat format strings, any single quotes must be escaped by doubling them.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8343412: Missing escapes for single quote marks in javac.properties (Bug - P5)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21816/head:pull/21816
$ git checkout pull/21816

Update a local copy of the PR:
$ git checkout pull/21816
$ git pull https://git.openjdk.org/jdk.git pull/21816/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21816

View PR using the GUI difftool:
$ git pr show -t 21816

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21816.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 31, 2024

👋 Welcome back acobbs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 31, 2024

@archiecobbs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8343412: Missing escapes for single quote marks in javac.properties

Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

  • 8c1cf8f: 8339128: Cannot resolve user specified tool properly after JDK-8338304
  • 3c7082a: 8343419: Assertion failure in long vector unsigned min/max with -XX:+UseKNLSetting
  • c82ad84: 8342183: Update tests to use stronger algorithms and keys
  • 1eccdfc: 8343439: [JVMCI] Fix javadoc of Services.getSavedProperties
  • ea110c3: 8343236: Use @APinote and @implSpec in j.util.Currency
  • 5995786: 8343177: JFR: Remove critical section for thread id assignment
  • 751a914: 8340733: Add scope for relaxing constraint on JavaCalls from CompilerThread
  • 7e87c07: 8340116: test/jdk/sun/security/tools/jarsigner/PreserveRawManifestEntryAndDigest.java can fail due to regex
  • da0e9e3: 8343333: Parallel: Cleanup comment referring Solaris in MutableNUMASpace
  • f77a514: 8343194: Avoid redundant Hashtable.containsKey call in CodeSource.readObject
  • ... and 13 more: https://git.openjdk.org/jdk/compare/ae82cc1ba101f6c566278f79a2e94bd1d1dd9efe...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 31, 2024
@openjdk
Copy link

openjdk bot commented Oct 31, 2024

@archiecobbs The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the compiler compiler-dev@openjdk.org label Oct 31, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 31, 2024

Webrevs

Copy link
Contributor

@vicente-romero-oracle vicente-romero-oracle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 2, 2024
@archiecobbs
Copy link
Contributor Author

@vicente-romero-oracle thanks for the quick review.

@archiecobbs
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 2, 2024

Going to push as commit 00ec105.
Since your change was applied there have been 23 commits pushed to the master branch:

  • 8c1cf8f: 8339128: Cannot resolve user specified tool properly after JDK-8338304
  • 3c7082a: 8343419: Assertion failure in long vector unsigned min/max with -XX:+UseKNLSetting
  • c82ad84: 8342183: Update tests to use stronger algorithms and keys
  • 1eccdfc: 8343439: [JVMCI] Fix javadoc of Services.getSavedProperties
  • ea110c3: 8343236: Use @APinote and @implSpec in j.util.Currency
  • 5995786: 8343177: JFR: Remove critical section for thread id assignment
  • 751a914: 8340733: Add scope for relaxing constraint on JavaCalls from CompilerThread
  • 7e87c07: 8340116: test/jdk/sun/security/tools/jarsigner/PreserveRawManifestEntryAndDigest.java can fail due to regex
  • da0e9e3: 8343333: Parallel: Cleanup comment referring Solaris in MutableNUMASpace
  • f77a514: 8343194: Avoid redundant Hashtable.containsKey call in CodeSource.readObject
  • ... and 13 more: https://git.openjdk.org/jdk/compare/ae82cc1ba101f6c566278f79a2e94bd1d1dd9efe...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 2, 2024
@openjdk openjdk bot closed this Nov 2, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 2, 2024
@openjdk
Copy link

openjdk bot commented Nov 2, 2024

@archiecobbs Pushed as commit 00ec105.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants