JDK-8260208: Improve dummy object filling condition in G1CollectedHeap::fill_archive_regions in cds

[Hamlin-Li]

it's a minor fix/enhancement in cds, it fixes dummy object filling condition in G1CollectedHeap::fill_archive_regions

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8260208: Improve dummy object filling condition in G1CollectedHeap::fill_archive_regions in cds

Reviewers

• Thomas Schatzl (@tschatzl - Reviewer)
• Ioi Lam (@iklam - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2183/head:pull/2183
$ git checkout pull/2183

[bridgekeeper]

👋 Welcome back mli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@Hamlin-Li The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (5b97401)

[tschatzl]

/label hotspot-runtime

[openjdk]

@tschatzl
The hotspot-runtime label was successfully added.

[tschatzl]

I think this is good, but let's have somebody from the runtime team also have a quick look over it.

[tschatzl]

What's the testing for this change? Pre-submit testing is not configured, so there is no indication that this has been tested.

[Hamlin-Li]

Thanks for reviewing.
I just enabled the pre-submit test, and I also manually triggered one run.

[iklam]

The assert looks correct to me.

[openjdk]

@Hamlin-Li This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260208: Improve dummy object filling condition in G1CollectedHeap::fill_archive_regions in cds

Reviewed-by: tschatzl, iklam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 52 new commits pushed to the master branch:

• 535c292: 8260306: Do not include osThread.hpp in thread.hpp
• 06348df: 8259776: Remove ParallelGC non-CAS oldgen allocation
• 6c4c96f: 8258742: Move PtrQueue reset to PtrQueueSet subclasses
• b53d5ca: 8260315: Typo "focul" instead of "focus" in FocusSpec.html
• f624dba: 8240247: No longer need to wrap files with contentContainer
• 5cdcce1: 8260307: Do not include method.hpp in frame.hpp
• 6f2a394: Merge
• 685c03d: 8259271: gc/parallel/TestDynShrinkHeap.java still fails "assert(covered_region.contains(new_memregion)) failed: new region is not in covered_region"
• d90e06a: 8259775: [Vector API] Incorrect code-gen for VectorReinterpret operation
• ede1bea: 8227695: assert(pss->trim_ticks().seconds() == 0.0) failed: Unexpected partial trimming during evacuation
• ... and 42 more: https://git.openjdk.java.net/jdk/compare/35c9da70316da21a6be2fd92a5e5b5f193bdd9d6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[Hamlin-Li]

/integrate

[openjdk]

@Hamlin-Li Since your change was applied there have been 53 commits pushed to the master branch:

• c52c6c6: 8260273: DataOutputStream writeChars optimization
• 535c292: 8260306: Do not include osThread.hpp in thread.hpp
• 06348df: 8259776: Remove ParallelGC non-CAS oldgen allocation
• 6c4c96f: 8258742: Move PtrQueue reset to PtrQueueSet subclasses
• b53d5ca: 8260315: Typo "focul" instead of "focus" in FocusSpec.html
• f624dba: 8240247: No longer need to wrap files with contentContainer
• 5cdcce1: 8260307: Do not include method.hpp in frame.hpp
• 6f2a394: Merge
• 685c03d: 8259271: gc/parallel/TestDynShrinkHeap.java still fails "assert(covered_region.contains(new_memregion)) failed: new region is not in covered_region"
• d90e06a: 8259775: [Vector API] Incorrect code-gen for VectorReinterpret operation
• ... and 43 more: https://git.openjdk.java.net/jdk/compare/35c9da70316da21a6be2fd92a5e5b5f193bdd9d6...master

Your commit was automatically rebased without conflicts.

Pushed as commit 4ae39b1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.