8343439: [JVMCI] Fix javadoc of Services.getSavedProperties

[dougxc]

The javadoc of jdk.vm.ci.services.Services.getSavedProperties is currently:

    /**
     * Gets an unmodifiable copy of the system properties parsed by {@code arguments.cpp}
     * plus {@code java.specification.version}, {@code os.name} and {@code os.arch}.
     * The latter two are forced to be the real OS and architecture. That is, values
     * for these two properties set on the command line are ignored.
     */

The details about how the copy is initialized are specific to the HotSpot VM. On SVM, the semantics can be different. This PR separates out the HotSpot specific part.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8343439: [JVMCI] Fix javadoc of Services.getSavedProperties (Bug - P4)

Reviewers

• Tom Rodriguez (@tkrodriguez - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21832/head:pull/21832
$ git checkout pull/21832

Update a local copy of the PR:
$ git checkout pull/21832
$ git pull https://git.openjdk.org/jdk.git pull/21832/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21832

View PR using the GUI difftool:
$ git pr show -t 21832

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21832.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dougxc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8343439: [JVMCI] Fix javadoc of Services.getSavedProperties

Reviewed-by: never

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 151 new commits pushed to the master branch:

• ea110c3: 8343236: Use @APinote and @implSpec in j.util.Currency
• 5995786: 8343177: JFR: Remove critical section for thread id assignment
• 751a914: 8340733: Add scope for relaxing constraint on JavaCalls from CompilerThread
• 7e87c07: 8340116: test/jdk/sun/security/tools/jarsigner/PreserveRawManifestEntryAndDigest.java can fail due to regex
• da0e9e3: 8343333: Parallel: Cleanup comment referring Solaris in MutableNUMASpace
• f77a514: 8343194: Avoid redundant Hashtable.containsKey call in CodeSource.readObject
• 4a70c83: 8343378: Exceptions in javax/management DeadLockTest.java do not cause test failure
• 8d4d589: 8343297: Vector unsigned min/max test are failing with -Xcomp
• 2a4d9d9: 8343379: [BACKOUT] 8343190 GHA: Try building JTReg several times
• 6f6cfe6: 8343380: C2: assert(iff->in(1)->is_OpaqueNotNull()) failed: must be OpaqueNotNull
• ... and 141 more: https://git.openjdk.org/jdk/compare/8bcd4920f1b03d0ef8e295e53557c629f05ceaa4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@dougxc The following labels will be automatically applied to this pull request:

• graal
• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (c8ef6cab)

[dougxc]

Thanks for the review Tom.

/integrate

[openjdk]

Going to push as commit 1eccdfc.
Since your change was applied there have been 151 commits pushed to the master branch:

• ea110c3: 8343236: Use @APinote and @implSpec in j.util.Currency
• 5995786: 8343177: JFR: Remove critical section for thread id assignment
• 751a914: 8340733: Add scope for relaxing constraint on JavaCalls from CompilerThread
• 7e87c07: 8340116: test/jdk/sun/security/tools/jarsigner/PreserveRawManifestEntryAndDigest.java can fail due to regex
• da0e9e3: 8343333: Parallel: Cleanup comment referring Solaris in MutableNUMASpace
• f77a514: 8343194: Avoid redundant Hashtable.containsKey call in CodeSource.readObject
• 4a70c83: 8343378: Exceptions in javax/management DeadLockTest.java do not cause test failure
• 8d4d589: 8343297: Vector unsigned min/max test are failing with -Xcomp
• 2a4d9d9: 8343379: [BACKOUT] 8343190 GHA: Try building JTReg several times
• 6f6cfe6: 8343380: C2: assert(iff->in(1)->is_OpaqueNotNull()) failed: must be OpaqueNotNull
• ... and 141 more: https://git.openjdk.org/jdk/compare/8bcd4920f1b03d0ef8e295e53557c629f05ceaa4...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dougxc Pushed as commit 1eccdfc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.