-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8343471: RISC-V: compiler/cpuflags/TestAESIntrinsicsOnUnsupportedConfig.java fails after JDK-8334999 #21847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ig.java fails after JDK-8334999
👋 Welcome back fyang! A progress list of the required criteria for merging this PR into |
@RealFYang This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 18 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@RealFYang The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@sendaoYan @Hamlin-Li : Thanks for the review! |
Going to push as commit 20f3aaf.
Your commit was automatically rebased without conflicts. |
@RealFYang Pushed as commit 20f3aaf. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi, please review this small change.
The test expects a message like
warning: AES instructions are not available on this CPU
for all cpu platforms without AES support. After https://bugs.openjdk.org/browse/JDK-8334999, we report thiswarning: AES intrinsics require Zvkn extension (not available on this CPU)
on RISC-V platforms whereZvkn
extension is not available. Patch fixes this message making it consistent with other CPU platforms. Same test passes with this fix.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21847/head:pull/21847
$ git checkout pull/21847
Update a local copy of the PR:
$ git checkout pull/21847
$ git pull https://git.openjdk.org/jdk.git pull/21847/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 21847
View PR using the GUI difftool:
$ git pr show -t 21847
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21847.diff
Using Webrev
Link to Webrev Comment