Skip to content

8343471: RISC-V: compiler/cpuflags/TestAESIntrinsicsOnUnsupportedConfig.java fails after JDK-8334999 #21847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

RealFYang
Copy link
Member

@RealFYang RealFYang commented Nov 2, 2024

Hi, please review this small change.

The test expects a message like warning: AES instructions are not available on this CPU for all cpu platforms without AES support. After https://bugs.openjdk.org/browse/JDK-8334999, we report this warning: AES intrinsics require Zvkn extension (not available on this CPU) on RISC-V platforms where Zvkn extension is not available. Patch fixes this message making it consistent with other CPU platforms. Same test passes with this fix.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8343471: RISC-V: compiler/cpuflags/TestAESIntrinsicsOnUnsupportedConfig.java fails after JDK-8334999 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21847/head:pull/21847
$ git checkout pull/21847

Update a local copy of the PR:
$ git checkout pull/21847
$ git pull https://git.openjdk.org/jdk.git pull/21847/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21847

View PR using the GUI difftool:
$ git pr show -t 21847

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21847.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 2, 2024

👋 Welcome back fyang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 2, 2024

@RealFYang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8343471: RISC-V: compiler/cpuflags/TestAESIntrinsicsOnUnsupportedConfig.java fails after JDK-8334999

Reviewed-by: syan, mli

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

  • 8d6cfba: 8336267: Method and Constructor signature parsing can be shared on the root object
  • 1f7d524: 8343437: ClassDesc.of incorrectly permitting empty names
  • 895a7b6: 8342967: Lambda deduplication fails with non-metafactory BSMs and mismatched local variables names
  • b41d713: 8343513: Forward declare Thread in mutexLocker.hpp
  • 809030b: 8321500: javadoc rejects '@' in multi-line attribute value
  • 7bca0af: 8343128: PassFailJFrame.java test result: Error. Bad action for script: build}
  • f69b601: 8343188: Investigate ways to simplify MemorySegment::ofBuffer
  • 7f131a9: 8343415: RISC-V: Increase maximum size of C2EntryBarrierStub by four
  • 452a5fb: 8343507: Parallel: Fail if verify_complete finds incorrect states
  • 7580199: 8343205: CompileBroker::possibly_add_compiler_threads excessively polls available memory
  • ... and 8 more: https://git.openjdk.org/jdk/compare/069bb79103f0ab75448de3989468d08b3cc3d793...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Nov 2, 2024

@RealFYang The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Nov 2, 2024
@RealFYang RealFYang marked this pull request as ready for review November 3, 2024 02:46
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 3, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 3, 2024

Webrevs

Copy link
Member

@sendaoYan sendaoYan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

Copy link

@Hamlin-Li Hamlin-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 4, 2024
@RealFYang
Copy link
Member Author

@sendaoYan @Hamlin-Li : Thanks for the review!
/integrate

@openjdk
Copy link

openjdk bot commented Nov 5, 2024

Going to push as commit 20f3aaf.
Since your change was applied there have been 30 commits pushed to the master branch:

  • 67907d5: 8343500: Optimize ArrayClassDescImpl computeDescriptor
  • 714472d: 8341798: Fix ExceptionOccurred in jdk.jdwp.agent
  • 825ceb1: 8341796: Fix ExceptionOccurred in jdk.hotspot.agent
  • 8b47497: 8331682: Slow networks/Impatient clients can potentially send unencrypted TLSv1.3 alerts that won't parse on the server
  • 0668e18: 8343234: (bf) Move java/nio/Buffer/LimitDirectMemory.java from ProblemList.txt to ProblemList-Virtual.txt
  • 774de27: 8343497: Missing DEF_STATIC_JNI_OnLoad in libjimage and libsaproc native libraries
  • 1cc3586: 8343551: Missing copyright header update in Charset-X-Coder.java.template
  • 1c44834: 8333582: Update CLDR to Version 46.0
  • 23fa1a3: 8343484: Remove unnecessary @SuppressWarnings annotations (nio)
  • 7f8450c: 8343473: Update copyright year of AddmodsOption.java
  • ... and 20 more: https://git.openjdk.org/jdk/compare/069bb79103f0ab75448de3989468d08b3cc3d793...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 5, 2024
@openjdk openjdk bot closed this Nov 5, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 5, 2024
@openjdk
Copy link

openjdk bot commented Nov 5, 2024

@RealFYang Pushed as commit 20f3aaf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants