Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8343473: Update copyright year of AddmodsOption.java #21848

Closed
wants to merge 1 commit into from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Nov 2, 2024

The newly added test runtime/cds/appcds/jigsaw/addmods/AddmodsOption.java on Thu Oct 31 2024, the copyright year should be 2024.
Trivial fix, no risk.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8343473: Update copyright year of AddmodsOption.java (Bug - P5)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21848/head:pull/21848
$ git checkout pull/21848

Update a local copy of the PR:
$ git checkout pull/21848
$ git pull https://git.openjdk.org/jdk.git pull/21848/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21848

View PR using the GUI difftool:
$ git pr show -t 21848

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21848.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 2, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 2, 2024

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8343473: Update copyright year of AddmodsOption.java

Reviewed-by: mli

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

  • b74652b: 8343167: Unnecessary define checks in InterpreterRuntime after JDK-8199809
  • 646d64e: 8340307: Add explanation around MemorySegment:reinterpret regarding arenas
  • 8d6cfba: 8336267: Method and Constructor signature parsing can be shared on the root object
  • 1f7d524: 8343437: ClassDesc.of incorrectly permitting empty names
  • 895a7b6: 8342967: Lambda deduplication fails with non-metafactory BSMs and mismatched local variables names
  • b41d713: 8343513: Forward declare Thread in mutexLocker.hpp
  • 809030b: 8321500: javadoc rejects '@' in multi-line attribute value
  • 7bca0af: 8343128: PassFailJFrame.java test result: Error. Bad action for script: build}
  • f69b601: 8343188: Investigate ways to simplify MemorySegment::ofBuffer
  • 7f131a9: 8343415: RISC-V: Increase maximum size of C2EntryBarrierStub by four
  • ... and 10 more: https://git.openjdk.org/jdk/compare/069bb79103f0ab75448de3989468d08b3cc3d793...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 2, 2024
@openjdk
Copy link

openjdk bot commented Nov 2, 2024

@sendaoYan The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Nov 2, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 2, 2024

Webrevs

Copy link

@Hamlin-Li Hamlin-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and trivial.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 4, 2024
@sendaoYan
Copy link
Member Author

Thanks for the review.

/integrate

@openjdk
Copy link

openjdk bot commented Nov 4, 2024

Going to push as commit 7f8450c.
Since your change was applied there have been 20 commits pushed to the master branch:

  • b74652b: 8343167: Unnecessary define checks in InterpreterRuntime after JDK-8199809
  • 646d64e: 8340307: Add explanation around MemorySegment:reinterpret regarding arenas
  • 8d6cfba: 8336267: Method and Constructor signature parsing can be shared on the root object
  • 1f7d524: 8343437: ClassDesc.of incorrectly permitting empty names
  • 895a7b6: 8342967: Lambda deduplication fails with non-metafactory BSMs and mismatched local variables names
  • b41d713: 8343513: Forward declare Thread in mutexLocker.hpp
  • 809030b: 8321500: javadoc rejects '@' in multi-line attribute value
  • 7bca0af: 8343128: PassFailJFrame.java test result: Error. Bad action for script: build}
  • f69b601: 8343188: Investigate ways to simplify MemorySegment::ofBuffer
  • 7f131a9: 8343415: RISC-V: Increase maximum size of C2EntryBarrierStub by four
  • ... and 10 more: https://git.openjdk.org/jdk/compare/069bb79103f0ab75448de3989468d08b3cc3d793...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 4, 2024
@openjdk openjdk bot closed this Nov 4, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 4, 2024
@openjdk
Copy link

openjdk bot commented Nov 4, 2024

@sendaoYan Pushed as commit 7f8450c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants