8343477: Remove unnecessary @SuppressWarnings annotations (compiler) #21851

archiecobbs · 2024-11-02T15:27:23Z

Please review this patch which removes unnecessary @SuppressWarnings annotations.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed (2 reviews required, with at least 2 Reviewers)

Issue

JDK-8343477: Remove unnecessary @SuppressWarnings annotations (compiler) (Sub-task - P5)

Reviewers

Joe Darcy (@jddarcy - Reviewer)
Maurizio Cimadamore (@mcimadamore - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21851/head:pull/21851
$ git checkout pull/21851

Update a local copy of the PR:
$ git checkout pull/21851
$ git pull https://git.openjdk.org/jdk.git pull/21851/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21851

View PR using the GUI difftool:
$ git pr show -t 21851

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21851.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2024-11-02T15:28:00Z

👋 Welcome back acobbs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-11-02T15:28:09Z

@archiecobbs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8343477: Remove unnecessary @SuppressWarnings annotations (compiler)

Reviewed-by: darcy, mcimadamore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 94 new commits pushed to the master branch:

dbffe33: 8345263: Make sure that lint categories are used correctly when logging lint warnings
32c8195: 8345801: C2: Clean up include statements to speed up compilation when touching type.hpp
9286018: 8345322: RISC-V: Add concurrent gtests for cmpxchg variants
4fc43b0: 8345770: javadoc: API documentation builds are not always reproducible
ee1c5ad: 8345975: Update SAP SE copyright year to 2024 where it was missed
3518b4b: 8344171: Clone and initialize Assertion Predicates in order instead of in reverse-order
c88e081: 8346160: Fix -Wzero-as-null-pointer-constant warnings from explicit casts
ab1dbd4: 8346202: Correct typo in SQLPermission
6b022bb: 8344453: Test jdk/jfr/event/oldobject/TestSanityDefault.java timed out
3b9de11: 8319875: Add macOS implementation for jcmd System.map
... and 84 more: https://git.openjdk.org/jdk/compare/cc628a133e471e7edf07831ff386f0eaf57e9bff...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2024-11-02T15:28:46Z

@archiecobbs The following labels will be automatically applied to this pull request:

build
compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

mlbridge · 2024-11-02T15:32:00Z

Webrevs

magicus · 2024-11-04T14:55:23Z

/label -build

openjdk · 2024-11-04T14:55:53Z

@magicus
The build label was successfully removed.

bridgekeeper · 2024-12-02T19:24:53Z

@archiecobbs This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

archiecobbs · 2024-12-02T19:36:41Z

/pingbot

openjdk · 2024-12-02T19:36:52Z

@archiecobbs Unknown command pingbot - for a list of valid commands use /help.

jddarcy · 2024-12-09T19:35:32Z

/reviewers 2 reviewer

openjdk · 2024-12-09T19:36:10Z

@jddarcy
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 2 Reviewers).

jddarcy

Looks fine; thanks for the cleanup @archiecobbs .

Bumped the reviewer count so someone who more directly works on javac will take a look too.

mcimadamore · 2024-12-16T10:42:32Z

src/jdk.compiler/share/classes/com/sun/tools/javac/model/AnnotationProxyMaker.java

@@ -220,7 +220,7 @@ public void visitArray(Attribute.Array a) {
            }
        }

-        @SuppressWarnings({"unchecked", "rawtypes"})
+        @SuppressWarnings("unchecked")


Tricky but correct :-) This relies on the special pleading for casts to "raw" Class

mcimadamore · 2024-12-16T10:46:35Z

src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java

@@ -2891,7 +2890,6 @@ JCStatement parseStatementAsBlock() {

    /**This method parses a statement appearing inside a block.
     */
-    @SuppressWarnings("fallthrough")


This is a bit tricky. Yes, as things stand the suppression is redundant. But the switch does contain a case with fallthrough - only it's the last case, so the fallthrough does nothing. If a default is added (or some other case after the last) the fallthrough will become more apparent. (but then a warnings should be issued as well). Considering we have already a comment to indicate the fallthrough, this change is ok.

mcimadamore

Looks good - nice cleanup!

archiecobbs · 2024-12-16T14:51:35Z

Thanks for the review!

archiecobbs · 2024-12-16T14:51:40Z

/integrate

openjdk · 2024-12-16T14:52:44Z

Going to push as commit d737978.
Since your change was applied there have been 96 commits pushed to the master branch:

8133eb2: 8346150: Jib dependency on autoconf missing for 'docs' profile
45a3297: 8346248: serviceability/dcmd/vm/{SystemMapTest.java,SystemMapTest.java} failing on macos-aarch64
dbffe33: 8345263: Make sure that lint categories are used correctly when logging lint warnings
32c8195: 8345801: C2: Clean up include statements to speed up compilation when touching type.hpp
9286018: 8345322: RISC-V: Add concurrent gtests for cmpxchg variants
4fc43b0: 8345770: javadoc: API documentation builds are not always reproducible
3518b4b: 8344171: Clone and initialize Assertion Predicates in order instead of in reverse-order
c88e081: 8346160: Fix -Wzero-as-null-pointer-constant warnings from explicit casts
ab1dbd4: 8346202: Correct typo in SQLPermission
... and 86 more: https://git.openjdk.org/jdk/compare/cc628a133e471e7edf07831ff386f0eaf57e9bff...master

Your commit was automatically rebased without conflicts.

openjdk · 2024-12-16T14:52:52Z

@archiecobbs Pushed as commit d737978.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

archiecobbs added 4 commits October 31, 2024 14:33

Remove unnecessary @SuppressWarnings annotations.

917f469

Undo change that will be moved to the core-libs branch.

3cf7606

Apply change that was missed somehow.

0fd82cb

Merge branch 'master' into SuppressWarningsCleanup-compiler

84561e2

openjdk bot added the rfr Pull request is ready for review label Nov 2, 2024

openjdk bot added build build-dev@openjdk.org compiler compiler-dev@openjdk.org labels Nov 2, 2024

archiecobbs added 2 commits November 2, 2024 21:51

Merge branch 'master' into SuppressWarningsCleanup-compiler

68afb75

Update copyright years.

033f763

openjdk bot removed the build build-dev@openjdk.org label Nov 4, 2024

archiecobbs added 3 commits November 8, 2024 13:00

Merge branch 'master' into SuppressWarningsCleanup-compiler

d955b53

Merge branch 'master' into SuppressWarningsCleanup-compiler

8b95d37

Merge branch 'master' into SuppressWarningsCleanup-compiler

af81a54

Merge branch 'master' into SuppressWarningsCleanup-compiler

58bed33

jddarcy approved these changes Dec 9, 2024

View reviewed changes

mcimadamore reviewed Dec 16, 2024

View reviewed changes

mcimadamore approved these changes Dec 16, 2024

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Dec 16, 2024

openjdk bot added the integrated Pull request has been integrated label Dec 16, 2024

openjdk bot closed this Dec 16, 2024

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8343477: Remove unnecessary @SuppressWarnings annotations (compiler) #21851

8343477: Remove unnecessary @SuppressWarnings annotations (compiler) #21851

archiecobbs commented Nov 2, 2024 •

edited by openjdk bot

Loading

bridgekeeper bot commented Nov 2, 2024

openjdk bot commented Nov 2, 2024 •

edited

Loading

openjdk bot commented Nov 2, 2024

mlbridge bot commented Nov 2, 2024 •

edited

Loading

magicus commented Nov 4, 2024

openjdk bot commented Nov 4, 2024

bridgekeeper bot commented Dec 2, 2024

archiecobbs commented Dec 2, 2024

openjdk bot commented Dec 2, 2024

jddarcy commented Dec 9, 2024

openjdk bot commented Dec 9, 2024

jddarcy left a comment

mcimadamore Dec 16, 2024

mcimadamore Dec 16, 2024

mcimadamore left a comment

archiecobbs commented Dec 16, 2024

archiecobbs commented Dec 16, 2024

openjdk bot commented Dec 16, 2024

openjdk bot commented Dec 16, 2024

8343477: Remove unnecessary @SuppressWarnings annotations (compiler) #21851

8343477: Remove unnecessary @SuppressWarnings annotations (compiler) #21851

Conversation

archiecobbs commented Nov 2, 2024 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Nov 2, 2024

openjdk bot commented Nov 2, 2024 • edited Loading

openjdk bot commented Nov 2, 2024

mlbridge bot commented Nov 2, 2024 • edited Loading

Webrevs

magicus commented Nov 4, 2024

openjdk bot commented Nov 4, 2024

bridgekeeper bot commented Dec 2, 2024

archiecobbs commented Dec 2, 2024

openjdk bot commented Dec 2, 2024

jddarcy commented Dec 9, 2024

openjdk bot commented Dec 9, 2024

jddarcy left a comment

Choose a reason for hiding this comment

mcimadamore Dec 16, 2024

Choose a reason for hiding this comment

mcimadamore Dec 16, 2024

Choose a reason for hiding this comment

mcimadamore left a comment

Choose a reason for hiding this comment

archiecobbs commented Dec 16, 2024

archiecobbs commented Dec 16, 2024

openjdk bot commented Dec 16, 2024

openjdk bot commented Dec 16, 2024

archiecobbs commented Nov 2, 2024 •

edited by openjdk bot

Loading

openjdk bot commented Nov 2, 2024 •

edited

Loading

mlbridge bot commented Nov 2, 2024 •

edited

Loading