8343478: Remove unnecessary @SuppressWarnings annotations (core-libs)

[archiecobbs]

Please review this patch which removes unnecessary @SuppressWarnings annotations.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 2 Reviewers)

Issue

• JDK-8343478: Remove unnecessary @SuppressWarnings annotations (core-libs) (Sub-task - P5)

Reviewers

• Joe Darcy (@jddarcy - Reviewer)
• Joe Wang (@JoeWang-Java - Reviewer) Review applies to 2049463f
• Alexey Semenyuk (@alexeysemenyukoracle - Reviewer)

Reviewers without OpenJDK IDs

• @pcoperatr (no known openjdk.org user name / role) Review applies to 2049463f

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21852/head:pull/21852
$ git checkout pull/21852

Update a local copy of the PR:
$ git checkout pull/21852
$ git pull https://git.openjdk.org/jdk.git pull/21852/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21852

View PR using the GUI difftool:
$ git pr show -t 21852

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21852.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back acobbs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@archiecobbs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8343478: Remove unnecessary @SuppressWarnings annotations (core-libs)

Reviewed-by: darcy, asemenyuk, joehw

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 231 new commits pushed to the master branch:

• 3230894: 8348561: Add aarch64 intrinsics for ML-DSA
• 8073914: 8350974: The os_cpu VM_STRUCTS, VM_TYPES, etc have no declarations and should be removed
• 7ee89a5: 8350893: Use generated names for hand generated opto runtime blobs
• fae37aa: 8345627: [REDO] Use gcc12 -ftrivial-auto-var-init=pattern in debug builds
• 1f10ffb: 8350851: ZGC: Reduce size of ZAddressOffsetMax scaling data structures
• 4fc72b8: 8351082: Remove dead code for estimating CDS archive size
• b6e2d66: 8351087: Combine scratch object tables in heapShared.cpp
• d9b98f7: 8350771: Fix -Wzero-as-null-pointer-constant warning in nsk/monitoring ThreadController utility
• 7c173fd: 8351077: Shenandoah: Update comments in ShenandoahConcurrentGC::op_reset_after_collect
• 96613cc: 8349516: StAXStream2SAX.handleCharacters() fails on empty CDATA
• ... and 221 more: https://git.openjdk.org/jdk/compare/ba28119642a7cfa850707a01ce8e589c3a80d416...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@archiecobbs The following labels will be automatically applied to this pull request:

• build
• compiler
• core-libs
• i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 11: Full (340ca514)
• 10: Full - Incremental (2049463f)
• 09: Full - Incremental (1102421d)
• 08: Full (40b143c0)
• 07: Full (ee2862e5)
• 06: Full (1905d6e3)
• 05: Full - Incremental (378ca601)
• 04: Full (300c0f98)
• 03: Full - Incremental (9137373f)
• 02: Full - Incremental (a64d5594)
• 01: Full - Incremental (7842dfea)
• 00: Full (9cef2ae6)

[magicus]

/label -build

[openjdk]

@magicus
The build label was successfully removed.

[liach]

java.lang.invoke/reflect and jdk.internal.classfile changes look good.

[openjdk]

@archiecobbs this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout SuppressWarningsCleanup-core-libs
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

[alexeysemenyukoracle]

jpackage looks good. Thank you!

[naotoj]

Changes related to i18n look good. Looks like some files in java.desktop package are also modified. Just wondering they may not be seen by client folks as the title mentions core-libs.

[archiecobbs]

Looks like some files in java.desktop package are also modified. Just wondering they may not be seen by client folks as the title mentions core-libs.

Yeah my attempt to split this up was not perfect. I did have a separate, earlier PR (#21850) for the client label stuff, but somehow some of it still spilled over into this one... bleh.

But this is easy to fix - I am going to revert the changes under src/java.desktop and put them into a new PR (#22906). Thanks for the prodding.

[JoeWang-Java]

java.xml changes look good. Please note though, the @lastmodified tag needs to be updated as well.

[archiecobbs]

java.xml changes look good. Please note though, the @lastmodified tag needs to be updated as well.

Thanks, didn't know about those. Should be fixed in 2049463.

[archiecobbs]

@jddarcy , thanks for your previous review. A few changes have been added since then so would you mind updating your review? Also, can you confirm all necessary reviews have been made? This covers several areas so want to double-check. Thanks.

[bridgekeeper]

@archiecobbs This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[jddarcy]

The changes in java.base look fine.

[alexeysemenyukoracle]

jpackage looks good

[archiecobbs]

Thanks for the reviews!

[archiecobbs]

/integrate

[openjdk]

Going to push as commit 661bd5b.
Since your change was applied there have been 253 commits pushed to the master branch:

• 61d9ab9: 8350854: Include thread counts in safepoint logging
• ea9e3cf: 8281511: java/net/ipv6tests/UdpTest.java fails with checkTime failed
• caaf409: 8350546: Several java/net/InetAddress tests fails UnknownHostException
• 062b7c7: 8351115: Test AOTClassLinkingVMOptions.java fails after JDK-8348322
• a88e8cd: 8350952: Remove some non present files from OPT_SPEED_SRC list
• de29ef3: 8343191: Cgroup v1 subsystem fails to set subsystem path
• 75f028b: 8348657: compiler/loopopts/superword/TestEquivalentInvariants.java timed out
• b1a21b5: 8351101: RISC-V: C2: Small improvement to MacroAssembler::revb
• 62fa33a: 8351158: Incorrect APX EGPR register save ordering
• 20ea218: 8336042: Caller/callee param size mismatch in deoptimization causes crash
• ... and 243 more: https://git.openjdk.org/jdk/compare/ba28119642a7cfa850707a01ce8e589c3a80d416...master

Your commit was automatically rebased without conflicts.

[openjdk]

@archiecobbs Pushed as commit 661bd5b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.