Skip to content

8343480: Remove unnecessary @SuppressWarnings annotations (javadoc) #21854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

archiecobbs
Copy link
Contributor

@archiecobbs archiecobbs commented Nov 2, 2024

Please review this patch which removes unnecessary @SuppressWarnings annotations.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8343480: Remove unnecessary @SuppressWarnings annotations (javadoc) (Bug - P5)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21854/head:pull/21854
$ git checkout pull/21854

Update a local copy of the PR:
$ git checkout pull/21854
$ git pull https://git.openjdk.org/jdk.git pull/21854/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21854

View PR using the GUI difftool:
$ git pr show -t 21854

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21854.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 2, 2024

👋 Welcome back acobbs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 2, 2024

@archiecobbs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8343480: Remove unnecessary @SuppressWarnings annotations (javadoc)

Reviewed-by: hannesw

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 38 new commits pushed to the master branch:

  • 16feeb7: 8343547: Restore accidentally removed annotations in LambdaForm from ClassFile API port
  • f62fc48: 8342498: Add test for Allocation elimination after use as alignment reference by SuperWord
  • f3671be: 8335392: C2 MergeStores: enhanced pointer parsing
  • 4fc6d41: 8341194: [REDO] Implement C2 VectorizedHashCode on AArch64
  • abf2dc7: 8343298: Improve stability of runtime/cds/DeterministicDump.java test
  • dafa2e5: 8343124: Tests fails with java.lang.IllegalAccessException: class com.sun.javatest.regtest.agent.MainWrapper$MainTask cannot access
  • 0f7dd98: 8251926: PPC: Remove an unused variable in assembler_ppc.cpp
  • cd91a44: 8343549: SeededSecureRandomTest needn't be in a package
  • 20f3aaf: 8343471: RISC-V: compiler/cpuflags/TestAESIntrinsicsOnUnsupportedConfig.java fails after JDK-8334999
  • 67907d5: 8343500: Optimize ArrayClassDescImpl computeDescriptor
  • ... and 28 more: https://git.openjdk.org/jdk/compare/29882bfe7b7e76446a96862cd0a5e81c7e054415...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 2, 2024
@openjdk
Copy link

openjdk bot commented Nov 2, 2024

@archiecobbs The following label will be automatically applied to this pull request:

  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the javadoc javadoc-dev@openjdk.org label Nov 2, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 2, 2024

Webrevs

Copy link
Member

@hns hns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I wondered about one of these annotations a short while ago. Looks good to me.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 5, 2024
@archiecobbs
Copy link
Contributor Author

Thanks for the quick review.

@archiecobbs
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 5, 2024

Going to push as commit fbf9b96.
Since your change was applied there have been 43 commits pushed to the master branch:

  • f95097c: 8343482: Remove unnecessary @SuppressWarnings annotations (net)
  • c799cad: 8343486: Remove unnecessary @SuppressWarnings annotations and -Xlint:-foo options
  • 0b733e9: 8336874: WhiteBoxAPI: assert(!method->is_abstract() && (osr_bci == InvocationEntryBci || !method->is_native())) failed: cannot compile abstract/native methods
  • 5890d94: 8333893: Optimization for StringBuilder append boolean & null
  • c33a8f5: 8343314: Move common properties from jpackage jtreg test declarations to TEST.properties file
  • 16feeb7: 8343547: Restore accidentally removed annotations in LambdaForm from ClassFile API port
  • f62fc48: 8342498: Add test for Allocation elimination after use as alignment reference by SuperWord
  • f3671be: 8335392: C2 MergeStores: enhanced pointer parsing
  • 4fc6d41: 8341194: [REDO] Implement C2 VectorizedHashCode on AArch64
  • abf2dc7: 8343298: Improve stability of runtime/cds/DeterministicDump.java test
  • ... and 33 more: https://git.openjdk.org/jdk/compare/29882bfe7b7e76446a96862cd0a5e81c7e054415...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 5, 2024
@openjdk openjdk bot closed this Nov 5, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 5, 2024
@openjdk
Copy link

openjdk bot commented Nov 5, 2024

@archiecobbs Pushed as commit fbf9b96.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated javadoc javadoc-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants