8343491: javax/management/remote/mandatory/connection/DeadLockTest.java failing with NoSuchObjectException: no such object in table

[kevinjwalls]

This test is sensitive to timing, and should not run with -Xcomp (like NotifReconnectDeadlockTest.java).

With -Xcomp, this test can fail on the the conn.getDefaultDomain() call, but if we handle that, it can also fail on the first iteration through the loop, at the call: JMXConnector client = JMXConnectorFactory.connect(addr, env);

This test sets a short timeout value for connections, and -Xcomp slows things down greatly. RMI is gone before the connection is established.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8343491: javax/management/remote/mandatory/connection/DeadLockTest.java failing with NoSuchObjectException: no such object in table (Bug - P4)

Reviewers

• Leonid Mesnik (@lmesnik - Reviewer)
• Serguei Spitsyn (@sspitsyn - Reviewer)
• Chris Plummer (@plummercj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21884/head:pull/21884
$ git checkout pull/21884

Update a local copy of the PR:
$ git checkout pull/21884
$ git pull https://git.openjdk.org/jdk.git pull/21884/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21884

View PR using the GUI difftool:
$ git pr show -t 21884

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21884.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back kevinw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@kevinjwalls This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8343491: javax/management/remote/mandatory/connection/DeadLockTest.java failing with NoSuchObjectException: no such object in table

Reviewed-by: lmesnik, sspitsyn, cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 66 new commits pushed to the master branch:

• 56c588b: 8343417: (fs) BasicFileAttributeView.setTimes uses microsecond precision with NOFOLLOW_LINKS
• d3c042f: 8343770: Build fails due to use of sun.misc.Unsafe in LoopOverRandom
• 1d117f6: 8343394: Make MemorySessionImpl.state a stable field
• d2b681d: 8343730: JMX cleanups
• ac82a8f: 8343610: InOutPathTest jpackage test produces invalid app image on macOS
• f0b251d: 8343531: Improve print_location for invalid heap pointers
• 4244682: 8339190: Parameter arrays that are capped during annotation processing report incorrect length
• 7620b12: 8323803: ConstantOopReadValue::print_on should print 'null' instead of 'nullptr'
• 592a48b: 8321997: Increase upper limit of LoopOptsCount flag
• c3df050: 8343726: [BACKOUT] NMT should not use ThreadCritical
• ... and 56 more: https://git.openjdk.org/jdk/compare/8d6cfba37fe641e35886fdba536f5b2f1709e87b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@kevinjwalls The following labels will be automatically applied to this pull request:

• jmx
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (e389e2ed)

[plummercj]

What changed that caused it to suddenly start failing a lot?

[kevinjwalls]

What changed that caused it to suddenly start failing a lot?

This is the test I changed recently in JDK-8343378 -- it used to not fail even if it threw an Exception. So I make that change, test, and see no failures. But of course -Xcomp testing comes around in tier8 and that can fail... Test sets a short connection timeout so is very timing-sensitive...

(I've now linked the bugs.)

[sspitsyn]

Looks good.

[plummercj]

Ok. Looks good.

[kevinjwalls]

Thanks for the reviews!

[kevinjwalls]

/integrate

[openjdk]

Going to push as commit 4f5a241.
Since your change was applied there have been 66 commits pushed to the master branch:

• 56c588b: 8343417: (fs) BasicFileAttributeView.setTimes uses microsecond precision with NOFOLLOW_LINKS
• d3c042f: 8343770: Build fails due to use of sun.misc.Unsafe in LoopOverRandom
• 1d117f6: 8343394: Make MemorySessionImpl.state a stable field
• d2b681d: 8343730: JMX cleanups
• ac82a8f: 8343610: InOutPathTest jpackage test produces invalid app image on macOS
• f0b251d: 8343531: Improve print_location for invalid heap pointers
• 4244682: 8339190: Parameter arrays that are capped during annotation processing report incorrect length
• 7620b12: 8323803: ConstantOopReadValue::print_on should print 'null' instead of 'nullptr'
• 592a48b: 8321997: Increase upper limit of LoopOptsCount flag
• c3df050: 8343726: [BACKOUT] NMT should not use ThreadCritical
• ... and 56 more: https://git.openjdk.org/jdk/compare/8d6cfba37fe641e35886fdba536f5b2f1709e87b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@kevinjwalls Pushed as commit 4f5a241.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.