Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8260272: bash configure --prefix does not work after JDK-8257679 #2189

Closed
wants to merge 1 commit into from

Conversation

dongbohe
Copy link
Member

@dongbohe dongbohe commented Jan 22, 2021

$ bash configure --prefix=/home/hedongbo/jdk-release
$ make install
...
Creating CDS archive for jdk image
Creating CDS-NOCOOPS archive for jdk image
Installing jdk image into /jvm/openjdk-17-internal
and creating 60 links from /bin into the jdk.
/bin/mkdir: cannot create directory '/jvm': Permission denied
make[3]: *** [install] Error 1
Install.gmk:36: recipe for target 'install' failed
make/Main.gmk:786: recipe for target 'install' failed
make[2]: *** [install] Error 2

ERROR: Build failed for target 'install' in configuration 'linux-x86_64-server-release' (exit code 2)
Stopping sjavac server

=== Make failed targets repeated here ===
Install.gmk:36: recipe for target 'install' failed
make/Main.gmk:786: recipe for target 'install' failed
=== End of repeated output ===

Hint: Try searching the build log for the name of the first failed target.
Hint: See doc/building.html#troubleshooting for assistance.

/home/hedongbo/myprojects/github/jdk.bak/make/Init.gmk:310: recipe for target 'main' failed
make[1]: *** [main] Error 2
/home/hedongbo/myprojects/github/jdk.bak/make/Init.gmk:186: recipe for target 'install' failed
make: *** [install] Error 2

The reason is that the prefix variable used in make/autoconf/util_paths.m4 conflicts with the prefix used in make/autoconf/spec.gmk.in:780.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8260272: bash configure --prefix does not work after JDK-8257679

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2189/head:pull/2189
$ git checkout pull/2189

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 22, 2021

👋 Welcome back dongbohe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 22, 2021

@dongbohe The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added build build-dev@openjdk.org rfr Pull request is ready for review labels Jan 22, 2021
@mlbridge
Copy link

mlbridge bot commented Jan 22, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 22, 2021

@dongbohe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260272: bash configure --prefix does not work after JDK-8257679

Reviewed-by: erikj, ihse

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 40 new commits pushed to the master branch:

  • c52c6c6: 8260273: DataOutputStream writeChars optimization
  • 535c292: 8260306: Do not include osThread.hpp in thread.hpp
  • 06348df: 8259776: Remove ParallelGC non-CAS oldgen allocation
  • 6c4c96f: 8258742: Move PtrQueue reset to PtrQueueSet subclasses
  • b53d5ca: 8260315: Typo "focul" instead of "focus" in FocusSpec.html
  • f624dba: 8240247: No longer need to wrap files with contentContainer
  • 5cdcce1: 8260307: Do not include method.hpp in frame.hpp
  • 6f2a394: Merge
  • 685c03d: 8259271: gc/parallel/TestDynShrinkHeap.java still fails "assert(covered_region.contains(new_memregion)) failed: new region is not in covered_region"
  • d90e06a: 8259775: [Vector API] Incorrect code-gen for VectorReinterpret operation
  • ... and 30 more: https://git.openjdk.java.net/jdk/compare/c3c6662528311d3fd3f29bb0131fc5cfd832183c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@erikj79, @magicus) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 22, 2021
@dongbohe
Copy link
Member Author

dongbohe commented Jan 25, 2021

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 25, 2021
@openjdk
Copy link

openjdk bot commented Jan 25, 2021

@dongbohe
Your change (at version 987837e) is now ready to be sponsored by a Committer.

@RealFYang
Copy link
Member

RealFYang commented Jan 25, 2021

/sponsor

@openjdk openjdk bot closed this Jan 25, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 25, 2021
@openjdk
Copy link

openjdk bot commented Jan 25, 2021

@RealFYang @dongbohe Since your change was applied there have been 41 commits pushed to the master branch:

  • 4ae39b1: 8260208: Improve dummy object filling condition in G1CollectedHeap::fill_archive_regions in cds
  • c52c6c6: 8260273: DataOutputStream writeChars optimization
  • 535c292: 8260306: Do not include osThread.hpp in thread.hpp
  • 06348df: 8259776: Remove ParallelGC non-CAS oldgen allocation
  • 6c4c96f: 8258742: Move PtrQueue reset to PtrQueueSet subclasses
  • b53d5ca: 8260315: Typo "focul" instead of "focus" in FocusSpec.html
  • f624dba: 8240247: No longer need to wrap files with contentContainer
  • 5cdcce1: 8260307: Do not include method.hpp in frame.hpp
  • 6f2a394: Merge
  • 685c03d: 8259271: gc/parallel/TestDynShrinkHeap.java still fails "assert(covered_region.contains(new_memregion)) failed: new region is not in covered_region"
  • ... and 31 more: https://git.openjdk.java.net/jdk/compare/c3c6662528311d3fd3f29bb0131fc5cfd832183c...master

Your commit was automatically rebased without conflicts.

Pushed as commit 764111f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org integrated Pull request has been integrated
4 participants