8339892: Several security shell tests don't set TESTJAVAOPTS

[SoniaZaldana]

Hi all,

This PR addresses 8339892 enabling several security shell tests to set TESTJAVAOPTS.

Cheers,
Sonia

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8339892: Several security shell tests don't set TESTJAVAOPTS (Sub-task - P4)

Reviewers

• Valerie Peng (@valeriepeng - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21916/head:pull/21916
$ git checkout pull/21916

Update a local copy of the PR:
$ git checkout pull/21916
$ git pull https://git.openjdk.org/jdk.git pull/21916/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21916

View PR using the GUI difftool:
$ git pr show -t 21916

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21916.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back szaldana! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@SoniaZaldana This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8339892: Several security shell tests don't set TESTJAVAOPTS

Reviewed-by: valeriep

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

• e33dc13: 8343343: Misc crash dump improvements on more platforms after JDK-8294160
• d20ccd1: 8335583: Avoid using pointers in CDS tables
• 342fe42: 8342270: Test sun/security/pkcs11/Provider/RequiredMechCheck.java needs write access to src tree
• 78b378a: 8342540: InterfaceCalls micro-benchmark gives misleading results
• c0e6c3b: 8343214: Fix encoding errors in APX New Data Destination Instructions Support
• 0be7118: 8279016: JFR Leak Profiler is broken with Shenandoah
• 6811a11: 8341408: Implement JEP 488: Primitive Types in Patterns, instanceof, and switch (Second Preview)
• 72a45dd: 8341834: C2 compilation fails with "bad AD file" due to Replicate
• 57c3bb6: 8343068: C2: CastX2P Ideal transformation not always applied
• 83f3d42: 8339303: C2: dead node after failing to match cloned address expression
• ... and 10 more: https://git.openjdk.org/jdk/compare/3fab8e37bbebbb3930108b2015efe488b1fa1e97...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@SoniaZaldana The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (c6b39cef)

[valeriepeng]

Looks fine to me. Thanks~

[SoniaZaldana]

Thanks @valeriepeng!

[SoniaZaldana]

/integrate

[openjdk]

Going to push as commit 8a2a75e.
Since your change was applied there have been 99 commits pushed to the master branch:

• 50b6e41: 8300732: Whitebox functions for Metaspace test should use byte size
• 67d1ef1: 8344018: Remove unlimited memory setting from TestScalarReplacementMaxLiveNodes
• 5729227: 8343250: ArrayBlockingQueue serialization not thread safe
• 2c1e4c3: 8343600: RISC-V: enable CRC32 intrinsic when either Zba or RVV are supported
• 3727f40: 8343745: Only update Last Value Assertion Predicates in Loop Unrolling
• b53ee05: 8202617: javadoc generates broken links to undocumented (e.g. private) members
• cfe719f: 8340565: Create separate index page for terms defined by the index tag
• baabfbb: 8341904: Search tag in inherited doc comment creates additional index item
• 4fa760a: 8343936: Adjust timeout in test javax/management/monitor/DerivedGaugeMonitorTest.java
• cbf4dd5: 8343555: RISC-V: make some verified (on hardware) extension options diagnostic
• ... and 89 more: https://git.openjdk.org/jdk/compare/3fab8e37bbebbb3930108b2015efe488b1fa1e97...master

Your commit was automatically rebased without conflicts.

[openjdk]

@SoniaZaldana Pushed as commit 8a2a75e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.