Skip to content

Conversation

@Renjithkannath
Copy link
Contributor

@Renjithkannath Renjithkannath commented Nov 6, 2024

Hi Reviewers,

I have added the test tag @requires os.family != "mac" and updated section with new format.
Removed OSX check condition form the code.

Please review and let me know your suggestions if any.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8342541: Exclude List/KeyEventsTest/KeyEventsTest.java from running on macOS (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21924/head:pull/21924
$ git checkout pull/21924

Update a local copy of the PR:
$ git checkout pull/21924
$ git pull https://git.openjdk.org/jdk.git pull/21924/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21924

View PR using the GUI difftool:
$ git pr show -t 21924

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21924.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 6, 2024

👋 Welcome back rkannathpari! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 6, 2024

@Renjithkannath This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8342541: Exclude List/KeyEventsTest/KeyEventsTest.java from running on macOS

Reviewed-by: aivanov, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 286 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@aivanov-jdk, @prrace) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 6, 2024
@openjdk
Copy link

openjdk bot commented Nov 6, 2024

@Renjithkannath The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Nov 6, 2024
@Renjithkannath Renjithkannath changed the title 8342541 :Exclude List/KeyEventsTest/KeyEventsTest.java from running on macOS 8342541 : Exclude List/KeyEventsTest/KeyEventsTest.java from running on macOS Nov 6, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 6, 2024

Webrevs

@Renjithkannath Renjithkannath changed the title 8342541 : Exclude List/KeyEventsTest/KeyEventsTest.java from running on macOS JDK-8342541: Exclude List/KeyEventsTest/KeyEventsTest.java from running on macOS Nov 6, 2024
@Renjithkannath Renjithkannath changed the title JDK-8342541: Exclude List/KeyEventsTest/KeyEventsTest.java from running on macOS 8342541: Exclude List/KeyEventsTest/KeyEventsTest.java from running on macOS Nov 6, 2024
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 12, 2024
@Renjithkannath
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 12, 2024
@openjdk
Copy link

openjdk bot commented Nov 12, 2024

@Renjithkannath
Your change (at version f16a550) is now ready to be sponsored by a Committer.

@prrace
Copy link
Contributor

prrace commented Nov 19, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 19, 2024

Going to push as commit bb7a840.
Since your change was applied there have been 286 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 19, 2024
@openjdk openjdk bot closed this Nov 19, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 19, 2024
@openjdk
Copy link

openjdk bot commented Nov 19, 2024

@prrace @Renjithkannath Pushed as commit bb7a840.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@Renjithkannath Renjithkannath deleted the 8342541-v1 branch April 8, 2025 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants