8340416: Remove ArchiveBuilder::estimate_archive_size()

[SoniaZaldana]

Hi folks,

This PR removes ArchiveBuilder::estimate_archive_size() per the issues raised in JDK-8340416.

Thanks!
Sonia

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8340416: Remove ArchiveBuilder::estimate_archive_size() (Enhancement - P4)

Reviewers

• Ioi Lam (@iklam - Reviewer)
• Calvin Cheung (@calvinccheung - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21931/head:pull/21931
$ git checkout pull/21931

Update a local copy of the PR:
$ git checkout pull/21931
$ git pull https://git.openjdk.org/jdk.git pull/21931/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21931

View PR using the GUI difftool:
$ git pr show -t 21931

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21931.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back szaldana! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@SoniaZaldana This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8340416: Remove ArchiveBuilder::estimate_archive_size()

Reviewed-by: iklam, ccheung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 43 new commits pushed to the master branch:

• be1cdd9: 8344140: Refactor the discovery of AOT cache artifacts
• 973c630: 8342466: Improve API documentation for java.lang.classfile.attribute
• 9782bfd: 8347620: Shenandoah: Use 'free' tag for free set related logging
• 35be4a4: 8347173: java/net/DatagramSocket/InterruptibleDatagramSocket.java fails with virtual thread factory
• 36b7abd: 8225763: Inflater and Deflater should implement AutoCloseable
• d6d45c6: 8303884: jlink --add-options plugin does not allow GNU style options to be provided
• 0ee6ba9: 8347596: Update HSS/LMS public key encoding
• ec2aaaa: 8326236: assert(ce != nullptr) failed in Continuation::continuation_bottom_sender
• 02d2493: 8347613: Remove leftover doPrivileged call in Currency test: CheckDataVersion.java
• 10d08db: 8346142: [perf] scalability issue for the specjvm2008::xml.validation workload
• ... and 33 more: https://git.openjdk.org/jdk/compare/a7915bb2e1b822b6d9cbeb220765e8c821c71d0b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@SoniaZaldana The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (b5893847)
• 01: Full (9f1dc40b)
• 00: Full (137c8556)

[bridgekeeper]

@SoniaZaldana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[openjdk]

@SoniaZaldana this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout JDK-8340416
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

[bridgekeeper]

@SoniaZaldana This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[iklam]

CompressedClassSpaceSize is 1G by default. On 32-bit platforms, it may be difficult to reserve that much space. I think we should do this:

size_t buffer_size = LP64_ONLY() NOT_LP64(256 * M);

The 256M size is close to how much we were reserving on 32-bit.

[SoniaZaldana]

Thanks @iklam ! I made the changes.

[SoniaZaldana]

/open

[openjdk]

@SoniaZaldana This pull request is now open

[iklam]

Please remove these members from ArchiveBuilder as well.

  // Conservative estimate for number of bytes needed for:
  size_t _estimated_metaspaceobj_bytes;   // all archived MetaspaceObj's.
  size_t _estimated_hashtable_bytes;     // symbol table and dictionaries
  ...
  void verify_estimate_size(size_t estimate, const char* which);

[SoniaZaldana]

Hi @iklam

Please remove these members from ArchiveBuilder as well.

  // Conservative estimate for number of bytes needed for:
  size_t _estimated_metaspaceobj_bytes;   // all archived MetaspaceObj's.
  size_t _estimated_hashtable_bytes;     // symbol table and dictionaries
  ...
  void verify_estimate_size(size_t estimate, const char* which);

Thanks for the pointer! I took a closer look at ArchiveBuilder::verify_estimate_size and I think we can delete a few other members.

address _last_verified_top;
size_t _other_region_used_bytes;

They appear to only be set in preparation for verify_estimate_size.

Thanks!

[iklam]

Looks good to me. I ran tiers 1-4 and builds-tier5 on our CI and all tests passed.

[iklam]

/reviewers 2

[openjdk]

@iklam
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

[calvinccheung]

Looks good. Thanks!

[SoniaZaldana]

/integrate

[SoniaZaldana]

Thank you for the reviews! @calvinccheung @iklam

[openjdk]

Going to push as commit 254e840.
Since your change was applied there have been 54 commits pushed to the master branch:

• 8193ba3: 8347562: javac crash due to type vars in permits clause
• 7df21a8: 8347597: HttpClient: improve exception reporting when closing connection
• b0e2be6: 8347729: Replace SIZE_FORMAT in parallel and serial gc
• d4e5ec2: 8346610: Make all imports consistent in the FFM API
• c36200b: 8347721: Replace SIZE_FORMAT in compiler directories
• af3f5d8: 8347039: ThreadPerTaskExecutor terminates if cancelled tasks still running
• 91197b3: 8347531: The signal tests are failing after JDK-8345782 due to an unrelated warning
• 4f3dc9d: 8347352: RISC-V: Cleanup bitwise AND assembler routines
• afc4529: 8346834: Tests failing with -XX:+UseNUMA due to "NUMA support disabled" warning
• a3be97e: 8347761: Test tools/jimage/JImageExtractTest.java fails after JDK-8303884
• ... and 44 more: https://git.openjdk.org/jdk/compare/a7915bb2e1b822b6d9cbeb220765e8c821c71d0b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@SoniaZaldana Pushed as commit 254e840.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.