Skip to content

Conversation

@alexeysemenyukoracle
Copy link
Member

@alexeysemenyukoracle alexeysemenyukoracle commented Nov 6, 2024

Use internal jdk API instead of parsing JVM properties where appropriate in jpackage tests


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8343396: Use OperatingSystem, Architecture, and OSVersion in jpackage tests (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21940/head:pull/21940
$ git checkout pull/21940

Update a local copy of the PR:
$ git checkout pull/21940
$ git pull https://git.openjdk.org/jdk.git pull/21940/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21940

View PR using the GUI difftool:
$ git pr show -t 21940

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21940.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 6, 2024

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 6, 2024

@alexeysemenyukoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8343396: Use OperatingSystem, Architecture, and OSVersion in jpackage tests

Reviewed-by: rriggs, almatvee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 49 new commits pushed to the master branch:

  • 84c99fb: 8283664: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/PrintTextTest.java
  • 2c7bea1: 8343772: Expected IAPE not thrown in KDF.getInstance (TCK)
  • fac89f4: 8343493: Perform module checks during MetaspaceShared::map_archives()
  • ccda815: 8342303: Segfault in update_inherited_vtable: AppCDS, old bytecode, and redefineClasses
  • 4f5a241: 8343491: javax/management/remote/mandatory/connection/DeadLockTest.java failing with NoSuchObjectException: no such object in table
  • 56c588b: 8343417: (fs) BasicFileAttributeView.setTimes uses microsecond precision with NOFOLLOW_LINKS
  • d3c042f: 8343770: Build fails due to use of sun.misc.Unsafe in LoopOverRandom
  • 1d117f6: 8343394: Make MemorySessionImpl.state a stable field
  • d2b681d: 8343730: JMX cleanups
  • ac82a8f: 8343610: InOutPathTest jpackage test produces invalid app image on macOS
  • ... and 39 more: https://git.openjdk.org/jdk/compare/c33a8f52b613e5eff02f572eda876cbbfc7c22cf...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Nov 6, 2024

@alexeysemenyukoracle The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Nov 6, 2024
@alexeysemenyukoracle alexeysemenyukoracle marked this pull request as ready for review November 7, 2024 12:31
@alexeysemenyukoracle
Copy link
Member Author

@sashamatveev ptal

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 7, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 7, 2024

Webrevs

Copy link
Contributor

@RogerRiggs RogerRiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 7, 2024
Copy link
Member

@sashamatveev sashamatveev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@alexeysemenyukoracle
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 7, 2024

Going to push as commit a63f501.
Since your change was applied there have been 49 commits pushed to the master branch:

  • 84c99fb: 8283664: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/PrintTextTest.java
  • 2c7bea1: 8343772: Expected IAPE not thrown in KDF.getInstance (TCK)
  • fac89f4: 8343493: Perform module checks during MetaspaceShared::map_archives()
  • ccda815: 8342303: Segfault in update_inherited_vtable: AppCDS, old bytecode, and redefineClasses
  • 4f5a241: 8343491: javax/management/remote/mandatory/connection/DeadLockTest.java failing with NoSuchObjectException: no such object in table
  • 56c588b: 8343417: (fs) BasicFileAttributeView.setTimes uses microsecond precision with NOFOLLOW_LINKS
  • d3c042f: 8343770: Build fails due to use of sun.misc.Unsafe in LoopOverRandom
  • 1d117f6: 8343394: Make MemorySessionImpl.state a stable field
  • d2b681d: 8343730: JMX cleanups
  • ac82a8f: 8343610: InOutPathTest jpackage test produces invalid app image on macOS
  • ... and 39 more: https://git.openjdk.org/jdk/compare/c33a8f52b613e5eff02f572eda876cbbfc7c22cf...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 7, 2024
@openjdk openjdk bot closed this Nov 7, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 7, 2024
@openjdk
Copy link

openjdk bot commented Nov 7, 2024

@alexeysemenyukoracle Pushed as commit a63f501.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@alexeysemenyukoracle alexeysemenyukoracle deleted the JDK-8343396 branch November 7, 2024 22:34
@alexeysemenyukoracle alexeysemenyukoracle restored the JDK-8343396 branch November 9, 2024 23:06
@alexeysemenyukoracle alexeysemenyukoracle deleted the JDK-8343396 branch November 9, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants