8343804: Show the default time zone with -XshowSettings option

[naotoj]

A small enhancement in the Java launcher. For diagnostic purposes, display the default time zone ID with the -XshowSettings option.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8343804: Show the default time zone with -XshowSettings option (Enhancement - P4)

Reviewers

• Iris Clark (@irisclark - Reviewer)
• Jaikiran Pai (@jaikiran - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21965/head:pull/21965
$ git checkout pull/21965

Update a local copy of the PR:
$ git checkout pull/21965
$ git pull https://git.openjdk.org/jdk.git pull/21965/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21965

View PR using the GUI difftool:
$ git pr show -t 21965

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21965.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back naoto! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@naotoj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8343804: Show the default time zone with -XshowSettings option

Reviewed-by: iris, jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 163 new commits pushed to the master branch:

• 068f4ce: 8343293: Remove the check for /jre/lib/libjava.dylib from the launcher's java_md_macosx.m
• f621f26: 8343724: [PPC64] Disallow OptoScheduling
• a63f501: 8343396: Use OperatingSystem, Architecture, and OSVersion in jpackage tests
• 84c99fb: 8283664: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/PrintTextTest.java
• 2c7bea1: 8343772: Expected IAPE not thrown in KDF.getInstance (TCK)
• fac89f4: 8343493: Perform module checks during MetaspaceShared::map_archives()
• ccda815: 8342303: Segfault in update_inherited_vtable: AppCDS, old bytecode, and redefineClasses
• 4f5a241: 8343491: javax/management/remote/mandatory/connection/DeadLockTest.java failing with NoSuchObjectException: no such object in table
• 56c588b: 8343417: (fs) BasicFileAttributeView.setTimes uses microsecond precision with NOFOLLOW_LINKS
• d3c042f: 8343770: Build fails due to use of sun.misc.Unsafe in LoopOverRandom
• ... and 153 more: https://git.openjdk.org/jdk/compare/d49f21043b84ebcc8b9176de3a84621ca7bca8fb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@naotoj The following labels will be automatically applied to this pull request:

• core-libs
• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (4255c80f)

[irisclark]

Nice RFE.

[jaikiran]

Hello Naoto, this looks good to me. The test itself could assert that the printed timezone is indeed the default timezone, but if you prefer it in its current form, that's fine too.

[naotoj]

Hello Naoto, this looks good to me. The test itself could assert that the printed timezone is indeed the default timezone, but if you prefer it in its current form, that's fine too.

Thank you, Jai. I considererd that too, i.e. affirming the actual tz value. I decided not to do it aligning with other tests that do not affirm their values either.

[naotoj]

Thank you for your reviews!
/integrate

[openjdk]

Going to push as commit 0329855.
Since your change was applied there have been 177 commits pushed to the master branch:

• 44ec501: 8305895: Implement JEP 450: Compact Object Headers (Experimental)
• 6053962: 8343684: Test KDFDelayedProviderSyncTest.java intermittent fails didn't finish within the time-out 150
• 2fb0c1d: 8343844: Add benchmarks for superword/autovectorization in FFM BulkOperations
• 72f67fb: 8343411: Test fail on Windows due to "An established connection was aborted by the software in your host machine"
• 7d6a2f3: 8342860: Fix more NULL usage backsliding
• f6edfe5: 8343506: [s390x] multiple test failures with ubsan
• 96eed7f: 8343306: javac is failing to determine if a class and a sealed interface are disjoint
• 0c281ac: 8343754: Problemlist jdk/jfr/event/oldobject/TestShenandoah.java after JDK-8279016
• 2e58ede: 8341399: Add since checker tests to the langtools modules
• c7f071c: 8343189: [REDO] JDK-8295269 G1: Improve slow startup due to predictor initialization
• ... and 167 more: https://git.openjdk.org/jdk/compare/d49f21043b84ebcc8b9176de3a84621ca7bca8fb...master

Your commit was automatically rebased without conflicts.

[openjdk]

@naotoj Pushed as commit 0329855.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.