Skip to content

8343819: Link Float.NaN and Double.NaN to equivalence discussion in Double #21972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

eirbjo
Copy link
Contributor

@eirbjo eirbjo commented Nov 8, 2024

Please review this doc-only enhancement which links the word equivalent in Float.NaN and Double.NaN constant field descriptions to the floating-point equivalence discussion in Double.

It is equivalent to the value returned by{@code Float.intBitsToFloat(0x7fc00000)}.

For readers not well-versed in floating point, it may not be immediatly clear what equivalent to means here.

The smallest improvement I could think of is to simply make the word equivalent a plain link to the floating-point equivalence discussion in the class description of java.lang.Double.

Verification: This is a doc-only change. I ran make docs and verified that the links resolve.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8343819: Link Float.NaN and Double.NaN to equivalence discussion in Double (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21972/head:pull/21972
$ git checkout pull/21972

Update a local copy of the PR:
$ git checkout pull/21972
$ git pull https://git.openjdk.org/jdk.git pull/21972/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21972

View PR using the GUI difftool:
$ git pr show -t 21972

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21972.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 8, 2024

👋 Welcome back eirbjo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 8, 2024

@eirbjo This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8343819: Link Float.NaN and Double.NaN to equivalence discussion in Double

Reviewed-by: darcy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 151 new commits pushed to the master branch:

  • 52c0b09: 8277240: java/awt/Graphics2D/ScaledTransform/ScaledTransform.java dialog does not get disposed
  • 0329855: 8343804: Show the default time zone with -XshowSettings option
  • 44ec501: 8305895: Implement JEP 450: Compact Object Headers (Experimental)
  • 6053962: 8343684: Test KDFDelayedProviderSyncTest.java intermittent fails didn't finish within the time-out 150
  • 2fb0c1d: 8343844: Add benchmarks for superword/autovectorization in FFM BulkOperations
  • 72f67fb: 8343411: Test fail on Windows due to "An established connection was aborted by the software in your host machine"
  • 7d6a2f3: 8342860: Fix more NULL usage backsliding
  • f6edfe5: 8343506: [s390x] multiple test failures with ubsan
  • 96eed7f: 8343306: javac is failing to determine if a class and a sealed interface are disjoint
  • 0c281ac: 8343754: Problemlist jdk/jfr/event/oldobject/TestShenandoah.java after JDK-8279016
  • ... and 141 more: https://git.openjdk.org/jdk/compare/7404ddf24a162cff445cd0a26aec446461988bc8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Nov 8, 2024

@eirbjo The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Nov 8, 2024
@eirbjo eirbjo marked this pull request as ready for review November 8, 2024 10:57
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 8, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 8, 2024

Webrevs

Copy link
Member

@jddarcy jddarcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine; thanks.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 8, 2024
@eirbjo
Copy link
Contributor Author

eirbjo commented Nov 9, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Nov 9, 2024

Going to push as commit 8a69893.
Since your change was applied there have been 151 commits pushed to the master branch:

  • 52c0b09: 8277240: java/awt/Graphics2D/ScaledTransform/ScaledTransform.java dialog does not get disposed
  • 0329855: 8343804: Show the default time zone with -XshowSettings option
  • 44ec501: 8305895: Implement JEP 450: Compact Object Headers (Experimental)
  • 6053962: 8343684: Test KDFDelayedProviderSyncTest.java intermittent fails didn't finish within the time-out 150
  • 2fb0c1d: 8343844: Add benchmarks for superword/autovectorization in FFM BulkOperations
  • 72f67fb: 8343411: Test fail on Windows due to "An established connection was aborted by the software in your host machine"
  • 7d6a2f3: 8342860: Fix more NULL usage backsliding
  • f6edfe5: 8343506: [s390x] multiple test failures with ubsan
  • 96eed7f: 8343306: javac is failing to determine if a class and a sealed interface are disjoint
  • 0c281ac: 8343754: Problemlist jdk/jfr/event/oldobject/TestShenandoah.java after JDK-8279016
  • ... and 141 more: https://git.openjdk.org/jdk/compare/7404ddf24a162cff445cd0a26aec446461988bc8...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 9, 2024
@openjdk openjdk bot closed this Nov 9, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 9, 2024
@openjdk
Copy link

openjdk bot commented Nov 9, 2024

@eirbjo Pushed as commit 8a69893.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants