-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8343819: Link Float.NaN and Double.NaN to equivalence discussion in Double #21972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ssion in Double##equivalenceRelation.
👋 Welcome back eirbjo! A progress list of the required criteria for merging this PR into |
@eirbjo This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 151 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine; thanks.
/integrate |
Going to push as commit 8a69893.
Your commit was automatically rebased without conflicts. |
Please review this doc-only enhancement which links the word equivalent in
Float.NaN
andDouble.NaN
constant field descriptions to the floating-point equivalence discussion inDouble
.For readers not well-versed in floating point, it may not be immediatly clear what equivalent to means here.
The smallest improvement I could think of is to simply make the word
equivalent
a plain link to the floating-point equivalence discussion in the class description ofjava.lang.Double
.Verification: This is a doc-only change. I ran
make docs
and verified that the links resolve.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21972/head:pull/21972
$ git checkout pull/21972
Update a local copy of the PR:
$ git checkout pull/21972
$ git pull https://git.openjdk.org/jdk.git pull/21972/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 21972
View PR using the GUI difftool:
$ git pr show -t 21972
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21972.diff
Using Webrev
Link to Webrev Comment