Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8260306: Do not include osThread.hpp in thread.hpp #2198

Conversation

iklam
Copy link
Member

@iklam iklam commented Jan 22, 2021

thread.hpp is a popular header file (included by 856 out of 1000 HotSpot.o file), so we should try to minimize what files are included by thread.hpp.

We can replace the inclusion of osThread.hpp with a forward declaration of the OSThread class.

This reduces the number of .o files that include osThread.hpp to 42.

Tested with mach5: tier1, builds-tier2, builds-tier3, builds-tier4 and builds-tier5. Also locally: aarch64, arm, ppc64, s390, x86, and zero.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8260306: Do not include osThread.hpp in thread.hpp

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2198/head:pull/2198
$ git checkout pull/2198

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 22, 2021

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 22, 2021

@iklam The following labels will be automatically applied to this pull request:

  • hotspot
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added serviceability serviceability-dev@openjdk.org hotspot hotspot-dev@openjdk.org labels Jan 22, 2021
@iklam
Copy link
Member Author

iklam commented Jan 22, 2021

/label remove serviceability

@openjdk openjdk bot removed the serviceability serviceability-dev@openjdk.org label Jan 22, 2021
@openjdk
Copy link

openjdk bot commented Jan 22, 2021

@iklam
The serviceability label was successfully removed.

@iklam iklam marked this pull request as ready for review January 22, 2021 18:11
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 22, 2021
@mlbridge
Copy link

mlbridge bot commented Jan 22, 2021

Webrevs

Copy link
Contributor

@coleenp coleenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@openjdk
Copy link

openjdk bot commented Jan 22, 2021

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260306: Do not include osThread.hpp in thread.hpp

Reviewed-by: coleenp, lfoltan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 22, 2021
Copy link
Member

@lfoltan lfoltan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Lois

@iklam
Copy link
Member Author

iklam commented Jan 24, 2021

Thanks @lfoltan and @coleenp for the review!
/integrate

@openjdk openjdk bot closed this Jan 24, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 24, 2021
@openjdk
Copy link

openjdk bot commented Jan 24, 2021

@iklam Pushed as commit 535c292.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

mlbridge bot commented Jan 24, 2021

Mailing list message from David Holmes on hotspot-dev:

Hi Ioi,

On 23/01/2021 4:14 am, Ioi Lam wrote:

thread.hpp is a popular header file (included by 856 out of 1000 HotSpot.o file), so we should try to minimize what files are included by thread.hpp.

We can replace the inclusion of osThread.hpp with a forward declaration of the OSThread class.

This reduces the number of .o files that include osThread.hpp to 42.

Seems to me we should provide Thread::native_id() (or something like
that) so that calls to thread->osthread()->thread_id() do not leak out
everywhere. The osThread really should be an internal detail of thread
and the OS-specific code.

Cheers,
David

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
3 participants