Skip to content

8343684: Test KDFDelayedProviderSyncTest.java intermittent fails didn't finish within the time-out 150 #21987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

driverkt
Copy link
Member

@driverkt driverkt commented Nov 8, 2024

JDK-8343684: timeout value not required and is prone to issues with different hardware/threading models


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8343684: Test KDFDelayedProviderSyncTest.java intermittent fails didn't finish within the time-out 150 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21987/head:pull/21987
$ git checkout pull/21987

Update a local copy of the PR:
$ git checkout pull/21987
$ git pull https://git.openjdk.org/jdk.git pull/21987/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21987

View PR using the GUI difftool:
$ git pr show -t 21987

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21987.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 8, 2024

👋 Welcome back kdriver! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 8, 2024

@driverkt This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8343684: Test KDFDelayedProviderSyncTest.java intermittent fails didn't finish within the time-out 150

Reviewed-by: weijun, hchao, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

  • 2fb0c1d: 8343844: Add benchmarks for superword/autovectorization in FFM BulkOperations
  • 72f67fb: 8343411: Test fail on Windows due to "An established connection was aborted by the software in your host machine"
  • 7d6a2f3: 8342860: Fix more NULL usage backsliding
  • f6edfe5: 8343506: [s390x] multiple test failures with ubsan
  • 96eed7f: 8343306: javac is failing to determine if a class and a sealed interface are disjoint
  • 0c281ac: 8343754: Problemlist jdk/jfr/event/oldobject/TestShenandoah.java after JDK-8279016
  • 2e58ede: 8341399: Add since checker tests to the langtools modules
  • c7f071c: 8343189: [REDO] JDK-8295269 G1: Improve slow startup due to predictor initialization
  • a9e53bb: 8343783: Improve asserts in concurrentHashTable.inline.hpp
  • bf5c3ce: 8272780: ServerNotifForwarder.removeNotificationListener() incorrect exception handling
  • ... and 5 more: https://git.openjdk.org/jdk/compare/84c99fb91ffc4bfbc2fb0f20f558603d5660d7f1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 8, 2024
@openjdk
Copy link

openjdk bot commented Nov 8, 2024

@driverkt The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Nov 8, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 8, 2024

Webrevs

Copy link
Contributor

@wangweij wangweij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The timeout seems useless.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 8, 2024
@driverkt
Copy link
Member Author

driverkt commented Nov 8, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Nov 8, 2024

Going to push as commit 6053962.
Since your change was applied there have been 15 commits pushed to the master branch:

  • 2fb0c1d: 8343844: Add benchmarks for superword/autovectorization in FFM BulkOperations
  • 72f67fb: 8343411: Test fail on Windows due to "An established connection was aborted by the software in your host machine"
  • 7d6a2f3: 8342860: Fix more NULL usage backsliding
  • f6edfe5: 8343506: [s390x] multiple test failures with ubsan
  • 96eed7f: 8343306: javac is failing to determine if a class and a sealed interface are disjoint
  • 0c281ac: 8343754: Problemlist jdk/jfr/event/oldobject/TestShenandoah.java after JDK-8279016
  • 2e58ede: 8341399: Add since checker tests to the langtools modules
  • c7f071c: 8343189: [REDO] JDK-8295269 G1: Improve slow startup due to predictor initialization
  • a9e53bb: 8343783: Improve asserts in concurrentHashTable.inline.hpp
  • bf5c3ce: 8272780: ServerNotifForwarder.removeNotificationListener() incorrect exception handling
  • ... and 5 more: https://git.openjdk.org/jdk/compare/84c99fb91ffc4bfbc2fb0f20f558603d5660d7f1...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 8, 2024
@openjdk openjdk bot closed this Nov 8, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 8, 2024
@openjdk
Copy link

openjdk bot commented Nov 8, 2024

@driverkt Pushed as commit 6053962.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@driverkt driverkt deleted the 8343684 branch November 8, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

4 participants