Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8260308: Update LogCompilation junit to 4.13.1 #2199

Closed
wants to merge 1 commit into from

Conversation

@lutkerd
Copy link
Contributor

@lutkerd lutkerd commented Jan 22, 2021

Build and tested on Centos8.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2199/head:pull/2199
$ git checkout pull/2199

@bridgekeeper bridgekeeper bot added the oca label Jan 22, 2021
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 22, 2021

Hi @lutkerd, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user lutkerd" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Jan 22, 2021

⚠️ @lutkerd a branch with the same name as the source branch for this pull request (master) is present in the target repository. If you eventually integrate this pull request then the branch master in your personal fork will diverge once you sync your personal fork with the upstream repository.

To avoid this situation, create a new branch for your changes and reset the master branch. You can do this by running the following commands in a local repository for your personal fork. Note: you do not have to name the new branch NEW-BRANCH-NAME.

$ git checkout -b NEW-BRANCH-NAME
$ git branch -f master 874aef4a8f7ca503591e21333c092d1a969bc5a8
$ git push -f origin master

Then proceed to create a new pull request with NEW-BRANCH-NAME as the source branch and close this one.

@openjdk
Copy link

@openjdk openjdk bot commented Jan 22, 2021

@lutkerd The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@lutkerd
Copy link
Contributor Author

@lutkerd lutkerd commented Jan 22, 2021

/covered

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 22, 2021

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 22, 2021

Webrevs

@iignatev
Copy link
Member

@iignatev iignatev commented Jan 23, 2021

@ericcaspole, as a person who has been involved w/ LogCompilation tool recently, could you please take a look at this PR?

Copy link

@ericcaspole ericcaspole left a comment

Good. Thanks for keeping it up to date.

@openjdk
Copy link

@openjdk openjdk bot commented Jan 25, 2021

@lutkerd This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260308: Update LogCompilation junit to 4.13.1

Reviewed-by: ecaspole, iignatyev

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 28 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@ericcaspole, @iignatev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Jan 25, 2021
@lutkerd
Copy link
Contributor Author

@lutkerd lutkerd commented Jan 25, 2021

/integrate

@openjdk openjdk bot added the sponsor label Jan 25, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 25, 2021

@lutkerd
Your change (at version 47ab822) is now ready to be sponsored by a Committer.

@iignatev
Copy link
Member

@iignatev iignatev commented Jan 25, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Jan 25, 2021

@iignatev @lutkerd Since your change was applied there have been 28 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit ef247ab.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants