8343838: Test EmptyDomainNotificationTest.java fails with ListenerNotFoundException

[kevinjwalls]

Looks like EmptyDomainNotificationTest has been working by accident for nearly 20 years.
Removing notifications when not specifying a domain part of the ObjectName has actually been failing, but calling removeNotificationListener() without a domain has not been sharing the Exception.

ServerNotifForwarder.removeNotificationListener DOES need to add a domain part to an ObjectName that does not have one.

ServerNotifForwarder.addNotificationListener was changed in JDK-6238731, which is what this test is testing.

There is a numeric ID, BUT it still calls removeNotificationListener(ObjectName name, Integer listenerID) it does matter that the ObjectName does not match.

Maybe the failure to record and throw the Exceptions was the reason it was thought the numeric ID made the domain unnecessary.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8343838: Test EmptyDomainNotificationTest.java fails with ListenerNotFoundException (Bug - P3)

Reviewers

• David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21993/head:pull/21993
$ git checkout pull/21993

Update a local copy of the PR:
$ git checkout pull/21993
$ git pull https://git.openjdk.org/jdk.git pull/21993/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21993

View PR using the GUI difftool:
$ git pr show -t 21993

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21993.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back kevinw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@kevinjwalls This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8343838: Test EmptyDomainNotificationTest.java fails with ListenerNotFoundException

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

• 36e1295: 8343929: Remove PreservedMarksSet::createTask() after JDK-8305895
• b1a9491: 8343321: Bad verify in LockStack::oops_do()
• cbe8448: 8268895: Do not filter out man pages from build
• ec13364: 8343067: C2: revisit constant-offset AddP chains after successful input idealizations
• 5ca6698: 8341176: Permit access to diagnostics for transient snippets
• a93bd9d: 8343810: [s390x] is_uimm* methods should take unsigned arguments
• f12c370: 8343118: [TESTBUG] java/awt/PrintJob/PrintCheckboxTest/PrintCheckboxManualTest.java fails with rror. Can't find HTML file PrintCheckboxManualTest.html
• ae6bb3c: 8343824: Remove unused InstructionFlags in C1
• 5b2f7f3: 8343837: Remove unnecessary reinterpret_cast from C2AccessValuePtr

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@kevinjwalls The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (1996528c)
• 00: Full (5c9db437)

[dholmes-ora]

This seems reasonable.

As we are approaching 400 failures of this test in the CI I'd like to see it integrated ASAP.

Thanks

[dholmes-ora]

I had to add the test to the ProblemList, so please remove it again. Thanks

[kevinjwalls]

Updated with problemlist removal.
Clean run from tier3 testing.

[kevinjwalls]

Thanks David!

[kevinjwalls]

/integrate

[openjdk]

Going to push as commit 5016132.
Since your change was applied there have been 9 commits pushed to the master branch:

• 36e1295: 8343929: Remove PreservedMarksSet::createTask() after JDK-8305895
• b1a9491: 8343321: Bad verify in LockStack::oops_do()
• cbe8448: 8268895: Do not filter out man pages from build
• ec13364: 8343067: C2: revisit constant-offset AddP chains after successful input idealizations
• 5ca6698: 8341176: Permit access to diagnostics for transient snippets
• a93bd9d: 8343810: [s390x] is_uimm* methods should take unsigned arguments
• f12c370: 8343118: [TESTBUG] java/awt/PrintJob/PrintCheckboxTest/PrintCheckboxManualTest.java fails with rror. Can't find HTML file PrintCheckboxManualTest.html
• ae6bb3c: 8343824: Remove unused InstructionFlags in C1
• 5b2f7f3: 8343837: Remove unnecessary reinterpret_cast from C2AccessValuePtr

Your commit was automatically rebased without conflicts.

[openjdk]

@kevinjwalls Pushed as commit 5016132.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.