New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8252817: Cleanup the classes in the java.awt.color package #22
Conversation
- Class declarations cleanup - docs cleanup
/** | ||
* ICC Profile Color Space Type Signature: 'XYZ '. | ||
*/ | ||
public static final int icSigXYZData = 0x58595A20; /* 'XYZ ' */ | ||
public static final int icSigXYZData = 0x58595A20; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inline comment:
Looks like this type of documentation was used before we added javadoc for each constant.
|
@mrserb The following labels will be automatically applied to this pull request: |
/test tier1 |
Could not create test job |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@mrserb This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements After integration, the commit message will be:
Since the source branch of this PR was last updated there have been 44 commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
/integrate |
@mrserb Since your change was applied there have been 44 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit ff21696. |
RISC-V: loom: Fix another frame::sender_sp_offset issue in stackChunkOopDesc::is_usable_in_chunk
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/22/head:pull/22
$ git checkout pull/22