Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8252817: Cleanup the classes in the java.awt.color package #22

Closed
wants to merge 1 commit into from

Conversation

@mrserb
Copy link
Member

@mrserb mrserb commented Sep 5, 2020

  • Class declarations reformat
  • Docs cleanup

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8252817: Cleanup the classes in the java.awt.color package

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/22/head:pull/22
$ git checkout pull/22

- Class declarations cleanup
- docs cleanup
/**
* ICC Profile Color Space Type Signature: 'XYZ '.
*/
public static final int icSigXYZData = 0x58595A20; /* 'XYZ ' */
public static final int icSigXYZData = 0x58595A20;

Copy link
Member Author

@mrserb mrserb Sep 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inline comment:
Looks like this type of documentation was used before we added javadoc for each constant.

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 5, 2020

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@mrserb mrserb marked this pull request as ready for review Sep 5, 2020
@openjdk openjdk bot added the rfr label Sep 5, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 5, 2020

@mrserb The following labels will be automatically applied to this pull request: 2d. When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the 2d label Sep 5, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 5, 2020

Webrevs

@mrserb
Copy link
Member Author

@mrserb mrserb commented Sep 5, 2020

/test tier1

@openjdk
Copy link

@openjdk openjdk bot commented Sep 5, 2020

Could not create test job

Copy link
Member

@jayathirthrao jayathirthrao left a comment

Looks good to me.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 9, 2020

@mrserb This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8252817: Cleanup the classes in the java.awt.color package

Reviewed-by: jdv, pbansal
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 44 commits pushed to the master branch:

  • 44a74da: 8252919: JDK built with --enable-cds=no fails with NoClassDefFoundError
  • 418e4a2: 8252830: Correct missing javadoc comments in java.rmi module
  • 41d29b7: 8252774: remove jdk.test.lib.FileInstaller action from graalunit tests
  • 5b30a83: 8252778: remove jdk.test.lib.FileInstaller action from compiler/c2/stemmer test
  • 8db3335: 8247928: Refactor G1ConcurrentMarkThread for mark abort
  • 7ccf435: 8252846: Fix ppc/s390 after "8231441: AArch64: Initial SVE backend su…
  • d236cf4: 8252995: Non-PCH builds broken by JDK-8250961
  • 6a00534: 8250961: Move Universe::update_heap_info_at_gc to CollectedHeap
  • f78f780: 8252889: Obsolete -XX:+InsertMemBarAfterArraycopy
  • f933961: 8252980: comment only changes extracted from JDK-8247281
  • ... and 34 more: https://git.openjdk.java.net/jdk/compare/4b3a0b789ebf389a9589c9af2d3922fb91916d92...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 44a74dac957ca7cc10eaddafb6bd32b74a8d84c8.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 9, 2020
Copy link

@pankaj-bansal pankaj-bansal left a comment

+1

@mrserb
Copy link
Member Author

@mrserb mrserb commented Sep 10, 2020

/integrate

@openjdk openjdk bot closed this Sep 10, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 10, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 10, 2020

@mrserb Since your change was applied there have been 44 commits pushed to the master branch:

  • 44a74da: 8252919: JDK built with --enable-cds=no fails with NoClassDefFoundError
  • 418e4a2: 8252830: Correct missing javadoc comments in java.rmi module
  • 41d29b7: 8252774: remove jdk.test.lib.FileInstaller action from graalunit tests
  • 5b30a83: 8252778: remove jdk.test.lib.FileInstaller action from compiler/c2/stemmer test
  • 8db3335: 8247928: Refactor G1ConcurrentMarkThread for mark abort
  • 7ccf435: 8252846: Fix ppc/s390 after "8231441: AArch64: Initial SVE backend su…
  • d236cf4: 8252995: Non-PCH builds broken by JDK-8250961
  • 6a00534: 8250961: Move Universe::update_heap_info_at_gc to CollectedHeap
  • f78f780: 8252889: Obsolete -XX:+InsertMemBarAfterArraycopy
  • f933961: 8252980: comment only changes extracted from JDK-8247281
  • ... and 34 more: https://git.openjdk.java.net/jdk/compare/4b3a0b789ebf389a9589c9af2d3922fb91916d92...master

Your commit was automatically rebased without conflicts.

Pushed as commit ff21696.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the JDK-8252817 branch Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants