Skip to content

8343894: ProblemList javax/management/remote/mandatory/notif/EmptyDomainNotificationTest.java #22001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dholmes-ora
Copy link
Member

@dholmes-ora dholmes-ora commented Nov 11, 2024

This is causing hundreds of failures in our CI and JDK-8343838 may not be fixed for a number of hours yet.

Thanks


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8343894: ProblemList javax/management/remote/mandatory/notif/EmptyDomainNotificationTest.java (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22001/head:pull/22001
$ git checkout pull/22001

Update a local copy of the PR:
$ git checkout pull/22001
$ git pull https://git.openjdk.org/jdk.git pull/22001/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22001

View PR using the GUI difftool:
$ git pr show -t 22001

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22001.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 11, 2024

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 11, 2024

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8343894: ProblemList javax/management/remote/mandatory/notif/EmptyDomainNotificationTest.java

Reviewed-by: jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 11, 2024
@openjdk
Copy link

openjdk bot commented Nov 11, 2024

@dholmes-ora To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@dholmes-ora
Copy link
Member Author

/label add serviceability-dev

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Nov 11, 2024
@openjdk
Copy link

openjdk bot commented Nov 11, 2024

@dholmes-ora
The serviceability label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Nov 11, 2024

Webrevs

Copy link
Member

@jaikiran jaikiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable and trivial to me.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 11, 2024
@dholmes-ora
Copy link
Member Author

Thanks @jaikiran !

/integrate

@openjdk
Copy link

openjdk bot commented Nov 11, 2024

Going to push as commit 7b0f273.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 11, 2024
@openjdk openjdk bot closed this Nov 11, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 11, 2024
@openjdk
Copy link

openjdk bot commented Nov 11, 2024

@dholmes-ora Pushed as commit 7b0f273.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dholmes-ora dholmes-ora deleted the JDK-8343894-PL branch November 11, 2024 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants