8342811: java/net/httpclient/PlainProxyConnectionTest.java failed: Unexpected connection count: 5

[vy]

This PR introduces the following changes addressing intermittent PlainProxyConnectionTest failures reported in JDK-8342811:

• Increase logging verbosity to aid in troubleshooting (if the failure happens to pop up again)
• Add salt to the used HTTP server path to decrease the chances of parallel running tests from interfering

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8342811: java/net/httpclient/PlainProxyConnectionTest.java failed: Unexpected connection count: 5 (Bug - P4)

Reviewers

• Daniel Fuchs (@dfuch - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22003/head:pull/22003
$ git checkout pull/22003

Update a local copy of the PR:
$ git checkout pull/22003
$ git pull https://git.openjdk.org/jdk.git pull/22003/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22003

View PR using the GUI difftool:
$ git pr show -t 22003

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22003.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

Hi @vy, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user vy" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[openjdk]

@vy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8342811: java/net/httpclient/PlainProxyConnectionTest.java failed: Unexpected connection count: 5

Reviewed-by: dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 142 new commits pushed to the master branch:

• f316808: 8344189: Cleanup code in sun.net.www.protocol.mailto.MailToURLConnection and sun.net.smtp after JEP 486 integration
• 73fd891: 8344216: Remove calls to SecurityManager and and doPrivileged in java.net.Authenticator, java.net.CookieHandler, and java.net.ResponseCache after JEP 486 integration
• f62e05e: 8344231: SecurityManager cleanup in java.lang.module and jdk.internal.module
• 1bb0d3b: 8344062: Remove doPrivileged calls from awt and beans classes in the java.desktop module
• fc8fb34: 8344214: Remove Security Manager dependencies from jdk.crypto.mscapi module
• ff12ff5: 8340453: C2: Improve encoding of LoadNKlass for compact headers
• 1866c0c: 8344259: Annotate Float16 with jdk.internal.ValueBased
• 0b9b82a: 8343039: Remove jdk.internal.misc.InternalLock and usages from java.io
• 3c38ed4: 8344314: Revert removal of jdk.internal.java.PreviewFeature.CLASSFILE_API
• 40a055e: 8344228: Revisit SecurityManager usage in java.net.http after JEP 486 integration
• ... and 132 more: https://git.openjdk.org/jdk/compare/7d6a2f3740bf42652bdf05bb922d1f2b2ae60d6a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dfuch) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[vy]

/covered

[openjdk]

@vy The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[bridgekeeper]

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

[mlbridge]

Webrevs

• 02: Full - Incremental (8cec4a77)
• 01: Full - Incremental (295ff767)
• 00: Full (57912c0f)

[vy]

/integrate

[openjdk]

@vy
Your change (at version 8cec4a7) is now ready to be sponsored by a Committer.

[dfuch]

/sponsor

[openjdk]

Going to push as commit 59ffac8.
Since your change was applied there have been 142 commits pushed to the master branch:

• f316808: 8344189: Cleanup code in sun.net.www.protocol.mailto.MailToURLConnection and sun.net.smtp after JEP 486 integration
• 73fd891: 8344216: Remove calls to SecurityManager and and doPrivileged in java.net.Authenticator, java.net.CookieHandler, and java.net.ResponseCache after JEP 486 integration
• f62e05e: 8344231: SecurityManager cleanup in java.lang.module and jdk.internal.module
• 1bb0d3b: 8344062: Remove doPrivileged calls from awt and beans classes in the java.desktop module
• fc8fb34: 8344214: Remove Security Manager dependencies from jdk.crypto.mscapi module
• ff12ff5: 8340453: C2: Improve encoding of LoadNKlass for compact headers
• 1866c0c: 8344259: Annotate Float16 with jdk.internal.ValueBased
• 0b9b82a: 8343039: Remove jdk.internal.misc.InternalLock and usages from java.io
• 3c38ed4: 8344314: Revert removal of jdk.internal.java.PreviewFeature.CLASSFILE_API
• 40a055e: 8344228: Revisit SecurityManager usage in java.net.http after JEP 486 integration
• ... and 132 more: https://git.openjdk.org/jdk/compare/7d6a2f3740bf42652bdf05bb922d1f2b2ae60d6a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dfuch @vy Pushed as commit 59ffac8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.