8343946: JFR: Wildcard should only work with COUNT for 'jfr view'

[egahlin]

Could I have a review of a PR that fixes a query validation bug for 'jfr view'?

When '*' is used as a field name with an aggregator function, the implementation defaults to using the 'startTime' field, resulting in the field expression COUNT(startTime). Unfortunately, this behavior allows the aggregate function to bypass validation. This issue can be fixed by checking against the actual text rather than the field name.

The lack of validation led to incorrect numbers being used for the 'Threads' column in the contention-by-address view.

Testing: jdk/jdk/jfr and manual inspection.

Thanks
Erik

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8343946: JFR: Wildcard should only work with COUNT for 'jfr view' (Bug - P3)

Reviewers

• Markus Grönlund (@mgronlun - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22018/head:pull/22018
$ git checkout pull/22018

Update a local copy of the PR:
$ git checkout pull/22018
$ git pull https://git.openjdk.org/jdk.git pull/22018/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22018

View PR using the GUI difftool:
$ git pr show -t 22018

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22018.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8343946: JFR: Wildcard should only work with COUNT for 'jfr view'

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• 889f906: 8343774: Positive list platforms for ir checks of compiler/c2/TestCastX2NotProcessedIGVN.java
• 6088d62: 8343755: Unproblemlist java/lang/Thread/jni/AttachCurrentThread/AttachTest.java

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@egahlin The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (56beb9e8)

[egahlin]

/integrate

[openjdk]

Going to push as commit e5eaa7f.
Since your change was applied there have been 16 commits pushed to the master branch:

• 2989d87: 8343805: RISC-V: JVM crashes on startup when disabling compressed instructions
• 78b8015: 8338383: Implement JEP 491: Synchronize Virtual Threads without Pinning
• 8a2a75e: 8339892: Several security shell tests don't set TESTJAVAOPTS
• 50b6e41: 8300732: Whitebox functions for Metaspace test should use byte size
• 67d1ef1: 8344018: Remove unlimited memory setting from TestScalarReplacementMaxLiveNodes
• 5729227: 8343250: ArrayBlockingQueue serialization not thread safe
• 2c1e4c3: 8343600: RISC-V: enable CRC32 intrinsic when either Zba or RVV are supported
• 3727f40: 8343745: Only update Last Value Assertion Predicates in Loop Unrolling
• b53ee05: 8202617: javadoc generates broken links to undocumented (e.g. private) members
• cfe719f: 8340565: Create separate index page for terms defined by the index tag
• ... and 6 more: https://git.openjdk.org/jdk/compare/80f4c0c38a57960a1c96de72af6fc69ef10337ce...master

Your commit was automatically rebased without conflicts.

[openjdk]

@egahlin Pushed as commit e5eaa7f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.