8344014: Simplify TracePhase constructor

[tstuefe]

As a prerequisite for JDK-8344009, TracePhase constructor needs to know the PhaseTraceId. And while we are at it, it can be simplified: trace strings can be kept in via x-macro with the IDs, and it is sufficient to pass in the IDs, no need to pass the pointer to the counters since we use the same counters anyway.

Since this is a somewhat invasive but purely mechanical change, I separate this work from JDK-8344009.

There are no functional changes. Trace texts have been faithfully taken over, even in the case where the original TracePhase constructor invocation got fed an empty string (_t_vector and _t_renumberLive) - whether this was intentional or not, this patch does not change it.

The patch preserves the possibility to override the phase name with an explicit argument to the constructor. This is used in one existing case ("computeLive (sbplr)"), again, to faithfully preserve the log format.

Test: I checked manually with +CITimeVerbose with and without patch and compared the output; output format is preserved.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8344014: Simplify TracePhase constructor (Enhancement - P4)

Reviewers

• Dean Long (@dean-long - Reviewer)
• Roland Westrelin (@rwestrel - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22029/head:pull/22029
$ git checkout pull/22029

Update a local copy of the PR:
$ git checkout pull/22029
$ git pull https://git.openjdk.org/jdk.git pull/22029/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22029

View PR using the GUI difftool:
$ git pr show -t 22029

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22029.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8344014: Simplify TracePhase constructor

Reviewed-by: dlong, roland

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

• d334af0: 8344089: Fix wrong location of TestWrongMinLWiden.java
• 79345bb: 8339783: Implement JEP 479: Remove the Windows 32-bit x86 Port
• 2eeaa57: 8343944: C2: MinLNode::add_ring() computes _widen wrongly leading to an endless widening/compilation
• e9ede46: 8343508: Parallel: Use ordinary klass accessor in verify_filler_in_dense_prefix
• c78de7b: 8343964: RISC-V: Improve PrintOptoAssembly output for loadNKlassCompactHeaders node
• eb40a88: 8343430: RISC-V: C2: Remove old trampoline call
• b26e495: 8343801: Change string printed by nsk_null_string for null strings
• a4e2c20: 8343344: Windows attach logic failed to handle a failed open on a pipe
• 63eb485: 8343883: Cannot resolve user specified toolchain-path for lld after JDK-8338304
• db85090: 8338411: Implement JEP 486: Permanently Disable the Security Manager
• ... and 15 more: https://git.openjdk.org/jdk/compare/cbf4dd588bf371e13e81204b1585d34bfadddb42...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@tstuefe The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[tstuefe]

Mac OS error unrelated.

[tstuefe]

/label add hotspot-compiler
/label remove hotspot

[openjdk]

@tstuefe
The hotspot-compiler label was successfully added.

[openjdk]

@tstuefe
The hotspot label was successfully removed.

[mlbridge]

Webrevs

• 00: Full (7a66398d)

[dean-long]

/reviewers 2

[openjdk]

@dean-long
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

[dean-long]

This looks OK, but doesn't seem strictly necessary for JDK-8344009. We could get the PhaseTraceId from accumulator - &Phase::timers[0].

[tstuefe]

This looks OK, but doesn't seem strictly necessary for JDK-8344009. We could get the PhaseTraceId from accumulator - &Phase::timers[0].

I thought so too, but it seemed a bit ugly and brittle, and the simplification seemed worth it anyhow.

[rwestrel]

Looks good to me.

[tstuefe]

Thank you @dean-long and @rwestrel !

[tstuefe]

/integrate

[openjdk]

Going to push as commit 133f8f3.
Since your change was applied there have been 25 commits pushed to the master branch:

• d334af0: 8344089: Fix wrong location of TestWrongMinLWiden.java
• 79345bb: 8339783: Implement JEP 479: Remove the Windows 32-bit x86 Port
• 2eeaa57: 8343944: C2: MinLNode::add_ring() computes _widen wrongly leading to an endless widening/compilation
• e9ede46: 8343508: Parallel: Use ordinary klass accessor in verify_filler_in_dense_prefix
• c78de7b: 8343964: RISC-V: Improve PrintOptoAssembly output for loadNKlassCompactHeaders node
• eb40a88: 8343430: RISC-V: C2: Remove old trampoline call
• b26e495: 8343801: Change string printed by nsk_null_string for null strings
• a4e2c20: 8343344: Windows attach logic failed to handle a failed open on a pipe
• 63eb485: 8343883: Cannot resolve user specified toolchain-path for lld after JDK-8338304
• db85090: 8338411: Implement JEP 486: Permanently Disable the Security Manager
• ... and 15 more: https://git.openjdk.org/jdk/compare/cbf4dd588bf371e13e81204b1585d34bfadddb42...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tstuefe Pushed as commit 133f8f3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.