Skip to content

8354791: Use Hashtable.putIfAbsent in CSS constructor#22032

Closed
turbanoff wants to merge 2 commits intoopenjdk:masterfrom
turbanoff:CSS_Hashtable.putIfAbsent
Closed

8354791: Use Hashtable.putIfAbsent in CSS constructor#22032
turbanoff wants to merge 2 commits intoopenjdk:masterfrom
turbanoff:CSS_Hashtable.putIfAbsent

Conversation

@turbanoff
Copy link
Member

@turbanoff turbanoff commented Nov 12, 2024

We can use Hashtable.putIfAbsent instead of pair get/put methods.
It's faster and cleaner.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8354791: Use Hashtable.putIfAbsent in CSS constructor (Enhancement - P5)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22032/head:pull/22032
$ git checkout pull/22032

Update a local copy of the PR:
$ git checkout pull/22032
$ git pull https://git.openjdk.org/jdk.git pull/22032/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22032

View PR using the GUI difftool:
$ git pr show -t 22032

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22032.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 12, 2024

👋 Welcome back aturbanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 12, 2024

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8354791: Use Hashtable.putIfAbsent in CSS constructor

Reviewed-by: serb, aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2413 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Nov 12, 2024

@turbanoff The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Nov 12, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 10, 2024

@turbanoff This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 7, 2025

@turbanoff This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Jan 7, 2025
@turbanoff
Copy link
Member Author

/open

@turbanoff turbanoff changed the title [PATCH] CSS. Use Hashtable.putIfAbsent instead of pair get/put 8354791: Use Hashtable.putIfAbsent in CSS constructor Apr 16, 2025
@openjdk openjdk bot reopened this Apr 16, 2025
@openjdk
Copy link

openjdk bot commented Apr 16, 2025

@turbanoff This pull request is now open

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 16, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 16, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 16, 2025
@turbanoff
Copy link
Member Author

Any more reviews ?

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Apr 29, 2025
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 29, 2025
@turbanoff
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 30, 2025

Going to push as commit 0110aca.
Since your change was applied there have been 2421 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 30, 2025
@openjdk openjdk bot closed this Apr 30, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 30, 2025
@openjdk
Copy link

openjdk bot commented Apr 30, 2025

@turbanoff Pushed as commit 0110aca.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@aivanov-jdk
Copy link
Member

I ran the client tests again two days ago, the CI was green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants