8354791: Use Hashtable.putIfAbsent in CSS constructor#22032
8354791: Use Hashtable.putIfAbsent in CSS constructor#22032turbanoff wants to merge 2 commits intoopenjdk:masterfrom
Conversation
|
👋 Welcome back aturbanov! A progress list of the required criteria for merging this PR into |
|
@turbanoff This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2413 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
@turbanoff The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
|
@turbanoff This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
@turbanoff This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the |
|
/open |
|
@turbanoff This pull request is now open |
Webrevs
|
|
Any more reviews ? |
|
/integrate |
|
Going to push as commit 0110aca.
Your commit was automatically rebased without conflicts. |
|
@turbanoff Pushed as commit 0110aca. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
|
I ran the client tests again two days ago, the CI was green. |
We can use Hashtable.putIfAbsent instead of pair
get/putmethods.It's faster and cleaner.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22032/head:pull/22032$ git checkout pull/22032Update a local copy of the PR:
$ git checkout pull/22032$ git pull https://git.openjdk.org/jdk.git pull/22032/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 22032View PR using the GUI difftool:
$ git pr show -t 22032Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22032.diff
Using Webrev
Link to Webrev Comment