Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8260169: LogCompilation: Unexpected method mismatch #2205

Closed
wants to merge 1 commit into from

Conversation

@ericcaspole
Copy link

@ericcaspole ericcaspole commented Jan 22, 2021

This change checks the phase and scopes so the call stack model is preserved correctly as we process the compilation log. Tested with various JDK 8 and 17, +/-TieredCompilation, with Renaissance, jvm2008, dacapo etc logs as inputs.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8260169: LogCompilation: Unexpected method mismatch

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2205/head:pull/2205
$ git checkout pull/2205

…nce.neo4j.JmhNeo4jAnalytics
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 22, 2021

👋 Welcome back ecaspole! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jan 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 22, 2021

@ericcaspole The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 22, 2021

Webrevs

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Good.

@openjdk
Copy link

@openjdk openjdk bot commented Jan 22, 2021

@ericcaspole This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260169: LogCompilation: Unexpected method mismatch

Reviewed-by: kvn, vlivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 52 new commits pushed to the master branch:

  • 5cdcce1: 8260307: Do not include method.hpp in frame.hpp
  • 6f2a394: Merge
  • 685c03d: 8259271: gc/parallel/TestDynShrinkHeap.java still fails "assert(covered_region.contains(new_memregion)) failed: new region is not in covered_region"
  • d90e06a: 8259775: [Vector API] Incorrect code-gen for VectorReinterpret operation
  • ede1bea: 8227695: assert(pss->trim_ticks().seconds() == 0.0) failed: Unexpected partial trimming during evacuation
  • 62eab50: 8255199: Catching a few NumberFormatExceptions in xmldsig
  • a5367cb: 8247619: Improve Direct Buffering of Characters
  • aa57d07: 8259214: MetaspaceClosure support for Arrays of MetaspaceObj
  • bdc305e: 8258917: NativeMemoryTracking is handled by launcher inconsistenly
  • 7be9113: 8255216: Change _directive->BreakAtCompileOption to env()->break_at_compile()
  • ... and 42 more: https://git.openjdk.java.net/jdk/compare/0785147460934ee2aa413ab7872837094824bd3d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 22, 2021
Copy link

@iwanowww iwanowww left a comment

Looks good.

@ericcaspole
Copy link
Author

@ericcaspole ericcaspole commented Jan 25, 2021

/integrate

@openjdk openjdk bot closed this Jan 25, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 25, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 25, 2021

@ericcaspole Since your change was applied there have been 66 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit d076977.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@ericcaspole ericcaspole deleted the ericcaspole:JDK-8260169 branch Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants