Skip to content

8343884: [s390x] Disallow OptoScheduling #22059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

offamitkumar
Copy link
Member

@offamitkumar offamitkumar commented Nov 13, 2024

amit@a3560042:~/jdk$ ./build/linux-s390x-server-fastdebug/jdk/bin/java -XX:+OptoScheduling --version 
OpenJDK 64-Bit Server VM warning: OptoScheduling is not supported on this CPU.
openjdk 24-internal 2025-03-18
OpenJDK Runtime Environment (fastdebug build 24-internal-adhoc.amit.jdk)
OpenJDK 64-Bit Server VM (fastdebug build 24-internal-adhoc.amit.jdk, mixed mode)
amit@a3560042:~/jdk$

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8343884: [s390x] Disallow OptoScheduling (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22059/head:pull/22059
$ git checkout pull/22059

Update a local copy of the PR:
$ git checkout pull/22059
$ git pull https://git.openjdk.org/jdk.git pull/22059/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22059

View PR using the GUI difftool:
$ git pr show -t 22059

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22059.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 13, 2024

👋 Welcome back amitkumar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 13, 2024

@offamitkumar This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8343884: [s390x]  Disallow OptoScheduling

Reviewed-by: lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 207 new commits pushed to the master branch:

  • 9d60300: 8344199: Incorrect excluded field value set by getEventWriter intrinsic
  • 8bd080b: 8341901: Using 'var' keyword switch pattern matching causes compiler error
  • 76a55c3: 8341334: CDS: Parallel relocation
  • 499186b: 8343902: javax/swing/plaf/nimbus/8041642/bug8041642.java fails in ubuntu22.04
  • b12c5b4: 8344218: Remove calls to SecurityManager and and doPrivileged in java.net.NetworkInterface after JEP 486 integration
  • d85dd77: 8344365: SecurityManager cleanups in java.sql and java.sql.rowset modules
  • 9e92a9e: 8344059: Remove doPrivileged calls from windows platform sources in the java.desktop module
  • 3729884: 8344371: RISC-V: compiler/intrinsics/chacha/TestChaCha20.java fails after JDK-8343555
  • dd86369: 8344262: Win32AttachOperationRequest objects are created by using global new
  • 5cb0d43: 8293040: Argfile documentation for java launcher tool is confusing regarding usage of wildcards
  • ... and 197 more: https://git.openjdk.org/jdk/compare/068f4ce8bc0fb43417c6493597160b49554221d3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8343884 8343884: [s390x] Disallow OptoScheduling Nov 13, 2024
@openjdk
Copy link

openjdk bot commented Nov 13, 2024

@offamitkumar The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Nov 13, 2024
@offamitkumar offamitkumar marked this pull request as ready for review November 13, 2024 06:24
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 13, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 13, 2024

Webrevs

@offamitkumar
Copy link
Member Author

@RealLucy another trivial change :)

Copy link
Contributor

@RealLucy RealLucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one looks good, and is trivial and helpful.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 19, 2024
@offamitkumar
Copy link
Member Author

Thank you Lutz.
/integrate

@openjdk
Copy link

openjdk bot commented Nov 19, 2024

Going to push as commit 7540fa2.
Since your change was applied there have been 207 commits pushed to the master branch:

  • 9d60300: 8344199: Incorrect excluded field value set by getEventWriter intrinsic
  • 8bd080b: 8341901: Using 'var' keyword switch pattern matching causes compiler error
  • 76a55c3: 8341334: CDS: Parallel relocation
  • 499186b: 8343902: javax/swing/plaf/nimbus/8041642/bug8041642.java fails in ubuntu22.04
  • b12c5b4: 8344218: Remove calls to SecurityManager and and doPrivileged in java.net.NetworkInterface after JEP 486 integration
  • d85dd77: 8344365: SecurityManager cleanups in java.sql and java.sql.rowset modules
  • 9e92a9e: 8344059: Remove doPrivileged calls from windows platform sources in the java.desktop module
  • 3729884: 8344371: RISC-V: compiler/intrinsics/chacha/TestChaCha20.java fails after JDK-8343555
  • dd86369: 8344262: Win32AttachOperationRequest objects are created by using global new
  • 5cb0d43: 8293040: Argfile documentation for java launcher tool is confusing regarding usage of wildcards
  • ... and 197 more: https://git.openjdk.org/jdk/compare/068f4ce8bc0fb43417c6493597160b49554221d3...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 19, 2024
@openjdk openjdk bot closed this Nov 19, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 19, 2024
@openjdk
Copy link

openjdk bot commented Nov 19, 2024

@offamitkumar Pushed as commit 7540fa2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@offamitkumar offamitkumar deleted the opto_disable branch November 20, 2024 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants