8343889: Test runtime/cds/appcds/redefineClass/RedefineBasicTest.java failed

[calvinccheung]

Fixing the tests under test/hotspot/jtreg/runtime/cds/appcds/jvmti/redefineClasses so that the @run driver RedefineClassHelper comes before any @build command so that subsequent tests can find classes under the test.lib.helpers package such as the ClassFileInstaller class.

Revert the changes, which was done via JDK-8342303, to the following tests as the changes are not needed with the current fix.

test/hotspot/jtreg/runtime/cds/appcds/redefineClass/RedefineBasicTest.java
test/hotspot/jtreg/runtime/cds/appcds/redefineClass/RedefineRunningMethods_Shared.java
test/hotspot/jtreg/runtime/logging/RedefineClasses.java

This change also adds @requires vm.cds to the tests so it also fixes JDK-8344046.

Testing:

• passed tiers 1, 4 tests

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issues

• JDK-8343889: Test runtime/cds/appcds/redefineClass/RedefineBasicTest.java failed (Bug - P4)
• JDK-8344046: Tests under cds/appcds/jvmti/redefineClasses should have @requires vm.cds (Bug - P4)

Reviewers

• Ioi Lam (@iklam - Reviewer)
• Matias Saavedra Silva (@matias9927 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22085/head:pull/22085
$ git checkout pull/22085

Update a local copy of the PR:
$ git checkout pull/22085
$ git pull https://git.openjdk.org/jdk.git pull/22085/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22085

View PR using the GUI difftool:
$ git pr show -t 22085

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22085.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ccheung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@calvinccheung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8343889: Test runtime/cds/appcds/redefineClass/RedefineBasicTest.java failed
8344046: Tests under cds/appcds/jvmti/redefineClasses should have @requires vm.cds

Reviewed-by: iklam, matsaave

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

• 168b18e: 8343958: Remove security manager impl in java.lang.Process and java.lang.Runtime.exec
• 5ac330b: 8344039: Remove security manager dependency in java.time
• 1eb38c8: 8343219: Manual clientlibs test failures after SM removal
• dde6230: 8343416: CDS dump fails when unregistered class can also be loaded from system modules
• ffea980: 8344023: Unnecessary Hashtable usage in LdapClient.defaultBinaryAttrs
• 5e01c40: 8343981: Remove usage of security manager from Thread and related classes
• dbf2346: 8341260: Add Float16 to jdk.incubator.vector
• a5f11b5: 8343483: Remove unnecessary @SuppressWarnings annotations (serviceability)
• 7be7772: 8344112: Remove code to support security manager execution mode from DatagramChannel implementation
• bd3fec3: 8344086: Remove security manager dependency in FFM
• ... and 17 more: https://git.openjdk.org/jdk/compare/a4e2c20849008d5b560f94b58fe70ef8e58c8d4c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@calvinccheung The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (c617041f)

[iklam]

LGTM. I think the underlying issue is jtreg has the tendency of placing class files in unpredictable locations (e.g., CODETOOLS-7902847). So unfortunately the only way to fix that is a whack-a-mole approach.

[calvinccheung]

/issue add JDK-8344046

[openjdk]

@calvinccheung
Adding additional issue to issue list: 8344046: Tests under cds/appcds/jvmti/redefineClasses should have @requires vm.cds.

[matias9927]

LGTM

[calvinccheung]

Thanks @iklam and @matias9927.

/integrate

[openjdk]

Going to push as commit 4d4951a.
Since your change was applied there have been 56 commits pushed to the master branch:

• 697f27c: 8341964: Add mechanism to disable different parts of TLS cipher suite
• 002b985: 8342963: TestLargeStub::testUpcall doesn't test upcalls stubs
• e12f514: 8343781: Add since checker test to the Serviceability area modules
• 7e9dfa4: 8343785: (fs) Remove syscalls that set file times with microsecond precision
• 68164a4: 8343953: Test jdk/jfr/threading/TestDeepVirtualStackTrace.java fails with Parallel/Serial GC
• 752e162: 8343877: Test AsyncClose.java intermittent fails - Socket.getInputStream().read() wasn't preempted
• 4d1a51c: 8344120: Remove Security Manager dependencies from jdk.crypto.cryptoki module
• a73226b: 8297692: Avoid sending per-region GCPhaseParallel JFR events in G1ScanCollectionSetRegionClosure
• 6e28cd3: 8343488: Test VectorRebracket128Test.java can't exclude by test/hotspot/jtreg/ProblemList.txt
• 6757994: 8343633: The ClassLoader::print_counters() prints to stdout when logging is enabled.
• ... and 46 more: https://git.openjdk.org/jdk/compare/a4e2c20849008d5b560f94b58fe70ef8e58c8d4c...master

Your commit was automatically rebased without conflicts.

[openjdk]

@calvinccheung Pushed as commit 4d4951a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.