-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8343982: Remove usage of security manager from ClassLoader and related classes #22097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back alanb! A progress list of the required criteria for merging this PR into |
@AlanBateman This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 15 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@AlanBateman The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
src/java.base/share/classes/jdk/internal/loader/BuiltinClassLoader.java
Outdated
Show resolved
Hide resolved
BootLoader.java and BuiltinClassLoader.java are missing a copyright year update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The update to use findResourceOnClassPath()
and the rest of the changes in this PR look good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me Alan
/integrate |
Going to push as commit 0ae5748.
Your commit was automatically rebased without conflicts. |
@AlanBateman Pushed as commit 0ae5748. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Remove the code for the now defunct SecurityManager execution mode from ClassLoader and the built-in class loader implementations. The override of getPermissions is removed from the application class loader, and from the class loaders used to support module layers.
URLCassLoader (and its implementation URLClassPath) will be handled separately as there are spec changes required, and code in URLClassPath that requires special attention.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22097/head:pull/22097
$ git checkout pull/22097
Update a local copy of the PR:
$ git checkout pull/22097
$ git pull https://git.openjdk.org/jdk.git pull/22097/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 22097
View PR using the GUI difftool:
$ git pr show -t 22097
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22097.diff
Using Webrev
Link to Webrev Comment