8344205: [PPC]: failing assertion: sharedRuntime_ppc.cpp:1652: cookie not found

[reinrich]

This PR removes the bad assertion that fails when leaving a continuation because the cookie value is not found in frame::common_abi::cr.
This is because after the cookie is stored there when entering the continuation it is overridden by the runtime call to thaw frames. This is compliant with the abi.
Strangely the assertion only ever failed on aix.

Testing: compiler/codecache/stress/UnexpectedDeoptimizationTest.java always failed since the bad assertion was introduced recently. It succeeds after removal.

The fix passed our CI testing:
Tier 1-4 of hotspot and jdk. All of Langtools and jaxp. Renaissance Suite and SAP specific tests.
Testing was done on the main platforms and also on Linux/PPC64le and AIX.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8344205: [PPC]: failing assertion: sharedRuntime_ppc.cpp:1652: cookie not found (Bug - P4)

Reviewers

• Martin Doerr (@TheRealMDoerr - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22109/head:pull/22109
$ git checkout pull/22109

Update a local copy of the PR:
$ git checkout pull/22109
$ git pull https://git.openjdk.org/jdk.git pull/22109/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22109

View PR using the GUI difftool:
$ git pr show -t 22109

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22109.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rrich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@reinrich This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8344205: [PPC]: failing assertion: sharedRuntime_ppc.cpp:1652: cookie not found

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 29 new commits pushed to the master branch:

• 3c38ed4: 8344314: Revert removal of jdk.internal.java.PreviewFeature.CLASSFILE_API
• 40a055e: 8344228: Revisit SecurityManager usage in java.net.http after JEP 486 integration
• 84ffb64: 8334714: Implement JEP 484: Class-File API
• 6cdebf0: 8343599: Kmem limit and max values swapped when printing container information
• a672138: 8344161: Argument type mismatch for jfr_type_id
• 3245f56: 8344164: [s390x] ProblemList hotspot/jtreg/runtime/NMT/VirtualAllocCommitMerge.java
• 5e27608: 8344188: Cleanup sun.net.www.protocol.jar.JarFileFactory after JEP 486 integration
• ba39321: 8343881: java.lang.classfile.Attribute attributeName() method should return Utf8Entry
• 75c651f: 8327156: Avoid copying in StringTable::intern(oop, TRAPS)
• 3eece6e: 8341907: javac -Xlint should ignore /// on first line of source file
• ... and 19 more: https://git.openjdk.org/jdk/compare/752e1629555f0ec8630373ec87b049afdd709ea6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@reinrich The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[reinrich]

The macos-x64 test failure is unrelated.

[mlbridge]

Webrevs

• 00: Full (c1707787)

[TheRealMDoerr]

Looks good and trivial.

[reinrich]

Thanks for reviewing, Martin. I'll integrate this as a trivial change now.
Cheers, Richard.
/integrage

[openjdk]

@reinrich Unknown command integrage - for a list of valid commands use /help.

[reinrich]

/integrate

[openjdk]

Going to push as commit 4a7ce1d.
Since your change was applied there have been 56 commits pushed to the master branch:

• b6c2122: 8316151: [macos14] ActionListenerCalledTwiceTest.java fails on macOS 14
• 543e355: 8344298: Test tools/sincechecker/modules/jdk.hotspot.agent/JdkHotspotAgentCheckSince.java fails on platforms without sa
• 92b2631: 8327652: S390x: Implements SLP support
• a47d9ba: 8344349: Problemlist jdk/jfr/jvm/TestVirtualThreadExclusion.java before JDK-8344199 resolved
• 80e37a9: 8344265: RISC-V: Remove unused function get_previous_sp_entry
• e1c4b49: 8343237: Improve the copying of the available set of Currencies
• 41a627b: 8343876: Enhancements to jpackage test lib
• aa10ec7: 8343123: Nimbus: javax/swing/JInternalFrame/bug6726866.java does not have green undecorated window
• fec0d1c: 8343777: Add since checker tests to Internationalisation modules
• d0b770c: 8344289: SM cleanup in jdk.internal.util
• ... and 46 more: https://git.openjdk.org/jdk/compare/752e1629555f0ec8630373ec87b049afdd709ea6...master

Your commit was automatically rebased without conflicts.

[openjdk]

@reinrich Pushed as commit 4a7ce1d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.