Skip to content

8343693: [JVMCI] Override ModifiersProvider.isConcrete in ResolvedJavaType to be isArray() || !isAbstract() #22111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

8343693: [JVMCI] Override ModifiersProvider.isConcrete in ResolvedJavaType to be isArray() || !isAbstract() #22111

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7a56b64
Override ModifiersProvider.isConcrete in ResolvedJavaType
mur47x111 Nov 14, 2024
7f23a82
address comment.
mur47x111 Nov 25, 2024
15dd865
Merge master
mur47x111 Nov 25, 2024
9d14d9d
address comments.
mur47x111 Nov 26, 2024
3b4d58f
Merge master
mur47x111 Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/meta/ModifiersProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,9 +137,11 @@ default boolean isAbstract() {
}

/**
* Checks that this element is concrete and not abstract.
* Returns true if a method is with a real implementation, or if a type can
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"if this element is a method with a concrete implementation, or a type that can be instantiated"

* be instantiated. For example, array types return true for both
* {@link #isAbstract()} and this method.
*
* @return whether this element is concrete
* @see ResolvedJavaType#isConcrete()
*/
default boolean isConcrete() {
return !isAbstract();
Expand Down
10 changes: 10 additions & 0 deletions ...ompiler/jvmci/jdk.vm.ci.runtime.test/src/jdk/vm/ci/runtime/test/TestResolvedJavaType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,16 @@ public void isArrayTest() {
}
}

@Test
public void isConcreteClassTest() {
for (Class<?> c : classes) {
ResolvedJavaType type = metaAccess.lookupJavaType(c);
boolean expected = c.isArray() || !isAbstract(c.getModifiers());
boolean actual = type.isConcrete();
assertEquals(expected, actual);
}
}

@Test
public void lambdaInternalNameTest() {
// Verify that the last dot in lambda types is properly handled when transitioning from
Expand Down